Spec URL: http://oget.fedorapeople.org/review/rtaudio.spec SRPM URL: http://oget.fedorapeople.org/review/rtaudio-4.0.5-1.fc10.src.rpm Description: RtAudio is a set of C++ classes that provide a common API for realtime audio input/output across different operating systems. RtAudio significantly simplifies the process of interacting with computer audio hardware. It was designed with the following objectives: * object-oriented C++ design * simple, common API across all supported platforms * allow simultaneous multi-api support * support dynamic connection of devices * provide extensive audio device parameter control * allow audio device capability probing * automatic internal conversion for data format, channel number compensation, (de)interleaving, and byte-swapping rpmlint: silent
Some notes: - When currently upstream only provides static archive and does not provide shared library, patching Makefiles on vendor side to create share library may cause annnoying problem, e.g. https://www.redhat.com/archives/fedora-packaging/2009-February/msg00047.html Also there is no guarrantee that the API of the created shared library won't change when the major version of the package version does not change. Current Fedora guidelines provides a way to package static archives (when unavoidable) and for this case I think shipping static archive instead of patching on Fedora side is much safer: https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries Note: When switching to creating static archive, passing "-fPIC" is still needed if the archive is needed for creating shared libraries in other application. - Your package does not build on ppc64: http://koji.fedoraproject.org/koji/taskinfo?taskID=1205561 Adding -------------------------------------------------------- cp -p /usr/lib/rpm/config.{sub,guess} config/ -------------------------------------------------------- at the end of %prep will make the build succeed. ref: https://www.redhat.com/archives/fedora-devel-list/2009-February/msg02238.html
Thanks - I will do the ppc64 fix - About the static library, shall I just make a package with just the static library and no dynamic library, or shall I add a -static subpackage and put the .a file in there?
(In reply to comment #2) > - About the static library, shall I just make a package with just the static > library and no dynamic library, > or shall I add a -static subpackage and put the .a file in there? From current guidelines, - create a package "rtaudio-devel" (from "rtaudio" srpm) (for this package, "rtaudio-devel" binary rpm only) * with containing static archives, header files and some documents * rtaudio-devel _must_ have "Provides: rtaudio-staic = %{version}-%{release}". And when other packages need "librtaudio.a" for building, such packages must have "BuildRequires: rtaudio-static", not "BuildRequires: rtaudio-devel" so that we can trace what packages are using static archives for linkage.
OK. Here are the changes: Spec URL: http://oget.fedorapeople.org/review/rtaudio.spec SRPM URL: http://oget.fedorapeople.org/review/rtaudio-4.0.5-2.fc10.src.rpm It builds fine in all archs in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1206042
One thing: - Does files under tests/ create some binaries useful for developers, or these files exist just to check if these files really compile with librtaudio.a? If latter, I think it is better to remove tests/ from %doc and add %check section to execute some tests.
No, it is the former. But I realized that the empty directory tests/Release is really needed to build these binaries. So I shouldn't remove this directory in the %prep. Spec URL: http://oget.fedorapeople.org/review/rtaudio.spec SRPM URL: http://oget.fedorapeople.org/review/rtaudio-4.0.5-3.fc10.src.rpm Changelog: 4.0.5-3 - Don't remove the tests/Release directory
This one is now accepted. ---------------------------------------------------------- This package (rtaudio) is APPROVED by mtasaka ----------------------------------------------------------
Thank you for the review Mamoru. New Package CVS Request ======================= Package Name: rtaudio Short Description: Real-time Audio I/O Library Owners: oget Branches: F-10 InitialCC:
By the way would you have some time to review my new review request (bug 488105)?
Sure. But I'm really busy today (getting married :) ). I can have a look tomorrow.
cvs done. (And congratuations!)
rtaudio-4.0.5-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/rtaudio-4.0.5-3.fc10
thanks :) imported and built on rawhide and F-10.
Thanks, and congratulations from me, too!
rtaudio-4.0.5-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.