Spec URL: http://oget.fedorapeople.org/review/armstrong.spec SRPM URL: http://oget.fedorapeople.org/review/armstrong-0.2.6-1.fc10.src.rpm Description: If you are searching for a foundation for your next soundtracker, armstrong is what you want. armstrong provides an extensible DSP plugin system, a wavetable, instruments, a multitrack sequencer and support for major soundcard APIs. armstrong includes zzub and lunar libraries. Rpmlint: There are bunch of W: devel-file-in-non-devel-package warnings. But these files are really needed during runtime. I know it is weird. If you want to test these libraries you can try aldrin: http://oget.fedorapeople.org/aldrin/ There will be sample files inside /usr/share/aldrin/demosongs/ aldrin is an accepted package but I didn't update it because it requires armstrong-0.2.6.
This package obsoletes/provides libzzub since the upstream changed their name to armstrong. I'm adding Mamoru to CC since he was the original reviewer.
Package updated due to a change in the rtaudio package. Spec URL: http://oget.fedorapeople.org/review/armstrong.spec SRPM URL: http://oget.fedorapeople.org/review/armstrong-0.2.6-2.fc10.src.rpm Changelog: 0.2.6-2 - BR: rtaudio-static instead of rtaudio-devel
PRE-review for 0.2.6-2 (yes, PRE-review...) * About patch - Would you explain what the soname "libzzub.so.0.3" "liblunarstd.so.0" come from? (anyway the soname "libzzub.so.0.3 is wrong, it should be "libzzub.so.0" or so) - Also, non-patched src/plugins/lunar/SConscript seems to be saying that liblunarstd.so is a plugin module, not a system-wide library. Are you sure that this file should really be system-wide library? * License tag - License tag is inherited to all subpackages unless explicitly specified (try $ rpm -qi armstrong-devel or so. I think this should just be "GPLv2+") * internal libraries -------------------------------------------------------------------------- # Remove the binded libraries. We'll use the internal ones -------------------------------------------------------------------------- - You mean "external ones"? * Document directories -------------------------------------------------------------------------- %doc installed_docs/* %{_defaultdocdir}/zzub -------------------------------------------------------------------------- - With this armstrong will own two directories for documents, %{_defaultdocdir}/{zzub,%{name}-%{version}}. I think this is confusing and these directories should be unified. - Also, anyway as this spec file has: -------------------------------------------------------------------------- # We want to install docs to the proper location: mkdir -p installed_docs mv $RPM_BUILD_ROOT%{_docdir}/zzub/* installed_docs/ -------------------------------------------------------------------------- Currently %_defaultdocdir/zzub is just empty.
(In reply to comment #3) > PRE-review for 0.2.6-2 (yes, PRE-review...) > :) Thanks for the PRE-review > * About patch > - Would you explain what the soname "libzzub.so.0.3" "liblunarstd.so.0" > come from? > (anyway the soname "libzzub.so.0.3 is wrong, it should be "libzzub.so.0" > or so) If we use the original tarball with no patches, these libraries will be built with no sonames. The soname "libzzub.so.0.3" comes from the old libzzub package. There the soname was set to "libzzub.so.0.2.3" . I changed this to "libzzub.so.0" now. The soname "liblunarstd.so.0" is the soname I gave to this library. Otherwise rpmlint will complain that there is no soname. > - Also, non-patched src/plugins/lunar/SConscript seems to be saying > that liblunarstd.so is a plugin module, not a system-wide library. > Are you sure that this file should really be system-wide library? > From my understanding this is a system-wide library. There are two systemwide libraries provided by armstrong. One is libzzub, the other is liblunarstd. The unpatched tarball has these two lines: In src/libzzub/SConscript : libzzub = localenv.SharedLibrary('${LIB_BUILD_PATH}/zzub',files) In src/plugins/lunar/SConscript : lunarstd = lunarstdenv.SharedLibrary('${LIB_BUILD_PATH}/lunarstd', lunarstdfiles)[0] That's why I believe that both are system-wide shared libraries. Note that there are plugin module .so files in /usr/lib64/lunar/ /usr/lib64/zzub/ > * License tag > - License tag is inherited to all subpackages unless explicitly > specified (try $ rpm -qi armstrong-devel or so. I think > this should just be "GPLv2+") > Changed the license tag of -devel and pyzzub packages to GPLv2+ > * internal libraries > -------------------------------------------------------------------------- > # Remove the binded libraries. We'll use the internal ones > -------------------------------------------------------------------------- > - You mean "external ones"? > I meant "internal Fedora libraries". I agree that there is some ambiguity in my usage. I made this a little more clear on the SPEC file below.. > * Document directories > -------------------------------------------------------------------------- > %doc installed_docs/* > %{_defaultdocdir}/zzub > -------------------------------------------------------------------------- > - With this armstrong will own two directories for documents, > %{_defaultdocdir}/{zzub,%{name}-%{version}}. I think > this is confusing and these directories should be unified. > - Also, anyway as this spec file has: > -------------------------------------------------------------------------- > # We want to install docs to the proper location: > mkdir -p installed_docs > mv $RPM_BUILD_ROOT%{_docdir}/zzub/* installed_docs/ > -------------------------------------------------------------------------- > Currently %_defaultdocdir/zzub is just empty. My bad. I changed the document directory structure when I was preparing the SPEC file. I forgot to remove the %_defaultdocdir/zzub entry. Now it's gone. Spec URL: http://oget.fedorapeople.org/review/armstrong.spec SRPM URL: http://oget.fedorapeople.org/review/armstrong-0.2.6-3.fc10.src.rpm Changelog: 0.2.6-3 - License for -devel and pyzzub packages is GPLv2+ - Clarify system-wide library usage - Fix sonames - Don't package the empty directory %%_defaultdocdir/zzub
Some more clarification: The unmodified tarball will install /usr/lib64/libzzub.so.0.3 /usr/lib64/libzzub.so.0 /usr/lib64/libzzub.so /usr/lib64/liblunarstd.so /usr/lib64/zzub/ /usr/lib64/lunar/ No libraries have any sonames. With my modification /usr/lib64/liblunarstd.so.0 will be installed in addition to the files and directories above. Also I put sonames on libraries /usr/lib64/libzzub.so.0 /usr/lib64/liblunarstd.so.0 The plugin module directories /usr/lib64/zzub/ /usr/lib64/lunar/ remain untouched.
Assigning to myself. I will try full review once the dependency rpms are imported.
Created attachment 334007 [details] Patch to compile ppc64 One thing: - Without the patch attached, this does not build on ppc64: http://koji.fedoraproject.org/koji/taskinfo?taskID=1217390
Other things are okay -------------------------------------------------------- This package (armstrong) is APPROVED by mtasaka --------------------------------------------------------
Thank you for the review. I merged the patch to the existing size_t patch. Here is the new koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1220706 I will now retire libzzub in F-10 and in devel. New Package CVS Request ======================= Package Name: armstrong Short Description: Powerful music sequencing library Owners: oget Branches: F-10 InitialCC:
Note that the directory src/rtaudio/include contains some microsoft proprietary code. I will remove this directory from the tarball that will go into the SRPM. Also, note that this rtaudio will not be compiled at all while building armstrong.
cvs done.
armstrong-0.2.6-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/armstrong-0.2.6-4.fc10
Imported and built for F-10 and devel.
armstrong-0.2.6-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.