SPEC: http://pbrobinson.fedorapeople.org/rygel.spec SRPM: http://pbrobinson.fedorapeople.org/rygel-0.2.2-1.fc10.src.rpm Rygel is an implementation of the UPnP MediaServer V 2.0 specification that is specifically designed for GNOME. It is based on GUPnP and is written (mostly) in Vala language. The project was previously known as gupnp-media-server.
Looks like it's missing some build dependencies: gupnp-vala GConf2-devel dbus-glib-devel e2fsprogs-devel The *.so files are presumably for internal use only? (thus, it's fine that ldconfig is not called)
SRPM: http://pbrobinson.fedorapeople.org/rygel-0.2.2-2.fc10.src.rpm Updated. Spec is same location. I thought I had added at least some of those! The .so files are internal plugins so are only for internal.
OK, will review. Would you care to do a swap, by the way? This should be small and quick to do: https://bugzilla.redhat.com/show_bug.cgi?id=487938 Thanks in advance!
rpmlint looks clean. For some reason, my F-10 machine is not generating debuginfo packages, so I'm getting warnings about unstripped binaries and libraries. Will test with Koji once gupnp-vala lands in Rawhide. Let's try and look the other issues before then. The log from running rygel is attached below. Looks like: DVB plugin: - Does not provide an icon, as expected. probably harmless, it's an early release after all - Some DBus problem? Tracker: - those isassassbasbii log messages are presumably debugging stuff, but I'm not sure where they're coming from (they do not appear in the source). Is there a way to verify that this package is functional? ** (rygel:28698): DEBUG: rygel-plugin-loader.vala:106: Loaded plugin: '/usr/lib64/rygel-1.0/librygel-dvb.so' ** (rygel:28698): DEBUG: rygel-media-server-factory.vala:293: No icon provided by DVB. ** (rygel:28698): CRITICAL **: rygel-dvb-root-container.vala:60: Failed to fetch device groups: The name org.gnome.DVB was not provided by any .service files ** (rygel:28698): DEBUG: rygel-plugin-loader.vala:106: Loaded plugin: '/usr/lib64/rygel-1.0/librygel-media-tracker.so' ** (rygel:28698): CRITICAL **: rygel-tracker-category.vala:104: error getting items under category 'Images': Method "Query" with signature "isassassbasbii" on interface "org.freedesktop.Tracker.Search" doesn't exist ** (rygel:28698): CRITICAL **: rygel-tracker-category.vala:104: error getting items under category 'Music': Method "Query" with signature "isassassbasbii" on interface "org.freedesktop.Tracker.Search" doesn't exist ** (rygel:28698): CRITICAL **: rygel-tracker-category.vala:104: error getting items under category 'Videos': Method "Query" with signature "isassassbasbii" on interface "org.freedesktop.Tracker.Search" doesn't exist
ping? it looks like Rawhide's gupnp-vala is older than F-10's (it's still not noarch). If you could rebuild an up-to-date version then we can get this review underway -- thanks.
I thought that the noarch feature was one that was introduced with F11/rawhide so when I pushed it the F10 I removed that option, other than that the package should be the same.
Any update on this review? It all builds fine in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=1285122
Ping. I'd like to get this into rawhide in time for F11 feature freeze :)
Ping.
Michel, Any update?
It has been one over one month. Peter, if you have not sent Michel direct mail yet, please do so. If you do not receive a response in a week's time, please re-assign this to me. I have strong interest in this package as I have DLNA hardware.
Email sent.
New SPEC/SRPM for a new upstream release SPEC: http://pbrobinson.fedorapeople.org/rygel.spec SRPM: http://pbrobinson.fedorapeople.org/rygel-0.3-1.fc11.src.rpm
koji build on F12 rawhide is here http://koji.fedoraproject.org/koji/taskinfo?taskID=1392690
Whoops, missed you assigning this to me. Was waiting on you to actually ping me. Will add this to my todo list now.
Would love to see this in Rawhide. Would make it much easier for me to test the new UPnP code in PulseAudio...
On F11, I see error: Failed build dependencies: vala-devel >= 0.7 is needed by rygel-0.3-1.fc11.src gupnp-vala >= 0.5.4 is needed by rygel-0.3-1.fc11.src I see there's a new version of vala in updates-testing, so grabbing that. Do you have a newer version of gupnp-vala available?
(In reply to comment #17) > On F11, I see > > error: Failed build dependencies: > vala-devel >= 0.7 is needed by rygel-0.3-1.fc11.src > gupnp-vala >= 0.5.4 is needed by rygel-0.3-1.fc11.src > > I see there's a new version of vala in updates-testing, so grabbing that. Do > you have a newer version of gupnp-vala available? Not yet as I'm waiting for it all to push out, haven't had a chance to get the new vala builds tagged into build override. The f12 built one will function just fine on F11 though.
Okay, grabbing it, but I just tagged the newer vala into override if you want to get the gupnp builds done.
rpmlint output as required by package review guidelines: rygel.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/rygel.schemas rygel-devel.x86_64: W: no-documentation MUST fix: N/A. Package meets all requirements in the MUST section of the Package Review guidelines as of Fri, Jun 5, 2009. SHOULD fix: Please use the most preferred buildroot tag per http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag Additional Suggestion: Please change your comment about the .la files. .la files are not static libraries, they are libtool archives.
Thanks Christopher, will fix up should and suggestions on commit. New Package CVS Request ======================= Package Name: rygel Short Description: A UPnP v2 Media Server Owners: pbrobinson Branches: F-11 F-10 InitialCC:
CVS done.
Imported into cvs. F-12 build as follows: http://koji.fedoraproject.org/koji/taskinfo?taskID=1395963 filed rel-eng ticket 1914 for gupnp-vala dep for F-11 build
Added to F11 as an update https://admin.fedoraproject.org/updates/rygel-0.3-1.fc11