Red Hat Bugzilla – Bug 488101
Review Request: django-contact-form - An extensible contact-form application for Django
Last modified: 2009-03-23 01:05:56 EDT
Spec URL: http://ivazquez.fedorapeople.org/packages/django-contact-form/django-contact-form.spec
SRPM URL: http://ivazquez.fedorapeople.org/packages/django-contact-form/django-contact-form-0.3-2.src.rpm
Description: An extensible contact-form application for Django
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1216155
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ egg file generated from source.
1) I will suggest to use
%doc CONTRIBUTORS.txt LICENSE.txt docs/*
will make not to create docs named directory
2) Change %define to %global
New Package CVS Request
Package Name: django-contact-form
Short Description: An extensible contact-form application for Django
Branches: F-9 F-10 EL-5
If this package is built for all requested branches then can we have this review closed now?