Spec URL: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi.spec SRPM URL: http://jzeleny.fedorapeople.org/packages/libhbaapi/libHBAAPI-2.2-2.fc10.src.rpm Description: Package contains HBA API library, used as a wrapper for other vendor specific libraries. Package will be used as a connector between FCoE Utilities and libhalinux.
formal review is here, see the notes below: BAD source files match upstream: BAD package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible. License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK* rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in -devel OK pkgconfig files in -devel OK no libtool .la droppings. OK not a GUI app. - full URLs for Sources are missing - the %name tag should be all in lowercase to be consistent with archive name (https://fedoraproject.org/wiki/Packaging/NamingGuidelines) - it's preferred to have the Requires for the devel sub-package on separate lines - rpmlint complains a bit: libHBAAPI-debuginfo.x86_64: W: invalid-license SNIA libHBAAPI-devel.x86_64: W: invalid-license SNIA libHBAAPI.src: W: invalid-license SNIA libHBAAPI.x86_64: W: invalid-license SNIA => SNIA license was recently added to the list of good licenses and is not yet known to rpmlint libHBAAPI.src: E: invalid-spec-name => package name and spec filename are not in sync libHBAAPI-devel.x86_64: W: no-documentation => can be ignored - you can apply the "includes" patch supplied by the hbaapi_build archive instead of using an own copy
Updated SPEC: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi.spec Updated SRPM: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi-2.2-3.fc10.src.rpm
- the hbaapi_build_2.2.tar.gz tarball differs between this package and upstream URL (length 674018 vs. 672470) - the %description for the main package could be more verbose
link to the thread about the SNIA license on fedora-legal mailing list - https://www.redhat.com/archives/fedora-legal-list/2009-February/msg00033.html
Updated SPEC: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi.spec Updated SRPM: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi-2.2-4.fc10.src.rpm I added one line to the description. It's not much, but hopefully it's enough for now.
All issues are fixed, this package is APPROVED.
New Package CVS Request ======================= Package Name: libhbaapi Short Description: Package contains HBA API library. It will be used as a connector between FCoE Utilities and libhbalinux. Owners: jzeleny Branches: InitialCC:
I used "SNIA HBAAPI library" as the Short Description as that seems more correct. cvs done.