Bug 489962 - Review request: libhbalinux - SNIA HBAAPI vendor library
Summary: Review request: libhbalinux - SNIA HBAAPI vendor library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dan Horák
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 489929
Blocks: 494549
TreeView+ depends on / blocked
 
Reported: 2009-03-12 17:34 UTC by Jan Zeleny
Modified: 2009-04-10 09:32 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 494549 494657 (view as bug list)
Environment:
Last Closed: 2009-04-10 09:32:03 UTC
Type: ---
Embargoed:
dan: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Jan Zeleny 2009-03-12 17:34:32 UTC
SRPM: http://jzeleny.fedorapeople.org/packages/libhalinux/libhbalinux-1.0.7-1.fc10.src.rpm
SPEC: http://jzeleny.fedorapeople.org/packages/libhalinux/libhbalinux.spec

This is HBAAPI vendor library to manage Fibre Channel Host Bus Adapters.
Review request for libHBAAPI: https://bugzilla.redhat.com/show_bug.cgi?id=489929

Comment 2 Dan Horák 2009-04-08 10:21:35 UTC
formal review is here, see the notes below:

OK	source files match upstream:
	    c6461663ae3ca88c3028ee9308add53764fab76b  libhbalinux-1.0.7.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	license field matches the actual license.
OK	license is open source-compatible (LGPLv2). License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (Rawhide/x86_64).
OK	debuginfo package looks complete.
OK*	rpmlint is silent.
OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	not a GUI app.

- IMO the ldconfig call is useless, because the library will be dlopened as a "plugin"
- rpmlint complains a bit
libhbalinux.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 44)
 => false positive
libhbalinux.x86_64: E: explicit-lib-dependency libhbaapi
 => the dependency is correct
libhbalinux.x86_64: W: dangerous-command-in-%postun mv
 => can be ignored
libhbalinux.x86_64: E: use-tmp-in-%postun
 => the copy could be created in /etc instead of /tmp

This package is APPROVED.

Comment 3 Jan Zeleny 2009-04-08 12:55:14 UTC
New Package CVS Request
=======================
Package Name: libhbalinux
Short Description: HBAAPI vendor library
Owners: jzeleny
Branches: 
InitialCC:

Comment 4 Kevin Fenzi 2009-04-09 21:08:52 UTC
cvs done.

Comment 5 Jan Zeleny 2009-04-10 09:32:03 UTC
Package has been built in rawhide, closing this bug.


Note You need to log in before you can comment on or make changes to this bug.