Bug 491550 - Review Request: libass - Portable library for SSA/ASS subtitles rendering
Summary: Review Request: libass - Portable library for SSA/ASS subtitles rendering
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-03-22 22:31 UTC by Martin Sourada
Modified: 2011-11-12 01:19 UTC (History)
2 users (show)

Fixed In Version: 0.9.6-2.fc9
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-03-28 20:34:24 UTC
dominik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Martin Sourada 2009-03-22 22:31:30 UTC
Spec URL: http://mso.fedorapeople.org/packages/SPECS/libass.spec
SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/libass-0.9.6-1.fc10.src.rpm
Description: Libass is a portable library for SSA/ASS subtitles rendering.

Comment 1 Dominik 'Rathann' Mierzejewski 2009-03-22 23:17:32 UTC
Taking review.

Quick comment: you don't need BR: glibc-devel. gcc requires it.

Comment 2 Dominik 'Rathann' Mierzejewski 2009-03-23 00:06:55 UTC
Full review:

rpmlint clean:
$ rpmlint /var/lib/mock//fedora-rawhide-x86_64/result
libass-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

source matches upstream:
$ md5sum libass-0.9.6.tar.bz2 libass-0.9.6.tar.bz2.orig 
58d9fa08eedc27edae05b53288025370  libass-0.9.6.tar.bz2
58d9fa08eedc27edae05b53288025370  libass-0.9.6.tar.bz2.orig

Builds fine in mock(devel/x86_64).

Just one small issue:
Redundant BuildRequires:
glibc-devel (required by gcc, which is in exceptions)
freetype-devel (required by fontconfig-devel)

Other than that it's fine.

This package is APPROVED.
(But please fix the redundant BRs upon import.)

I also encourage you to work with avidemux maintainer (in RPM Fusion) to unbundle its internal copy of libass.

Comment 3 Martin Sourada 2009-03-23 07:40:44 UTC
(In reply to comment #2)
> Full review:
> 
Thanks for the review.
> Just one small issue:
> Redundant BuildRequires:
> glibc-devel (required by gcc, which is in exceptions)
> freetype-devel (required by fontconfig-devel)
>
These two slipped my mind. Thanks for pointing it out.
 
> I also encourage you to work with avidemux maintainer (in RPM Fusion) to
> unbundle its internal copy of libass.  
Will do. IIRC mplayer also carries its iternal copy of libass.

Comment 4 Martin Sourada 2009-03-23 07:43:24 UTC
New Package CVS Request
=======================
Package Name: libass
Short Description: Portable library for SSA/ASS subtitles rendering
Owners: mso
Branches: F-9 F-10
InitialCC:

Comment 5 Kevin Fenzi 2009-03-24 17:30:00 UTC
cvs done.

Comment 6 Fedora Update System 2009-03-28 20:33:41 UTC
libass-0.9.6-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/libass-0.9.6-2.fc10

Comment 7 Fedora Update System 2009-03-28 20:35:20 UTC
libass-0.9.6-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/libass-0.9.6-2.fc9

Comment 8 Fedora Update System 2009-04-14 15:52:23 UTC
libass-0.9.6-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2009-04-14 15:55:45 UTC
libass-0.9.6-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Martin Sourada 2011-11-11 22:48:16 UTC
Package Change Request
======================
Package Name: libass
New Branches: el5 el6
Owners: mso
InitialCC:

Comment 11 Gwyn Ciesla 2011-11-12 01:19:34 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.