Red Hat Bugzilla – Bug 491550
Review Request: libass - Portable library for SSA/ASS subtitles rendering
Last modified: 2011-11-11 20:19:34 EST
Spec URL: http://mso.fedorapeople.org/packages/SPECS/libass.spec
SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/libass-0.9.6-1.fc10.src.rpm
Description: Libass is a portable library for SSA/ASS subtitles rendering.
Quick comment: you don't need BR: glibc-devel. gcc requires it.
$ rpmlint /var/lib/mock//fedora-rawhide-x86_64/result
libass-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 1 warnings.
source matches upstream:
$ md5sum libass-0.9.6.tar.bz2 libass-0.9.6.tar.bz2.orig
Builds fine in mock(devel/x86_64).
Just one small issue:
glibc-devel (required by gcc, which is in exceptions)
freetype-devel (required by fontconfig-devel)
Other than that it's fine.
This package is APPROVED.
(But please fix the redundant BRs upon import.)
I also encourage you to work with avidemux maintainer (in RPM Fusion) to unbundle its internal copy of libass.
(In reply to comment #2)
> Full review:
Thanks for the review.
> Just one small issue:
> Redundant BuildRequires:
> glibc-devel (required by gcc, which is in exceptions)
> freetype-devel (required by fontconfig-devel)
These two slipped my mind. Thanks for pointing it out.
> I also encourage you to work with avidemux maintainer (in RPM Fusion) to
> unbundle its internal copy of libass.
Will do. IIRC mplayer also carries its iternal copy of libass.
New Package CVS Request
Package Name: libass
Short Description: Portable library for SSA/ASS subtitles rendering
Branches: F-9 F-10
libass-0.9.6-2.fc10 has been submitted as an update for Fedora 10.
libass-0.9.6-2.fc9 has been submitted as an update for Fedora 9.
libass-0.9.6-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
libass-0.9.6-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request
Package Name: libass
New Branches: el5 el6
Git done (by process-git-requests).