Hide Forgot
Spec URL: http://sailer.fedorapeople.org/mingw32-libglademm24.spec SRPM URL: http://sailer.fedorapeople.org/mingw32-libglademm24-2.6.7-3.fc11.src.rpm Description: MinGW Windows C++ wrapper for the glade library. Approved MinGW packaging guidelines are here: http://fedoraproject.org/wiki/Packaging/MinGW
This package needs mingw32-gtkmm24 and mingw32-libglade2, neither of which are currently in Fedora. Because of that I am not sure if it is possible to do an official review right now.
Please note that we have mingw32-gtkmm24 and mingw32-libglade2 packaged already here: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/gtkmm24 http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/libglade2 Please submit them as separate Review Requests for Fedora.
Building the package fails: ../../scripts/depcomp: line 571: exec: i686-pc-mingw32-g++: not found make[2]: *** [generate_defs_libglade.o] Error 127 I suspect this is due to a missing BuildRequires on mingw32-gcc-c++. Also, configure complains about the --enable-docs flag: configure: WARNING: Unrecognized options: --enable-docs ./configure --help does not list this flag for this package.
Thanks! Update: Spec URL: http://sailer.fedorapeople.org/mingw32-libglademm24.spec SRPM URL: http://sailer.fedorapeople.org/mingw32-libglademm24-2.6.7-4.fc11.src.rpm
Fedora review mingw32-libglademm24-2.6.7-4.fc11.src.rpm 2008-04-19 * OK ! needs attention * rpmlint output Only expected Errors/Warnings from a mingw package * Package is named according to Fedora mingw packaging guidelines * Spec file is named as the package * Package follows the Fedora mingw packaging guidelines * The stated license (LGPLv2+) is a Fedora approved license * The stated license is the same as the one for the corresponding Fedora package * The package contains the license file (COPYING) * The spec file is written in legible English * Sources matches upstream f9ca5b67f6c551ea98790ab5f21c19d0 libglademm-2.6.7.tar.bz2 f9ca5b67f6c551ea98790ab5f21c19d0 SRPM/libglademm-2.6.7.tar.bz2 * According to guidelines the version should match the version of the corresponding Fedora package - which it does. * Package builds in mock (Fedora 10) ! The package contains documentation already present in the native Fedora package * BuildRequires look sane ! But is there a reason for having the "BuildArch: noarch" listed in the middle of the list of Thr BuildRequies? * Owns the directories it creates * No duplicate files * %files has %defattr * %clean clears %buildroot * Specfile uses macros consistently * Package does not own other's directories * %install clears %buildroot * Installed filenames are valid UTF8
Thanks! Removed docs and reordered BR/BA Spec URL: http://sailer.fedorapeople.org/mingw32-libglademm24.spec SRPM URL: http://sailer.fedorapeople.org/mingw32-libglademm24-2.6.7-5.fc11.src.rpm
Package approved.
Thanks! New Package CVS Request ======================= Package Name: mingw32-libglademm24 Short Description: MinGW Windows C++ wrapper for libglade Owners: sailer rjones Branches: F-10 F-11 InitialCC:
cvs done.
mingw32-libglademm24-2.6.7-6.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/mingw32-libglademm24-2.6.7-6.fc11
mingw32-libglademm24-2.6.7-6.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.