Hide Forgot
Spec URL: http://sailer.fedorapeople.org/mingw32-zfstream.spec SRPM URL: http://sailer.fedorapeople.org/mingw32-zfstream-20041202-3.fc11.src.rpm Description: MinGW Windows C++ abstraction library for compressed and non-compressed file I/O. Approved MinGW packaging guidelines are here: http://fedoraproject.org/wiki/Packaging/MinGW
Note: the review request for the native version of this library is still pending, see https://bugzilla.redhat.com/show_bug.cgi?id=438588
Update: Spec URL: http://sailer.fedorapeople.org/mingw32-zfstream.spec SRPM URL: http://sailer.fedorapeople.org/mingw32-zfstream-20041202-4.fc11.src.rpm Incorporate changes to native zfstream.
Let's take this for review. Looks good at first sight :)
- The package fails to compile due to a missing BR: mingw32-gcc-c++. After adding this, the package compiles fine - The patch contains a comment mentioning it has been sent upstream, but what does the patch actually fix?
(In reply to comment #4) > - The package fails to compile due to a missing BR: mingw32-gcc-c++. After > adding this, the package compiles fine Update: Spec URL: http://sailer.fedorapeople.org/mingw32-zfstream.spec SRPM URL: http://sailer.fedorapeople.org/mingw32-zfstream-20041202-5.fc11.src.rpm > - The patch contains a comment mentioning it has been sent upstream, but what > does the patch actually fix? The patch fixes the inability of zfstream to read/write zip files. Without the patch, it can only read/write .gz and .bz2 and uncompressed files.
There was a bug report from Hiroshi Kuno on zlib-devel mailing list at Feb 6, 2009: Please find it attached below, as well as response form Mark Adler. I would suggest looking at the bug, as it might propagate to zfstream; --------------------------------------- I found a bug in minizip, when i create a zip file on a FD. That lose a write error (i.e. disk full), and return ZIP_OK. Thus, the minizip make a broken zip file without a error. ** Where is bug. zipCloseFileInZipRaw() in src/contrib/minizip/zip.c 1067 if ((zi->ci.pos_in_buffered_data>0) && (err==ZIP_OK)) 1068 if (zipFlushWriteBuffer(zi)==ZIP_ERRNO) 1069 err = ZIP_ERRNO; /* 1. Here, setting ZIP_ERRNO to "err" */ 1070 1071 if ((zi->ci.method == Z_DEFLATED) && (!zi->ci.raw)) 1072 { 1073 err=deflateEnd(&zi->ci.stream); /* 2. BUG! overwriting defalteEnd()'s return-value(ZIP_OK) to "err" */ 1074 zi->ci.stream_initialised = 0; 1075 } 1076 ** How to fix. I have made a small patch that avoid to overwrite to "err", when "err" has a error code. Would you merge my patch? ndex: /zlib/branches/BUG-write-error/src/contrib/minizip/zip.c =================================================================== --- /zlib/branches/BUG-write-error/src/contrib/minizip/zip.c (revision 537) +++ /zlib/branches/BUG-write-error/src/contrib/minizip/zip.c (revision 566) @@ -1071,5 +1071,6 @@ if ((zi->ci.method == Z_DEFLATED) && (!zi->ci.raw)) { - err=deflateEnd(&zi->ci.stream); + int tmperr=deflateEnd(&zi->ci.stream); + if (err==ZIP_OK) err = tmperr; zi->ci.stream_initialised = 0; } -------------------------------------------- From: xxx (Mark Adler) Date: Thu, 5 Feb 2009 22:03:34 -0800 Subject: [Zlib-devel] Patch for losing a write error Hiroshi, Minizip is a contribution to zlib from Gilles Vollant. He is however on this list, so he may respond. Mark
(In reply to comment #6) > I would suggest looking at the bug, as it might propagate to zfstream; Thanks for the report. zfstream is fine however, as it does not include minizip (anymore), but links to minizip provided by the zlib and mingw32-zlib packages. So this bug needs to be fixed in zlib (mingw32-zlib), then zfstream is automatically fixed, as it links dynamically to the minizip DLL / shared lib. Have you reported the bug against zlib and mingw32-zlib?
No, not yet
$ rpmlint mingw32-zfstream.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw32-zfstream-20041202-5.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw32-zfstream-20041202-5.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Everything's okay, no further changes required ====================================================== The package mingw32-zfstream is APPROVED by epienbro ======================================================
Thank you for the review. New Package CVS Request ======================= Package Name: mingw32-zfstream Short Description: MinGW Windows C++ abstraction library for compressed and non-compressed file I/O Owners: sailer rjones Branches: F-10 F-11 InitialCC:
cvs done.
mingw32-zfstream-20041202-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/mingw32-zfstream-20041202-5.fc11
mingw32-zfstream-20041202-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.