Spec URL: http://oget.fedorapeople.org/review/lv2-zynadd-plugins.spec SRPM URL: http://oget.fedorapeople.org/review/lv2-zynadd-plugins-1-2.fc10.src.rpm Description: The zyn project main goal is to extract synth engines from ZynAddSubFX and pack them in LV2 plugin format. Resulting plugins are heavily based on work made by Nasca Octavian Paul. If you like the amazing sounds these plugins generate you should thank Paul for this. rpmlint is silent. The package is named lv2-zynadd-plugins for consistency with other plugins we have in Fedora, ladspa-xxx-plugins in particular.
Fedora review lv2-zynadd-plugins-1-2.fc10.src.rpm 2009-04-23 * OK ! Needs attention ? Needs clarification rpmlint output: lv2-zynadd-plugins.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 3) lv2-zynadd-plugins.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 3) 3 packages and 1 specfiles checked; 0 errors, 2 warnings. ! rpmlint warning is fixable (replace the space on line 12 with a tab) * Package is named according to guidelines * Specfile is named after the package * The package is licensed as GPLv2 which is a Fedora approved license * The license matches the license statements in the source * The license file in the sources (gpl.txt) is packaged as %doc * The spec file is written in legible English * The source matches upstream and is the latest version ead0a8db5440e480c8a23441195a76df zyn-1.tar.bz2 ead0a8db5440e480c8a23441195a76df SRPM/zyn-1.tar.bz2 * Package builds in mock (Fedora 10) ? BuildRequires on jack-audio-connection-kit-devel - is it needed? * No shared libraries in the default library path ! Neither the package nor any of its Requires own %{_libdir}/lv2 (the other two plugin packages have Requires: lv2core) * No duplicate files * Permissions are sane and %files has %defattr * %clean clear buildroot * Macros are used consistently * Contains code * %doc is not essential at runtime * Package does not own other's directories * %install clears buildroot * Installed filenames are valid UTF-8
In reply to comment #1) > Fedora review lv2-zynadd-plugins-1-2.fc10.src.rpm 2009-04-23 Thank you. > > ! rpmlint warning is fixable (replace the space on line 12 with a tab) > Fixed. I couldn't find any spaces in the line. Anyway, I removed all the whitespace and recreated the tabs, now there's no rpmlint. Weird. > ? BuildRequires on jack-audio-connection-kit-devel - is it needed? > I don't think so. No idea how it got there. Removed. > ! Neither the package nor any of its Requires own %{_libdir}/lv2 > (the other two plugin packages have Requires: lv2core) > My sloppiness. Added requires. Spec URL: http://oget.fedorapeople.org/review/lv2-zynadd-plugins.spec SRPM URL: http://oget.fedorapeople.org/review/lv2-zynadd-plugins-1-3.fc10.src.rpm
Package approved.
Thank you! New Package CVS Request ======================= Package Name: oget Short Description: LV2 port of the ZynAddSubFX engine Owners: oget Branches: F-10 F-11 InitialCC:
Oops I did it again. The correct request would be: New Package CVS Request ======================= Package Name: lv2-zynadd-plugins Short Description: LV2 port of the ZynAddSubFX engine Owners: oget Branches: F-10 F-11 InitialCC:
cvs done.
lv2-zynadd-plugins-1-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/lv2-zynadd-plugins-1-3.fc11
lv2-zynadd-plugins-1-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/lv2-zynadd-plugins-1-3.fc10
lv2-zynadd-plugins-1-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update lv2-zynadd-plugins'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-4081
lv2-zynadd-plugins-1-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update lv2-zynadd-plugins'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-4651
lv2-zynadd-plugins-1-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
lv2-zynadd-plugins-1-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.