Spec URL: http://git.binaryhelix.net/cgit/rpms/plain/trac-accountmanager-plugin/trac-accountmanager-plugin.spec?id=d5ca2fc49091fec96331f599a58e5587787b28f1 SRPM URL:http://fedorapeople.org/~arbiter/trac-accountmanager-plugin-0.2.1-1.20090406svn5484.fc11.src.rpm Description: The AccountManagerPlugin offers several features for managing user accounts: * allow users to register new accounts * login via an HTML form instead of using HTTP authentication * allow existing users to change their passwords or delete their accounts
Thanks for packaging this up. I've used this package to set up my own trac instance using mod_fcgid and it all seems to be working fine. I've documented the process here: http://www.city-fan.org/tips/TracWithFastCGIonFedora Anyway, I'll now return the favour by reviewing this package for you.
Review Guidelines ================= - rpmlint clean - package name is OK and is consistent with existing trac plugin packages in Fedora - spec file name consistent with package name - package meets guidelines - Beerware license is OK for Fedora - correct "Copyright only" License field used in spec - no detached license file to include - spec file written in English and is legible - source pulling instructions are missing "-r" option to set svn revision - sources from SRPM match sources from upstream VCS - package builds OK in mock for Fedora 10 (x86_64) - buildreqs fine - no locale data, libs, or devel files to worry about - not relocatable - directory ownership is fine - no duplicate entries in %files list - %defattr(...) and %clean present and correct - macro usage is consistent - code, not content - no large docs (in fact hardly any docs at all!) - docs don't affect runtime - not a GUI app, no .desktop file needed - %install section properly cleans buildroot - filenames all valid UTF-8 - no scriptlets needed - package appears to work as advertised - no subpackages used - no file dependencies Notes ===== Perhaps add comment that python-setuptools runtime dependency is needed for pkg_resources import? Please include contrib/sessionstore_convert.py as %doc (see http://www.mailinglistarchive.com/trac-users@googlegroups.com/msg03696.html) Please add -r $svnrel to svn export instructions
These could do with being fixed too, though that's probably more of an upstream issue: /usr/lib/python2.6/site-packages/acct_mgr/pwhash.py:13: DeprecationWarning: the md5 module is deprecated; use hashlib instead import md5, sha /usr/lib/python2.6/site-packages/acct_mgr/pwhash.py:13: DeprecationWarning: the sha module is deprecated; use the hashlib module instead import md5, sha
I stopped using trac and switched to another PMS, I have no more interest updating this package. You can take this package and get it reviewed if you want. I'm changing to CLOSED WONTFIX, feel free to re-open it if you are interested.
I've now made a new package submission in Bug #518046