Red Hat Bugzilla – Bug 494811
"migrating-" prefix is not removed from guest's name when migration or xm save fails
Last modified: 2014-02-02 17:37:00 EST
Description of problem:
When xm save or a migration of a guest fails, guest's name is not reset to its original name. Everything but xm list still shows the domain as migrating-*
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. create a PV guest
2. xm save guest /mnt/small/guest.save # so that it fails because of insufficient space
3. xentop; xenstore-ls
The guest is shown as migrating-* by xentop. The same name can be seen in xenstore.
The name of the guest should be reset to its original name without "migrating-" prefix.
Created attachment 358062 [details]
Fix to rename domain after failed save/migration
This is the patch to rename the domain after failed save/migration. It's necessary to have patch for BZ #513335 applied first.
Created attachment 390222 [details]
Patch for the latest codebase
this is the patch for our current codebase. Attached patch is patching mainly the forkHelper() method of XendCheckpoint.py script with option to pass dominfo object with domain information to it and if present and save is issued and failed, it restores the original guest name, i.e. it strips "migrating-" prefix from the guest's name.
It's been tested on x86_64 dom0 and for both 32-bit and 64-bit RHEL 5.3 HVM guests and 32-bit and 64-bit RHEL 5 PV guests. The HVM guest is not running after failed save but there is already a bug filed about that, BZ #486308 (HVM guest stops running when xm save fails). For PV guests the guest ends up in suspended state when save fails (which is the same behavior like before applying my patch).
This bug has been verified in xen-3.0.3-115.el5
The PV guest runs WELL and the guest returns to its original name after "xm save" failed.
But still 2 further problems:
1- this guest will turn into zombie when trying "xm shut" it, just as the same
situation as Bug 589123.
2- if the PV guest has an PCI device assigned, the guest name will still have the "migrating-" prefix as Bug 627095.
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.