Red Hat Bugzilla – Bug 495102
piranha removes slashes from monitoring script send commands
Last modified: 2009-09-02 07:58:31 EDT
Description of problem: When editing a virtual service, any slash entered in the Send box will be removed when written to the configuration. The default Send command contains slashes, so simply leaving it as-is and hitting Accept will result in HTTP/1.0rnrn as opposed to HTTP/1.0\r\n\r\n. This in turn results in nanny timing out waiting for the real server to respond, when it never will because it didn't receive the two carriage returns.
This is caused by the unnecessary stripslashes call in web/web/secure/virtual_edit_services.php:
$send = stripslashes($_GET['send']);
Version-Release number of selected component (if applicable): piranha-0.8.4-11.el5
How reproducible: Always
Steps to Reproduce:
1. Create a new virtual server or edit an existing one
2. Go to the Monitoring Scripts tab
3. Enter value (or leave defaults) of "GET / HTTP/1.0\r\n\r\n"
4. Hit Accept
Actual results: lvs.cf has 'send = "GET / HTTP/1.0rnrn"'
Expected results: lvs.cf has 'send = "GET / HTTP/1.0\r\n\r\n"'
Additional info: This issue was fixed in RHEL 4 by BZ 199243.
Created attachment 341428 [details]
Situation is slightly more complicated. Usage of stripslashes() is not useless when php is configured with 'magic_quotes_gpc = On'. Attached patch should work with both of the situations.
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.