Bug 496210
| Summary: | Review request: libpciaccess - abstraction layer for PCI access | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Jan Zeleny <jzeleny> |
| Component: | Package Review | Assignee: | Dan Horák <dhorak> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 5.4 | CC: | dhorak, jane.lv, jvillalo, lemenkov, luyu, notting, pm-rhel, rvokal, syeghiay |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-03 07:00:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 188273, 496211 | ||
|
Description
Jan Zeleny
2009-04-17 09:56:19 UTC
Fedora SPEC: http://jzeleny.fedorapeople.org/packages/libpciaccess/libpciaccess.spec Fedora SRPM: http://jzeleny.fedorapeople.org/packages/libpciaccess/libpciaccess-0.10.3-3.src.rpm formal review is here, see the notes below: OK source files match upstream: 16efde02c68a091f22d710c57f1d1f29ce41f60f libpciaccess-0.10.3.tar.bz2 OK package meets naming and versioning guidelines. OK* specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (MIT). License text included in package. BAD latest version is being packaged. BAD BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (EL5/x86_64). OK debuginfo package looks complete. BAD rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths, ldconfig is called OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in devel OK pkgconfig files in devel OK no libtool .la droppings. OK not a GUI app. - the support for packaging git snapshots could be removed - version 0.10.5 was released, Rawhide package contains one additional patch and is on 0.10.3-6 - libtool/automake/autoconf are required only for a snapshot - rpmlint complains a bit: libpciaccess.src: W: strange-permission make-libpciaccess-snapshot.sh 0755 libpciaccess-devel.x86_64: W: no-documentation => can be ignored libpciaccess.src: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 16) => should be fixed Please discuss the issues with Fedora maintainers. Updated SPEC: http://jzeleny.fedorapeople.org/packages/libpciaccess/libpciaccess.spec Updated SRPM: http://jzeleny.fedorapeople.org/packages/libpciaccess/libpciaccess-0.10.3-6.1.src.rpm Package has been just rebased in Fedora. Updated SRPM: http://jzeleny.fedorapeople.org/packages/libpciaccess/libpciaccess-0.10.5-1.1.src.rpm Updated SPEC: http://jzeleny.fedorapeople.org/packages/libpciaccess/libpciaccess.spec Source archive was updated both in Fedora and here and all remaining issues were fixed. This package is APPROVED. Dan, since you're the one, who made the review, then I suppose, that it's safe to assign this ticket to you :) Just to remove this ticket from queue of tickets, free to take them over Since the package has been accepted and released today, I'm closing this bug. |