Spec URL: http://mmaslano.fedorapeople.org/review/perl-Capture-Tiny.spec SRPM URL: http://mmaslano.fedorapeople.org/review/perl-Capture-Tiny-0.05-1.fc11.src.rpm Description: Capture::Tiny provides a simple, portable way to capture anything sent to STDOUT or STDERR, regardless of whether it comes from Perl, from XS code or from an external program. Optionally, output can be teed so that it is captured while being passed through to the original handles. Yes, it even works on Windows. Stop guessing which of a dozen capturing modules to use in any particular situation and just use this one. http://koji.fedoraproject.org/koji/taskinfo?taskID=1322307
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1322307 + rpmlint is silent for SRPM and for RPM. + source files match upstream url e242915f57878465ef0b947eaf2e0b5c Capture-Tiny-0.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=8, Tests=316, 2 wallclock secs ( 0.12 usr 0.01 sys + 1.65 cusr 0.47 csys = 2.25 CPU) + Package perl-Capture-Tiny-0.05-1.fc12.noarch => Provides: perl(Capture::Tiny) = 0.05 Requires: perl >= 0:5.006 perl(Exporter) perl(File::Spec) perl(File::Temp) perl(IO::Handle) perl(strict) perl(warnings) Suggestions: 1) Again you included BuildRequires: perl >= 0:5.006 Remove that. APPROVED.
New Package CVS Request ======================= Package Name: perl-Capture-Tiny Short Description: Capture stdin or stdout from Perl, XS or external programs Owners: mmaslano Branches: F-11 InitialCC: perl-sig
cvs done.
Package Change Request ====================== Package Name: perl-Capture-Tiny New Branches: el6 Owners: pradac InitialCC: perl-sig
Any comments from the Fedora maintainers?
(In reply to Jon Ciesla from comment #5) > Any comments from the Fedora maintainers? psabata is Fedora maintainer. I'm co-maintainer and I don't see any problem. pradac has request the branch for himself (bug #1051542). Maybe we should close those request as duplicates of Package Review bugs to make the statement traceable.
*** Bug 1051542 has been marked as a duplicate of this bug. ***
Git done (by process-git-requests).