Bug 497943 - RHELNET driver should filter packets going to the wrong MAC address
Summary: RHELNET driver should filter packets going to the wrong MAC address
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: xenpv-win
Version: 5.3
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Paolo Bonzini
QA Contact: Virtualization Bugs
URL:
Whiteboard:
: 526440 533324 (view as bug list)
Depends On: 532857
Blocks: 518435
TreeView+ depends on / blocked
 
Reported: 2009-04-28 01:55 UTC by koka xiong
Modified: 2010-11-22 23:18 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Several subtests of the Network Driver Interface Specification 6.5 (NDIStest) WHQL test used to fail.
Clone Of:
: 534085 (view as bug list)
Environment:
Last Closed: 2010-07-08 09:22:50 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
case1.log (364.63 KB, application/octet-stream)
2009-04-28 01:58 UTC, koka xiong
no flags Details
case2.log (364.92 KB, application/octet-stream)
2009-04-28 01:58 UTC, koka xiong
no flags Details
The failed log for NDIS Test 6.5 with win2008 R2 (591.29 KB, application/x-troff-man)
2009-11-09 08:33 UTC, Yewei Shao
no flags Details
Screen shot of halted guest. (40.66 KB, image/png)
2010-06-25 09:22 UTC, Xiaoli Tian
no flags Details
Failure log of NDIS6.5 for Win2k3_x86 (491.55 KB, application/octet-stream)
2010-06-28 02:59 UTC, Xiaoli Tian
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2010:0514 0 normal SHIPPED_LIVE xenpv-win bug fix update 2010-07-08 09:22:29 UTC

Description koka xiong 2009-04-28 01:55:45 UTC
Description of problem:
The win2003/32 fails NDIS test 6.5 of WHQL

Version-Release number of selected component (if applicable):
xen-pv win 1.0.0

How reproducible:
always

Steps to Reproduce:
case 1
1.Configure the LAN test machine.
Install win 2003/32 on the xen guest.
Install two redhat NIC on the virtual machine,their ip addresses
are:192.168.122.12 and 192.168.122.62--they work as support device and test
device-they use virbr0
Install one rel8139 NIC on the virtual machine,their ip address is
192.168.0.32-it work as message device-it use xenbr0
2.Configure another vm the same as step1 and on the same host.
3.Do NDIS test 6.5 of WHQL with WLK 1.2
4.The test failed NDIS 6.5 test,please see the attchament.
==============================================================
case 2
1.Configure the LAN test machine.
Install win 2003/32 on the xen guest.
Install two redhat NIC on the virtual machine,their ip addresses
are:192.168.122.12 and 192.168.122.62--they work as support device and test
device-they use virbr0
Install one redhat NIC on the virtual machine,their ip address is
192.168.0.32-it work as message device-it use xenbr0
2.Configure another vm the same as step1 and on the same host.
3.Do NDIS test 6.5 of WHQL with WLK 1.2
4.It fails.

case1 and case2 main difference is case1 has two redhat NIC and one rel8139
case 2 are all redhat NIC

Actual results:


Expected results:


Additional info:
Please the attachment for the case1 and case2 log.
You can download
http://download.microsoft.com/download/c/1/e/c1e7f386-cd6c-4e25-a249-986d30e736ad/DTMLogViewer.exe
 to look at the failed log.

Comment 1 koka xiong 2009-04-28 01:58:21 UTC
Created attachment 341499 [details]
case1.log

Comment 2 koka xiong 2009-04-28 01:58:53 UTC
Created attachment 341500 [details]
case2.log

Comment 3 ashok 2009-04-29 12:38:33 UTC
I tried manually following http://www.wd-3.com/archive/NDISTest.htm
and found one puzzleing thing, What ever NIC RTL or RHEL-PV you select
connectivity test gives error "less number of packets received"

Any suggestion?

Comment 4 koka xiong 2009-05-06 07:41:25 UTC
it is because of wrong configuration.
During testing,you must use two different kinds of network cards.
the test device and support device should be the same NIC.
the message device should be a different NIC,it should not be the same with test/support device.

Comment 5 ashok 2009-05-06 07:45:08 UTC
(In reply to comment #4)
> it is because of wrong configuration.
> During testing,you must use two different kinds of network cards.
> the test device and support device should be the same NIC.
> the message device should be a different NIC,it should not be the same with
> test/support device.  

Yes I did the same way,
used 1 rtl for test one for support and one for message. Then only i put a comment and need info.

Comment 6 ashok 2009-05-06 08:13:04 UTC
no it is not mandatory to use different kind. one can use same kind of NICs
but you need 3 NICs.

Comment 8 Paolo Bonzini 2009-11-04 10:48:49 UTC
How does this compare with bug 532857?  That one is a crash and this one is a failure?

Comment 9 Paolo Bonzini 2009-11-06 10:00:00 UTC
*** Bug 533324 has been marked as a duplicate of this bug. ***

Comment 10 Yewei Shao 2009-11-09 08:32:15 UTC
It still failed NDIS test 6.5 of WHQL for win2008 R2, and please see the failed log in the attachment, and you can use DTMLogViewer.exe program to see this log.

Comment 11 Yewei Shao 2009-11-09 08:33:04 UTC
Created attachment 368144 [details]
The failed log for NDIS Test 6.5 with win2008 R2

Comment 12 Yewei Shao 2009-11-09 08:33:46 UTC
Created attachment 368145 [details]
The DTMLogViewer program to see the failed log

Comment 13 Paolo Bonzini 2009-11-09 09:59:09 UTC
Here are the failed tests:

- Verify that Ndis Version supported by the adapter greater than or equal to Ndis Version 6.0
  >> For Logo purposes Gigabit speed or above Ethernet drivers should support Ndis Version greater than or equal to 6.0

- Verify that driver supports Scatter Gather DMA
  >> For logo purposes all drivers on Vista must support Scatter Gather DMA

- Verifying the setup configuration for product SKU VER_SUITE_DATACENTER or VER_SUITE_ENTERPRISE
  >> For running logo tests for devices VER_SUITE_DATACENTER and VER_SUITE_ENTERPRISE skus drivers should be capable of 64 bit addressing

- Check network addresses on the test adapter after modifying the registry with new network address
  >> Current network address did not change after driver was reloaded. The driver should have picked up a new network address from the registry.
  (This also causes "Testing that packets were sent from RedHat PV NIC Driver #2 to RedHat PV NIC Driver #3 and not received at OLD destination address 00-16-36-20-C0-14")

- Packet filter on Test Device Directed | Broadcast. 
 Address to test: Invalid Multicast Address: 01-02-03-04-05-00
  >> 0 packets expected but received 250 packets

- Packet filter on Test Device Multicast | Broadcast. 
 Address to test: Random Address: 00-01-02-04-08-0A
  >> 0 packets expected but received 250 packets

Comment 16 Paolo Bonzini 2010-03-19 18:29:31 UTC
The current address should be saved and restored to/from the registry.  I still have to implement this.

Comment 18 Paolo Bonzini 2010-03-23 15:51:12 UTC
git "master" passes addresschange and packetfilters tests with flying colors

Comment 19 Paolo Bonzini 2010-06-01 15:28:04 UTC
*** Bug 526440 has been marked as a duplicate of this bug. ***

Comment 22 Xiaoli Tian 2010-06-25 09:13:47 UTC
With xenpv-win-1.2.0-1,xen-3.0.3-105.el5_5.4.x86_64 and kernel 2.6.18-194.7.1.el5,
windows guest will get halted when WHQL testing script disabled its driver  which should have been enabled automatically.The screen shot of the halted guest will be attached.

Comment 23 Xiaoli Tian 2010-06-25 09:22:24 UTC
Created attachment 426809 [details]
Screen shot of halted guest.

Comment 25 Jaromir Hradilek 2010-06-25 11:36:59 UTC
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.

New Contents:
Several subtests of the Network Driver Interface Specification 6.5 (NDIStest) WHQL test used to fail.

Comment 26 Paolo Bonzini 2010-06-25 11:40:41 UTC
The required kernel patch is missing in that one.  Please use kernel-xen-2.6.18-204.el5, I'll make sure that the errata is blocked by the next z-stream update.

Comment 27 Xiaoli Tian 2010-06-28 02:58:10 UTC
(In reply to comment #26)
> The required kernel patch is missing in that one.  Please use
> kernel-xen-2.6.18-204.el5, I'll make sure that the errata is blocked by the
> next z-stream update.    

Have tested NDIS 6.5 With xenpv-win-1.2.0-1,xen-3.0.3-105.el5_5.4.x86_64 and kernel 2.6.18-204.el5,the bug still existed with failure log as follows or the attached wtl log:
----------------------------------------------------------
Title Result 

 Failed 

 Start Test 6/28/2010 10:36:43.795 AM Verifying the setup configuration for product SKU VER_SUITE_DATACENTER or VER_SUITE_ENTERPRISE 

Error 6/28/2010 10:36:43.795 AM For running logo tests for devices VER_SUITE_DATACENTER and VER_SUITE_ENTERPRISE skus should have atleast 4 processors 

File:    Line: 0 

Error Type:   WIN32 

Error Code:   0x50016 

Error Text:   The device does not recognize the command. 

Error 6/28/2010 10:36:43.795 AM For running logo tests for devices VER_SUITE_DATACENTER and VER_SUITE_ENTERPRISE skus drivers should use scatter gather DMA 

File:    Line: 0 

Error Type:   WIN32 

Error Code:   0x50018 

Error Text:   The program issued a command but the command length is incorrect. 

Warning 6/28/2010 10:36:43.795 AM For running logo tests for devices VER_SUITE_DATACENTER and VER_SUITE_ENTERPRISE skus drivers should be capable of 64 bit addressing 

File:    Line: 0 

End Test 6/28/2010 10:36:43.795 AM Verifying the setup configuration for product SKU VER_SUITE_DATACENTER or VER_SUITE_ENTERPRISE 

Result:   Fail 

Repro:   ndistest.exe /logo /auto /client /target:Miniport /tc:{748E76FD-CDE0-40E4-BAF0-60621C08968B} /TestEnvInfo:TestEnvInfo.xml /support:{4B85C80E-B0C5-4C4A-8C60-021635F75B13},{FF9127A7-D2DD-47F5-B101-4CE00C08FD26} /msg:{A38A0A23-4812-4588-A01D-5D9A371F5EB4} /jobgroup:WHQL\Lan /ParaVirtualizationDriver:True 

 

 Failed 

 Start Test 6/28/2010 10:37:08.795 AM Testing that packets were sent from RedHat PV NIC Driver #2 to RedHat PV NIC Driver and not received at OLD destination address 02-02-04-06-08-02 

Error 6/28/2010 10:37:08.795 AM Packets were received on Test adapter RedHat PV NIC Driver with the old address. No packets should be received at the old address. 

Test adapter is expected to receive 0 packets from Support adapter RedHat PV NIC Driver #2)

Please check that your hardware has been programmed with the correct network address. It may still be using the old address. 

File:    Line: 0 

Error Type:   WIN32 

Error Code:   0x50032 

Error Text:   The request is not supported. 

End Test 6/28/2010 10:37:08.795 AM Testing that packets were sent from RedHat PV NIC Driver #2 to RedHat PV NIC Driver and not received at OLD destination address 02-02-04-06-08-02 

Result:   Fail 

Repro:   ndistest.exe /logo /auto /client /target:Miniport /tc:{748E76FD-CDE0-40E4-BAF0-60621C08968B} /TestEnvInfo:TestEnvInfo.xml /support:{4B85C80E-B0C5-4C4A-8C60-021635F75B13},{FF9127A7-D2DD-47F5-B101-4CE00C08FD26} /msg:{A38A0A23-4812-4588-A01D-5D9A371F5EB4} /jobgroup:WHQL\Lan /ParaVirtualizationDriver:True
------------------------------------------------

Comment 28 Xiaoli Tian 2010-06-28 02:59:54 UTC
Created attachment 427296 [details]
Failure log of NDIS6.5 for Win2k3_x86

Comment 29 Paolo Bonzini 2010-06-29 12:08:00 UTC
> 
>  Failed 
> 
>  Start Test 6/28/2010 10:36:43.795 AM Verifying the setup configuration for
> product SKU VER_SUITE_DATACENTER or VER_SUITE_ENTERPRISE 
> 
> Error 6/28/2010 10:36:43.795 AM For running logo tests for devices
> VER_SUITE_DATACENTER and VER_SUITE_ENTERPRISE skus should have atleast 4
> processors 

This is a configuration problem on your side.  The guest needs 4 cpus.

> Error 6/28/2010 10:36:43.795 AM For running logo tests for devices
> VER_SUITE_DATACENTER and VER_SUITE_ENTERPRISE skus drivers should use scatter
> gather DMA 

This is bug 534085.

> Start Test 6/28/2010 10:37:08.795 AM Testing that packets were sent from
> RedHat PV NIC Driver #2 to RedHat PV NIC Driver and not received at OLD
> destination address 02-02-04-06-08-02 
> 
> Error 6/28/2010 10:37:08.795 AM Packets were received on Test adapter RedHat PV
> NIC Driver with the old address. No packets should be received at the old
> address. 

I cannot reproduce this.  Can you try with W2K8/64 please?  This bug mentions W2K3 because it's quite old, but most of our WHQL work is done with W2K8 currently.

Comment 30 Xiaoli Tian 2010-06-30 02:52:08 UTC
I have tried in Win2k8 x64 and x86,only bug 534085 still existed in both Win2k8 x86 & x64 ,there's no other failures.

Comment 32 Yewei Shao 2010-06-30 09:12:32 UTC
Change this bug to verified based on the comment #31.

Comment 34 errata-xmlrpc 2010-07-08 09:22:50 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2010-0514.html


Note You need to log in before you can comment on or make changes to this bug.