Spec URL: http://mmaslano.fedorapeople.org/review/perl-JavaScript-Minifier.spec SRPM URL: http://mmaslano.fedorapeople.org/review/perl-JavaScript-Minifier-1.05-1.fc11.src.rpm Description: This module removes unnecessary whitespace from JavaScript code. The primary requirement developing this module is to not break working code: if working JavaScript is in input then working JavaScript is output. It is ok if the input has missing semi-colons, snips like '++ +' or '12 .toString()', for example. Internet Explorer conditional comments are copied to the output but the code inside these comments will not be minified.
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1329655 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 14c1fa2fcf76c97de4d0fe0d8d7fc145 JavaScript-Minifier-1.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=17, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.04 cusr 0.00 csys = 0.07 CPU) + Package perl-JavaScript-Minifier-1.05-1.fc12.noarch => Provides: perl(JavaScript::Minifier) = 1.05 Requires: perl(Exporter) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-JavaScript-Minifier Short Description: Perl extension for minifying JavaScript code Owners: mmaslano Branches: F-11 InitialCC: perl-sig
CVS Done
Hi, Would you be ok to branch this package for EPEL ?
(In reply to comment #4) > Hi, > Would you be ok to branch this package for EPEL ? Fine with me. Could you maintain it for EPEL?
Sure. Do you want to co-maintain ?
(In reply to comment #6) > Sure. Do you want to co-maintain ? It's not necessary.
Package Change Request ====================== Package Name: perl-JavaScript-Minifier New Branches: el5 el6 Owners: xavierb
Git done (by process-git-requests).