Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://mmaslano.fedorapeople.org/review/perl-JavaScript-Minifier-XS.spec SRPM URL: http://mmaslano.fedorapeople.org/review/perl-JavaScript-Minifier-XS-0.05-1.fc11.src.rpm Description: JavaScript::Minifier::XS is a JavaScript "minifier"; its designed to remove un-necessary whitespace and comments from JavaScript files, which also not breaking the JavaScript.
Let me know when perl-JavaScript-Minifier is in rawhide :)
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=1335368
We need a br on Test::Pod; and the third word from the end of the second line of %description should probably be "without", not "which" :) The XS.so in the requires should be filtered, as it's a privat plugin library for Perl that isn't in the system lib paths. A construct like the following, inserted before %description, will do the trick. (see, e.g. perl-CSS-Minifier-XS) # don't "provide" private Perl libs %global _use_internal_dependency_generator 0 %global __deploop() while read FILE; do /usr/lib/rpm/rpmdeps -%{1} ${FILE}; done | /bin/sort -u %global __find_provides /bin/sh -c "%{__grep} -v '%{perl_vendorarch}/.*\\.so$' | %{__deploop P}" %global __find_requires /bin/sh -c "%{__deploop R}" Please add the BR and *.so filtering. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1335368 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 2f82abee406d893e3938eb29b32f80d7b2b5cd8d JavaScript-Minifier-XS-0.05.tar.gz 2f82abee406d893e3938eb29b32f80d7b2b5cd8d JavaScript-Minifier-XS-0.05.tar.gz.srpm Final provides / requires will be sane, once XS.so has been removed from the provides: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-JavaScript-Minifier-XS-0.05-1.fc12.ppc.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-JavaScript-Minifier-XS-0.05-1.fc12.ppc.rpm perl(JavaScript::Minifier::XS) = 0.05 perl-JavaScript-Minifier-XS = 0.05-1.fc12 perl-JavaScript-Minifier-XS(ppc-32) = 0.05-1.fc12 XS.so ====> requires for perl-JavaScript-Minifier-XS-0.05-1.fc12.ppc.rpm libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) perl >= 0:5.006 perl(DynaLoader) perl(Exporter) perl(:MODULE_COMPAT_5.10.0) perl(strict) perl(warnings) rtld(GNU_HASH) =====> perl-JavaScript-Minifier-XS-0.05-1.fc12.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-JavaScript-Minifier-XS-0.05-1.fc12.src.rpm ====> requires for perl-JavaScript-Minifier-XS-0.05-1.fc12.src.rpm perl(JavaScript::Minifier) perl(Module::Build) perl(Test::More) =====> perl-JavaScript-Minifier-XS-debuginfo-0.05-1.fc12.ppc.rpm <===== ====> rpmlint perl-JavaScript-Minifier-XS-debuginfo.ppc: E: description-line-too-long This package provides debug information for package perl-JavaScript-Minifier-XS. 1 packages and 0 specfiles checked; 1 errors, 0 warnings. ====> provides for perl-JavaScript-Minifier-XS-debuginfo-0.05-1.fc12.ppc.rpm perl-JavaScript-Minifier-XS-debuginfo = 0.05-1.fc12 perl-JavaScript-Minifier-XS-debuginfo(ppc-32) = 0.05-1.fc12 ====> requires for perl-JavaScript-Minifier-XS-debuginfo-0.05-1.fc12.ppc.rpm
There's still rpmlint message perl-JavaScript-Minifier-XS.x86_64: W: unstripped-binary-or-object /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/JavaScript/Minifier/XS/XS.so Could it be removed, or could I ignore it? http://mmaslano.fedorapeople.org/review/perl-JavaScript-Minifier-XS-0.05-2.fc11.src.rpm
ping?
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=1390386
Hmm, interesting. I'm not seeing the "unstripped" warning you described; and I'm not worried about the "description too long" in the debuginfo package... not much we could do about that anyways. :) With apologies for the extremely long delay. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1390386 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 2f82abee406d893e3938eb29b32f80d7b2b5cd8d JavaScript-Minifier-XS-0.05.tar.gz 2f82abee406d893e3938eb29b32f80d7b2b5cd8d JavaScript-Minifier-XS-0.05.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-JavaScript-Minifier-XS-0.05-2.fc12.ppc.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-JavaScript-Minifier-XS-0.05-2.fc12.ppc.rpm perl(JavaScript::Minifier::XS) = 0.05 perl-JavaScript-Minifier-XS = 0.05-2.fc12 perl-JavaScript-Minifier-XS(ppc-32) = 0.05-2.fc12 ====> requires for perl-JavaScript-Minifier-XS-0.05-2.fc12.ppc.rpm libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) perl >= 0:5.006 perl(DynaLoader) perl(Exporter) perl(:MODULE_COMPAT_5.10.0) perl(strict) perl(warnings) rtld(GNU_HASH) =====> perl-JavaScript-Minifier-XS-0.05-2.fc12.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-JavaScript-Minifier-XS-0.05-2.fc12.src.rpm ====> requires for perl-JavaScript-Minifier-XS-0.05-2.fc12.src.rpm perl(JavaScript::Minifier) perl(Module::Build) perl(Test::More) perl(Test::Pod) =====> perl-JavaScript-Minifier-XS-debuginfo-0.05-2.fc12.ppc.rpm <===== ====> rpmlint perl-JavaScript-Minifier-XS-debuginfo.ppc: E: description-line-too-long This package provides debug information for package perl-JavaScript-Minifier-XS. 1 packages and 0 specfiles checked; 1 errors, 0 warnings. ====> provides for perl-JavaScript-Minifier-XS-debuginfo-0.05-2.fc12.ppc.rpm perl-JavaScript-Minifier-XS-debuginfo = 0.05-2.fc12 perl-JavaScript-Minifier-XS-debuginfo(ppc-32) = 0.05-2.fc12 ====> requires for perl-JavaScript-Minifier-XS-debuginfo-0.05-2.fc12.ppc.rpm APPROVED
New Package CVS Request ======================= Package Name: perl-JavaScript-Minifier-XS Short Description: XS based JavaScript minifier Owners: mmaslano Branches: F-11 InitialCC: perl-sig
CVS done.