Bug 500254 - Pre-Review Request: jakarta-commons-jxpath - Simple XPath interpreter
Summary: Pre-Review Request: jakarta-commons-jxpath - Simple XPath interpreter
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Andrew Overholt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 429551
TreeView+ depends on / blocked
 
Reported: 2009-05-11 22:12 UTC by Fernando Nasser
Modified: 2009-08-20 13:54 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-08-20 13:54:15 UTC
Type: ---
Embargoed:
overholt: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Fernando Nasser 2009-05-11 22:12:35 UTC
Package needed for Maven 2.0.8

Spec URL: http://people.fedoraproject.org/~fnasser/jakarta-commons-jxpath.spec

SRPM URL: http://people.fedoraproject.org/~fnasser/jakarta-commons-jxpath-1.2-5.jpp6.src.rpm

Description: 
Defines a simple interpreter of an expression language called XPath.
JXPath applies  XPath  expressions to graphs of objects of all kinds:
JavaBeans, Maps, Servlet contexts, DOM etc, including mixtures thereof.

Comment 1 Andrew Overholt 2009-05-14 19:54:17 UTC
It would be nice to have a URL for source0.  I found it upstream regardless, matched the md5sum upstream to the one I downloaded and to the one in the SRPM.

I looked through a random sampling of 5 or so source files and they all say ASL 2.0 as does LICENSE.txt.  Therefore, the License field should reflect this.

There's a one line difference between the pom file included in the SRPM and the one from upstream (line 41):

-      <organization/>
+      <organization></organization>

Otherwise, pre-review checklist seems okay to me.

Comment 2 Fernando Nasser 2009-05-18 16:03:43 UTC
Fixed license.

Provided intructions for obtaining source and refresh source tar ball

Spec URL: http://people.fedoraproject.org/~fnasser/jakarta-commons-jxpath.spec

SRPM URL:
http://people.fedoraproject.org/~fnasser/jakarta-commons-jxpath-1.2-6.jpp6.src.rpm

Thanks a lot for the review and improvement suggestions.

Comment 3 Andrew Overholt 2009-05-19 13:08:11 UTC
I get a different SVN revision (776300) but there are no differences.  Approved.

Comment 4 Fernando Nasser 2009-05-20 20:41:24 UTC
New Package CVS Request
=======================
Package Name: jakarta-commons-jxpath
Short Description: Simple XPath interpreter
Owners: fnasser, dbhole
Branches: devel
InitialCC: jkeating

Comment 5 Kevin Fenzi 2009-05-21 23:49:58 UTC
cvs done.

Comment 6 Alexander Kurtakov 2009-08-20 13:54:15 UTC
Build in rawhide.
http://koji.fedoraproject.org/koji/buildinfo?buildID=128061


Note You need to log in before you can comment on or make changes to this bug.