Bug 500428 - Presto-related "internal system error"
Summary: Presto-related "internal system error"
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: PackageKit
Version: 11
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 503098 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-05-12 16:45 UTC by Michael Monreal
Modified: 2009-06-18 11:59 UTC (History)
13 users (show)

Fixed In Version: 0.4.8-1.fc11
Clone Of:
Environment:
Last Closed: 2009-06-18 11:59:34 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Michael Monreal 2009-05-12 16:45:38 UTC
Just got this while updating packages with PK updater:


Traceback (most recent call last):
  File "/usr/share/PackageKit/helpers/yum/yumBackend.py", line 1830, in _runYumTransaction
    rpmDisplay=rpmDisplay)
  File "/usr/lib/python2.6/site-packages/yum/__init__.py", line 3609, in processTransaction
    pkgs = self._downloadPackages(callback)
  File "/usr/lib/python2.6/site-packages/yum/__init__.py", line 3633, in _downloadPackages
    probs = self.downloadPkgs(dlpkgs)
  File "/usr/lib/python2.6/site-packages/yum/__init__.py", line 1313, in downloadPkgs
    self.plugins.run('predownload', pkglist=pkglist)
  File "/usr/lib/python2.6/site-packages/yum/plugins.py", line 180, in run
    func(conduitcls(self, self.base, conf, **kwargs))
  File "/usr/lib/yum-plugins/presto.py", line 577, in predownload_hook
    (problems, more) = downloadPkgs(conduit, pinfo, download_pkgs)
  File "/usr/lib/yum-plugins/presto.py", line 419, in downloadPkgs
    cb.start(text="<delta rebuild>", size=rebuild_size)
  File "/usr/lib/python2.6/site-packages/urlgrabber/progress.py", line 129, in start
    self._do_start(now)
  File "/usr/share/PackageKit/helpers/yum/yumBackend.py", line 2551, in _do_start
    self.updateProgress(name, 0.0, "", "")
  File "/usr/share/PackageKit/helpers/yum/yumBackend.py", line 2593, in updateProgress
    pkg = self._getPackage(name)
  File "/usr/share/PackageKit/helpers/yum/yumBackend.py", line 2534, in _getPackage
    sections = name.rsplit('-', 2)
AttributeError: 'NoneType' object has no attribute 'rsplit'

Comment 1 Michael Monreal 2009-05-12 16:51:37 UTC
I tried updating with the PK updater twice and it failed with the same message. After that I tried "yum upgrade", which worked fine.

Comment 2 James Antill 2009-05-12 17:16:40 UTC
This is an intereaction between PK and yum-presto using the download callback to give rebuild progress. I can work around it on the yum-presto end by adding a name, but it should really be fixed in PK too ... or at least Richard can let me know of a good format for the name.

Comment 3 James Antill 2009-05-12 17:18:38 UTC
 Try applying this to /usr/lib/yum-plugins/presto.py

diff --git a/yum-presto/presto.py b/yum-presto/presto.py
index 5977486..ff1a9d7 100644
--- a/yum-presto/presto.py
+++ b/yum-presto/presto.py
@@ -416,7 +416,8 @@ def downloadPkgs(conduit, presto, download_pkgs=None):
     ptsz, pfsz, pfnm = _processing_data()
     if cb and rebuild_size > (ptsz + pfsz):
         conduit.info(2, "Finishing rebuild of rpms, from deltarpms")
-        cb.start(text="<delta rebuild>", size=rebuild_size)
+        text = "<delta rebuild>"
+        cb.start(name=text, text=text, size=rebuild_size)
         sofar_sz = ptsz + pfsz
         cb.update(sofar_sz)
         while sofar_sz < rebuild_size and curthread.isAlive():

Comment 4 Michael Monreal 2009-05-12 17:25:28 UTC
(In reply to comment #3)
> Try applying this to /usr/lib/yum-plugins/presto.py

Well this was the fist time it failed so I don't know how often to expect an error like this in the future. I cannot test with the old selection of updates because I already applied them using yum in a terminal (mainly to see if yum was also affected)

Comment 5 James Antill 2009-05-12 18:25:31 UTC
 It will happened whenever you try to install an update that has a delta rpm. You can do a "yum downgrade" to get something that failed this morning, or just wait until tomorrow.

Comment 6 Richard Hughes 2009-05-13 08:04:28 UTC
Well, PK is expecting a package name from the cb, and "<delta rebuild>" isn't going to work. Can't you just return the package name of the package you're rebuilding in the name field? In the meantime, I've protected name against being NoneType in 29d1aa872fc553f5ba2e2ca9246c93123b3c029b upstream.

Comment 7 James Antill 2009-05-13 14:39:03 UTC
 Atm. we use one callback to do the rebuild, so there isn't a package name. In theory we could try moving to a model where we get a rebuild callback for each package ... but it'd be non-trivial due to the usage of threads (and some of the packages have been rebuilt, so we'd either have to fake callbacks for them ... or anything relying on the data would have to know they are done anyway).

 Does the patch in comment 3 help at all, or should I remove it?

Comment 8 Richard Hughes 2009-05-13 16:40:49 UTC
(In reply to comment #7)
>  Atm. we use one callback to do the rebuild, so there isn't a package name.

Ahh, right.

>  Does the patch in comment 3 help at all, or should I remove it?  

I would prefer if you didn't apply that patch, and we just fix PK to ignore it. Thanks.

Comment 9 Richard Hughes 2009-05-28 20:52:48 UTC
Can you try this build please: http://koji.fedoraproject.org/koji/taskinfo?taskID=1379550

Thanks.

Comment 10 Rex Dieter 2009-05-28 21:17:12 UTC
*** Bug 503098 has been marked as a duplicate of this bug. ***

Comment 11 Fedora Update System 2009-06-01 10:54:54 UTC
PackageKit-0.4.8-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/PackageKit-0.4.8-1.fc11

Comment 12 Fedora Update System 2009-06-02 14:25:32 UTC
PackageKit-0.4.8-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update PackageKit'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-5750

Comment 13 Norbert Fabritius 2009-06-03 23:30:11 UTC
Works now, thanks a lot!

Comment 14 Fedora Update System 2009-06-07 09:04:53 UTC
kpackagekit-0.4.1-3.fc11,PackageKit-0.4.8-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/kpackagekit-0.4.1-3.fc11,PackageKit-0.4.8-1.fc11

Comment 15 Bug Zapper 2009-06-09 15:41:56 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 16 Fedora Update System 2009-06-16 01:32:24 UTC
PackageKit-0.4.8-1.fc11, kpackagekit-0.4.1.1-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update PackageKit kpackagekit'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-6056

Comment 17 Fedora Update System 2009-06-18 11:59:10 UTC
PackageKit-0.4.8-1.fc11, kpackagekit-0.4.1.1-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.