Red Hat Bugzilla – Bug 500958
Review Request: perl-PAR-Packer - PAR Packager
Last modified: 2009-05-18 02:20:16 EDT
Spec URL: http://mmaslano.fedorapeople.org/review/perl-PAR-Packer.spec SRPM URL: http://mmaslano.fedorapeople.org/review/perl-PAR-Packer-0.991-1.fc11.src.rpm Description: This module implements the App::Packer::Backend interface, for generating stand-alone executables, perl scripts and PAR files. Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1355752
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1355752 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 2df43a4a76fc50b8d07bc3fea7b8f8465d4b444f PAR-Packer-0.991.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package perl-PAR-Packer-0.991-1.fc12.i586 => Provides: perl(App::Packer::PAR) = 0.91 perl(PAR::Filter) = 0.03 perl(PAR::Filter::Bleach) perl(PAR::Filter::Bytecode) perl(PAR::Filter::Obfuscate) perl(PAR::Filter::PatchContent) perl(PAR::Filter::PodStrip) perl(PAR::Packer) = 0.991 perl(PAR::StrippedPARL::Base) = 0.975 perl(PAR::StrippedPARL::Dynamic) = 0.958 perl(PAR::StrippedPARL::Static) = 0.958 perl(pp) = 0.977 Requires: /usr/bin/perl libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.2) libcrypt.so.1 libdl.so.2 libm.so.6 libnsl.so.1 libperl.so libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpthread.so.0(GLIBC_2.2) libresolv.so.2 libutil.so.1 perl >= 0:5.006 perl(App::Packer::PAR) perl(Archive::Zip) perl(Config) perl(Cwd) perl(ExtUtils::MakeMaker) perl(File::Basename) perl(File::Find) perl(File::Spec) perl(File::Temp) perl(FindBin) perl(Getopt::ArgvFile) perl(Getopt::Long) perl(Module::ScanDeps) perl(PAR) perl(PAR::Filter) perl(PAR::Packer) perl(Tk) perl(Tk::Balloon) perl(Tk::Dialog) perl(Tk::LabEntry) perl(base) perl(constant) perl(pp) perl(strict) perl(vars) perl(warnings) rtld(GNU_HASH) + Not a GUI application Should: 1) Seems you forgot to remove BuildRequires: perl >= 1:5.6.0 Remove this. APPROVED.
Wow, you are fast. Thank you. Useless BR was removed.
New Package CVS Request ======================= Package Name: perl-PAR-Packer Short Description: PAR Packager Owners: mmaslano Branches: F-11 InitialCC: perl-sig
cvs done.