Red Hat Bugzilla – Bug 500959
Review Request: perl-Task-Padre-Plugin-Deps - Task::Padre::Plugin::Deps Perl module
Last modified: 2010-03-31 08:59:39 EDT
Spec URL: http://mmaslano.fedorapeople.org/review/perl-Task-Padre-Plugin-Deps.spec
SRPM URL: http://mmaslano.fedorapeople.org/review/perl-Task-Padre-Plugin-Deps-0.12-1.fc11.src.rpm
Description: Simply plugins for Padre gui for Perl.
Build is not available because of missing BR.
Since the blockers are all closed, I tried building this again but it fails in rawhide due to lack of File::Spec >= 3.2701. I guess the core Perl package needs an update.
Please clear the whiteboard when this package becomes buildable.
One nit in %description "Simply" -> "Simple"
The build failed because of an unresolved symbol in Class/XSAccessor.so.
To fix that, I updated perl-AutoXS-Header to 1.02-1.fc12 and then rebuild
So an hour after now, when the repo catches the *XSAccessor-*-2.fc12 rpm, there is a chance that the reviewed rpm could build OK.
I'm in a hurry right now, could you please try to build the rpm yourself?
(If it still fails, then please accept my apology and return the "NotReady" to whiteboard.)
Wx::Perl::DataWalker .../usr/bin/perl: symbol lookup error: /usr/lib/perl5/vendor_perl/5.10.0/ppc-linux-thread-multi/auto/Wx/Wx.so: undefined symbol: Perl_Guse_safe_putenv_ptr
This could be (maybe) fixed with update of threads in perl core.
(In reply to comment #4)
> Wx::Perl::DataWalker .../usr/bin/perl: symbol lookup error:
> undefined symbol: Perl_Guse_safe_putenv_ptr
This is bug #508496.
(In reply to comment #0)
> Spec URL:
> SRPM URL:
not valid anymore
please provide current link.
Aha, I accidentally removed them as old. They are back and we have also passed koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=1741846
if this BR is not needed, remove it at all
- md5sum source ok
- tests ok
- rpmlint clean
- license ok
please fix specfile and BR.
BR weren't packaged and it should be partially working without them. If you insist on packaging also them, we can postpone this review again.
I can add BR now because it doesn't brake build
it doesn't break build just because dependencies are downloaded automagically directly from CPAN, and I'm not ok with that, when mentioned packages exists in fedora pkgdb.
Please add them into BR.
It is simply not permitted to download external content at build time; you don't even know that the builders have outside network access. Anything needed for the build must be installed, either as part of the default package set or as a consequence of a BuildRequires: line.
(In reply to comment #11)
> It is simply not permitted to download external content at build time; you
> don't even know that the builders have outside network access. Anything needed
> for the build must be installed, either as part of the default package set or
> as a consequence of a BuildRequires: line.
No, I don't know about automagicall cpan and that's the reason why I switched off automaticall installation by patch which is included in srpm </sarcasm>
(In reply to comment #10)
> it doesn't break build just because dependencies are downloaded automagically
> directly from CPAN, and I'm not ok with that, when mentioned packages exists in
> fedora pkgdb.
> Please add them into BR.
Ok, it looks like all BR are now in buildroot. I fixed all problems which you mentioned.
(In reply to comment #12)
> (In reply to comment #11)
> > It is simply not permitted to download external content at build time; you
> > don't even know that the builders have outside network access. Anything needed
> > for the build must be installed, either as part of the default package set or
> > as a consequence of a BuildRequires: line.
> No, I don't know about automagicall cpan and that's the reason why I switched
> off automaticall installation by patch which is included in srpm </sarcasm>
Which doesn't work.
When I'm building this in mock, it definitely downloads missing BR/requirements automatically.
You need to comment auto_install; to get rid of this behaviour.
Anyway auto_install is strongly discouraged. See CPAN page for Module::Install.
still same issue, patch is still the same as before.
Ok, now I really applied correct patch.
But still there are problems in requirements, you might find in build log lines like: Warning: prerequisite Acme::PlayCode 0 not found.
These ^ are problems of mentioned three packages, which I have to fix first.
Add some other requirements, but still there are some dependencies in parrot and rakudo.
Marcela, which dependencies do you have on your mind?
- Install experimental Padre plugin that runs on Parrot? ...missing.
- Install Padre plugin for Perl6?
- Install Experimental Padre plugin written in Perl 6? ...missing.
- Inline::Rakudo ...missing. (would need 0.02)
- Install Simple Catalyst helper interface for Padre? ...missing.
It's questionable if we need all of them.
In wishlist for this package you had perl-Audio-Beep, I have updated dependency with review request for it.
Great, one dependency solved.
Great, so it's not needed. Upstream told me, that it's not maintain now. We should wait until they started new releases.