Bug 501381 (389-console) - Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server
Summary: Review Request: 389-console - A Java based remote management console used for...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: 389-console
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jochen Schmitt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-05-18 20:36 UTC by Rich Megginson
Modified: 2014-11-10 20:17 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-06-18 21:12:04 UTC
Type: ---
Embargoed:
jochen: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Rich Megginson 2009-05-18 20:36:29 UTC
Spec URL: http://rmeggins.fedorapeople.org/pkgreview/389-console.spec
SRPM URL: http://rmeggins.fedorapeople.org/pkgreview/389-console-1.1.3-2.src.rpm
Description: A Java based remote management console used for managing 389
Administration Server and 389 Directory Server.

This is a rename of fedora-idm-console to 389-console.

Source URL: http://port389.org/sources/389-console-1.1.3.tar.bz2
md5sum 389-console-1.1.3.tar.bz2 
bbf9b8e74b9746d65b1fd1871a665208  389-console-1.1.3.tar.bz2
sha1sum 389-console-1.1.3.tar.bz2 
f220b8d5b1b1a737f0744f2eef1e07ed8b5aa460  389-console-1.1.3.tar.bz2

Compiles cleanly in mock
rpmlint /var/lib/mock/fedora-10-i386/result/*.rpm
389-console.i386: E: no-binary
- the only reason this is not a noarch package is because of the dependency on jss which has a specific arch
389-console-debuginfo.i386: E: empty-debuginfo-package
- this is a java package

Comment 1 Jochen Schmitt 2009-05-27 18:19:31 UTC
I have try to make a first look on this package. 

Unfortunately, I could found any java sources.

The wrapper script try to call a java class which I could found in this package.

It may nice, if you can give me a explaination.

Comment 2 Rich Megginson 2009-05-27 18:45:40 UTC
(In reply to comment #1)
> I have try to make a first look on this package. 
> 
> Unfortunately, I could found any java sources.
> 
> The wrapper script try to call a java class which I could found in this
> package.
> 
> It may nice, if you can give me a explaination.  

Yes.  The 389-console package just provides the "skin" or "flavor" for the console.  The console implementation package is idm-console-framework, which is a requirement.

Comment 3 Rich Megginson 2009-06-04 14:24:05 UTC
Any takers?  What can I do to help this along?

Comment 4 Jochen Schmitt 2009-06-04 16:43:18 UTC
Good:
+ Basename of the SPEC file matches with package name
+ Package name fullfill naming guidelines.
+ URL tag shows on proper project home page
+ Package contains valid license tag
+ License tag state GPLv2 as a valid OSS license
+ Package contains verbatin copy of the license text
+ Package contains proper Obsolete/Provides statement for renaming
+ Package contains no subpackages
+ Consistently usage of RPM macros
+ Proper definition of the BuildRoot
+ BuildRoot will be cleaned on beginning of %clean and %install
+ Could download upstream sources via spectool -g
+ Packaged sources matches with upstream
(md5sum: bbf9b8e74b9746d65b1fd1871a665208)
+ Local build works fine
+ Rpmlint is silent for source package
+ Scratch build on koji works fine.
* Files permissions are ok.
+ Java symlinks for jar files are created
+ All packaged files are owned by the package.
+ %doc stanza is small, so we don't need extra subpackage
+ Package contains proper %Changelog

Bad:
- Rpmlint complaints on binary rpm:
$ rpmlint -i 389-console-1.1.3-2.fc10.x86_64.rpm
389-console.x86_64: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.
- Debuginfo package is empty

I want to suggest, that you should recreate this package as a
noarch package.

Comment 5 Rich Megginson 2009-06-04 17:13:55 UTC
> I want to suggest, that you should recreate this package as a
> noarch package.

I would like to do that.  The problem is that the package has a dependency on jss which is not a noarch package.  How can I do that?

Comment 6 Jochen Schmitt 2009-06-04 17:21:50 UTC
This is only possible, if jss is available for all architectures.

If not, please take care, that no debuginfo package may be created, because it make no sense.

Comment 7 Jochen Schmitt 2009-06-04 17:24:10 UTC
I don't see any ExclusiveArch or ExcludeArch statements in jss, so creating of a noarch package is possible.

Comment 8 Rich Megginson 2009-06-04 17:32:03 UTC
I don't know if jss is available for all architectures.  jss itself depends on java, nspr, and nss.  If those are available, then jss should be available.

So if I create a noarch package, and I install 389-console on x86_64, how do I make sure 389-console uses jss.x86_64?

Comment 9 Jochen Schmitt 2009-06-04 17:40:39 UTC
Unfortunately, I'm not a java guru, so you make ask on the fedora-java-list about mulitlib behaviour of jni environments.

Comment 10 Rich Megginson 2009-06-17 15:23:29 UTC
ok - the fedora package will be noarch - verified that it works correctly on rawhide x86_64 - correctly pulls and uses jss.x86_64

Spec URL: http://rmeggins.fedorapeople.org/pkgreview/389-console.spec
SRPM URL:
http://rmeggins.fedorapeople.org/pkgreview/389-console-1.1.3-2.src.rpm
Description: A Java based remote management console used for managing 389
Administration Server and 389 Directory Server.

This is a rename of fedora-idm-console to 389-console.

Source URL: http://port389.org/sources/389-console-1.1.3.tar.bz2
md5sum 389-console-1.1.3.tar.bz2 
e9152a2e523a2890767a91cb338e2974  389-console-1.1.3.tar.bz2
sha1sum 389-console-1.1.3.tar.bz2 
73068de75b616d8d49ac570d23c007fec882bd89  389-console-1.1.3.tar.bz2

Comment 11 Jochen Schmitt 2009-06-18 16:11:42 UTC
OK, seems to build fine on koji, so you are APPROVED

Comment 12 Rich Megginson 2009-06-18 16:36:13 UTC
New Package CVS Request
=======================
Package Name: 389-console
Short Description: A Java based remote management console used for managing 389
Administration Server and 389 Directory Server.
Owners: rmeggins nkinder nhosoi
Branches: F-10 F-11

Comment 13 Jason Tibbitts 2009-06-18 20:29:00 UTC
I used a "short description" that's actually short.  Otherwise, CVS done.

Comment 14 Rich Megginson 2009-06-18 21:12:04 UTC
cvs import done - koji builds in rawhide - all branches committed

Comment 15 Michael Stahnke 2009-11-03 04:24:18 UTC
New Package CVS Request
=======================
Package Name: 389-console
Short Description: A Java based console used for managing 389
Administration Server and 389 Directory Server.
Owners: stahnma
Branches: EL4 EL5

Comment 16 Kevin Fenzi 2009-11-03 04:45:42 UTC
cvs done.

Comment 17 Rich Megginson 2014-11-10 19:12:13 UTC
Package Change Request
======================
Package Name: 389-console
New Branches: epel7
Owners: mreynolds nhosoi nkinder rmeggins

Comment 18 Gwyn Ciesla 2014-11-10 20:17:27 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.