Spec URL: http://rmeggins.fedorapeople.org/pkgreview/389-admin-console.spec SRPM URL: http://rmeggins.fedorapeople.org/pkgreview/389-admin-console-1.1.3-2.src.rpm Description: A Java based remote management console used for managing 389 Admin Server. The 389 Console is required to load and run these jar files. This is a rename of fedora-ds-admin-console to 389-admin-console. Source URL: http://port389.org/sources/389-admin-console-1.1.3.tar.bz2 md5sum 389-admin-console-1.1.3.tar.bz2 68a27a56334d4ab44b3b44a81f84d8a8 389-admin-console-1.1.3.tar.bz2 sha1sum 389-admin-console-1.1.3.tar.bz2 aa1d81fd2a8e2d70dfb2aa6e3df3f11e3cef29e7 389-admin-console-1.1.3.tar.bz2 Compiles cleanly in mock rpmlint /var/lib/mock/fedora-10-i386/result/*.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Any takers? What can I do to help this along?
ping
What can I do to speed up the package review process? I will not be able to release the 389 directory server suite without this package.
Good: + Basename of SPEC files matches with package name + URL tag shows to proper project home page + Package contains proper License tag + License tag states GPLv2 as a valid OSS license + Package contains verbatin copy of the license text + Could download upstream source with spectool -g + Providate/Obsoletes statement seems ok for renaming + Package contains no subpackages + Package source tar ball matches with upstream (md5sum: 68a27a56334d4ab44b3b44a81f84d8a8) + Proper BuildRoot definition + Local build works fine + Rpmlint is silent for Source rpm + Rpmlint is silent for binary rpm + Koji build works fine + Local install works fine. + %files stanza contains no duplicates + All files are owned by the package + %files contains no package which are belaongs to other packages + package contains proper %Changelog stanza Bad: - License tag states GPLv2 but the copyright state GPLv2+ as the license for the project. - Why you put the jar files into %{_datadir}/dirsrv/manual/html/java? - Because the manual seems to be very large, a separate doc subpackage make sense
(In reply to comment #5) > Bad: > - License tag states GPLv2 but the copyright state GPLv2+ > as the license for the project. Source files have been changed to use plain GPLv2. New version 1.1.4 Spec: http://rmeggins.fedorapeople.org/pkgreview/389-admin-console.spec SRPM: http://rmeggins.fedorapeople.org/pkgreview/389-admin-console-1.1.4-1.src.rpm Source: http://port389.org/sources/389-admin-console-1.1.4.tar.bz2 md5sum 389-admin-console-1.1.4.tar.bz2 55c661be949c27b9ff2f754abbc2607f 389-admin-console-1.1.4.tar.bz2 sha1sum 389-admin-console-1.1.4.tar.bz229a4ba674b4f532c67ed1303162e5b232bcf9821 389-admin-console-1.1.4.tar.bz2 > - Why you put the jar files into %{_datadir}/dirsrv/manual/html/java? The way the console works is that it dynamically downloads (and caches) the jar file corresponding to the server version you are managing. This allows you to use the console to manage older and compatible newer versions of directory server and admin server. The location %{_datadir}/dirsrv/manual/html/java is where the admin server looks for the jar files when a request is made to download them to the console machine. The files under %{_datadir}/dirsrv/manual/html/java are not used directly - they are downloaded to $HOME/.fedora-idm-console (or now $HOME/.389-console) where they are loaded into the console. > - Because the manual seems to be very large, a separate doc > subpackage make sense Done. See above.
Good: + Could download upstream tar ball with spectool -g + Package tar ball matches with upstream (md5sum: 55c661be949c27b9ff2f754abbc2607f) + License on the license tag matches with copyright notes of the source files + Local build works fine + Koji build works fine + Package contains several subpackage + Rpmlint is silent for source package + Rpmlint is silent for binary packages + Documentation is in a separate doc subpackage *** APPROVED ***
danke New Package CVS Request ======================= Package Name: 389-admin-console Short Description: 389 Admin Server Management Console Owners: rmeggins nkinder nhosoi Branches: F-10 F-11
CVS done.
imported into all branches - builds in koji
New Package CVS Request ======================= Package Name: 389-admin-console Short Description: 389 Admin Server Management Console Owners: stahnma Branches: EL4, EL5
cvs done.
Package Change Request ====================== Package Name: 389-admin-console New Branches: epel7 Owners: mreynolds nhosoi nkinder rmeggins
Git done (by process-git-requests).