Bug 504746 - (perl-Text-PDF) Review Request: perl-Text-PDF - Module for manipulating PDF files
Review Request: perl-Text-PDF - Module for manipulating PDF files
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
low Severity medium
: ---
: ---
Assigned To: Marcela Mašláňová
Fedora Extras Quality Assurance
Depends On:
Blocks: perl-PDF-Reuse
  Show dependency treegraph
Reported: 2009-06-09 03:09 EDT by Chris Weyl
Modified: 2009-06-10 02:11 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-06-10 02:11:52 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mmaslano: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Chris Weyl 2009-06-09 03:09:38 EDT
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Text-PDF.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Text-PDF-0.29a-1.fc10.src.rpm

This module allows interaction with existing PDF files directly. It
includes various tools:

    pdfbklt   - make booklets out of existing PDF files
    pdfrevert - remove edits from a PDF file
    pdfstamp  - stamp text on each page of a PDF file

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1400986

Comment 1 Marcela Mašláňová 2009-06-09 03:28:55 EDT
OK Rpmlint must be run on every package.
OK The package must be named according to the Package Naming Guidelines.
OK The spec file name must match the base package %{name}.
OK The package must meet the Packaging Guidelines.
OK The package must be licensed with a Fedora approved license.
OK The License field in the package spec file must match the actual license.
OK If (and only if) the source package includes the text of the license(s) in its own file.
OK The spec file must be written in American English.
OK The spec file for the package MUST be legible.
OK The sources used to build the package must match the upstream source.
OK The package MUST successfully compile.
OK Correct BuildRequires.
OK Proper use of %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
OK Shared library files (not just symlinks) must call ldconfig in %post and %postun.
OK Relocatable package must state this fact in the request for review.
OK A package must own all directories that it creates.
OK A package must not contain any duplicate files in the %files listing.
OK Permissions on files must be set properly.
OK Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK Each package must consistently use macros.
OK The package must contain code, or permissable content.
OK Large documentation files must go in a -doc subpackage.
OK If a package includes something as %doc, it must not affect the runtime of the application.
OK Header files must be in a -devel package.
OK Static libraries must be in a -static package.
OK Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'.
OK Library files with a suffix (e.g. libfoo.so.1.1) and files that end in .so (without suffix) must go in -devel.
OK In the vast majority of cases, devel packages must require the base package.
OK Packages must NOT contain any .la libtool archives.
OK Packages containing GUI applications must include a %{name}.desktop file.
OK At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
Comment 2 Marcela Mašláňová 2009-06-09 03:29:13 EDT
Comment 3 Chris Weyl 2009-06-09 03:31:22 EDT
New Package CVS Request
Package Name: perl-Text-PDF
Short Description: Module for manipulating PDF files
Owners: cweyl
Branches: F-10 F-11 devel
InitialCC: perl-sig
Comment 4 Kevin Fenzi 2009-06-10 00:44:37 EDT
cvs done.
Comment 5 Chris Weyl 2009-06-10 02:11:52 EDT
Thanks for the review! :-)

Note You need to log in before you can comment on or make changes to this bug.