Bug 505165 - Bad location *.desktop files
Summary: Bad location *.desktop files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: xfce4-panel
Version: 11
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: ---
Assignee: Christoph Wickert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-06-10 20:50 UTC by rvcsaba
Modified: 2009-06-24 19:18 UTC (History)
2 users (show)

Fixed In Version: 4.6.1-2.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-06-24 19:18:31 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Xfce 5455 0 None None None Never

Description rvcsaba 2009-06-10 20:50:13 UTC
Description of problem:

xfce4-datetime-plugin don't work, because datetime.desktop file in bad location.

rpm -q xfce4-datetime-plugin
xfce4-datetime-plugin-0.6.1-3.fc11.x86_64

rpm -q --filesbypkg xfce4-datetime-plugin | grep '\.desktop'
xfce4-datetime-plugin     /usr/lib64/xfce4/panel-plugins/datetime.desktop

I moved this file to /usr/share/xfce4/panel-plugins directory, and it work correctly.

Comment 1 Christoph Wickert 2009-06-10 22:11:20 UTC
(In reply to comment #0)
> Description of problem:
> 
> xfce4-datetime-plugin don't work, because datetime.desktop file in bad
> location.

No, this is on purpose. See bug # 505130 for details.

> I moved this file to /usr/share/xfce4/panel-plugins directory, and it work
> correctly.

I doubt this is the reason for datetime-plugin not working. The desktop file is only needed for the "Add panel items" dialog. Did the plugin show up there before you moved the file? Does it afterwards? What exactly do you mean by "does not work"? Is the path in the file correct?

Comment 2 rvcsaba 2009-06-10 22:39:50 UTC
OK, I drawn wrong. If datetime.desktop file in /usr/lib64/xfce4/panel-plugins, then missing it "Add panel items" dialog. If I moved this file to /usr/share/xfce4/panel-plugins directory, then I can add this plugin to panel.

<< Sorry, I don't speak english... :'( >>

Comment 3 Christoph Wickert 2009-06-10 23:28:06 UTC
No problem, I can't speak Hungarian ;) and my English is bad too, but I understand what you write.

Looks to me this is a problem of xfce4-panel. It should also search /usr/lib64/xfce4/panel-plugins. Can you please test if you have the same problem with xfce4-quicklauncher-plugin? I guess you have...

Kevin, I think we need the multilib patch back for the panel. You want me to take care of that?

Comment 4 rvcsaba 2009-06-11 00:49:42 UTC
Same problem, really. But quicklauncher.desktop file is buggy. I repaired this file. Diff:

27c27,28
< X-XFCE-Module=/usr/lib64/xfce4/panel-plugins/libquicklauncher.so
---
> X-XFCE-Module=quicklauncher
> X-XFCE-Module-Path=/usr/lib64/xfce4/panel-plugins

Comment 5 Kevin Fenzi 2009-06-11 02:18:21 UTC
Yeah, looks like panel needs to make sure and check the other directory as well. 
Feel free to take care of it, or if for any reason you would prefer, I would be happy to do it as well.

Comment 6 Christoph Wickert 2009-06-11 23:00:15 UTC
(In reply to comment #4)
> Same problem, really. But quicklauncher.desktop file is buggy. I repaired this
> file.

But that did not fix the problem, you had to move it to /usr/share/xfce4/panel-plugins, correct?

Please remove the files you moved/copied from /usr/lib64/... to /usr/share/... and try the package from
http://koji.fedoraproject.org/koji/taskinfo?taskID=1406236

Make sure to restart the panel after update. Does this fix your problem, so you see datetime and quicklauncher in the dialog?

Comment 7 rvcsaba 2009-06-12 09:02:56 UTC
>> Same problem, really. But quicklauncher.desktop file is buggy. I repaired
>> this file.
>
> But that did not fix the problem, you had to move it to
> /usr/share/xfce4/panel-plugins, correct?

No. I moved quicklauncher.desktop file to /usr/share/xfce4/panel-plugins directory, but quicklauncher missing from "Add panel items" dialog. I searched the bug, and found: see diff.

-------------

> Please remove the files you moved/copied from /usr/lib64/... to /usr/share/...
> and try the package from
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1406236

1. I removed 2 moved file:

/usr/share/xfce4/panel-plugins/datetime.desktop
/usr/share/xfce4/panel-plugins/quicklauncher.desktop

2. I reinstalled 2 packages, because let this two file into /usr/lib64/xfce4/panel-plugins directory, and let quicklauncher.desktop file is originally, not a repaired.

yum remove xfce4-datetime-plugin xfce4-quicklauncher-plugin
yum install xfce4-datetime-plugin xfce4-quicklauncher-plugin

3. I downloaded new rpm file from http://koji.fedoraproject.org/koji/getfile?taskID=1406236&name=xfce4-panel-4.6.1-2.fc11.x86_64.rpm, and I refreshed it:

rpm -Fhv xfce4-panel-4.6.1-2.fc11.x86_64.rpm

4. I restarted the Xfce session, I used "Add panel items" dialog. I seen datetime plugin, but I can't seen quicklauncher plugin.

5. I repaired the /usr/lib64/xfce4/panel-plugins/quicklauncher.desktop file. Changed X-XFCE-Module=/usr/lib64/xfce4/panel-plugins/libquicklauncher.so to X-XFCE-Module=quicklauncher, and add X-XFCE-Module-Path=/usr/lib64/xfce4/panel-plugins line. This fixed the problem.

Conclusion: the new xfce4-panel-4.6.1-2.fc11.x86_64.rpm package fixed the *.desktop path problem. Independently, quicklauncher.desktop file is buggy.

Comment 8 Christoph Wickert 2009-06-12 21:57:46 UTC
Indeed, quicklauncher.desktop uses the notation of an external plugin for an internal one. I'm going to address this later and move this bug to the panel. Fix is on the way.

Comment 9 Fedora Update System 2009-06-12 22:35:30 UTC
xfce4-panel-4.6.1-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/xfce4-panel-4.6.1-2.fc11

Comment 10 Christoph Wickert 2009-06-13 18:21:39 UTC
Gosh, affect's *all* internal plugins:

$ xfce4-panel 

(xfce4-panel:18945): xfce4-panel-WARNING **: Internal plugins need the "X-XFCE-Module-Path" entry to work properly.

(xfce4-panel:18945): xfce4-panel-WARNING **: Failed to create plugin "quicklauncher"

(xfce4-panel:18945): xfce4-panel-WARNING **: Internal plugins need the "X-XFCE-Module-Path" entry to work properly.

(xfce4-panel:18945): xfce4-panel-WARNING **: Failed to create plugin "websearch"

(xfce4-panel:18945): xfce4-panel-WARNING **: Internal plugins need the "X-XFCE-Module-Path" entry to work properly.

(xfce4-panel:18945): xfce4-panel-WARNING **: Failed to create plugin "smartbookmark"


I will have to look at this further. Hops I just need to rebuild them against the multilib'ed panel, otherwise I will have patch them manually.

Comment 11 Fedora Update System 2009-06-16 01:35:05 UTC
xfce4-panel-4.6.1-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update xfce4-panel'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-6083

Comment 12 Fedora Update System 2009-06-24 19:18:26 UTC
xfce4-panel-4.6.1-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.