Hide Forgot
SPEC: http://pbrobinson.fedorapeople.org/twitter-glib.spec SRPM: http://pbrobinson.fedorapeople.org/twitter-glib-0.9.8-1.fc11.src.rpm Twitter-GLib is a GObject-based library providing a wrapper around the RESTful API of Twitter.
MUST: twitter-glib.src: W: invalid-license LGPLv2.1+ Should be License: LGPLv2 Cosmetic: URL: http://live.gnome.org/TwitterGlib makes more sense I think. BuildRequires: gtk-doc is not really necessary , the tarball has that already built. The package has a testsuite that doesn't seem to do anything network related. You could add %check make check With the license change this package is APPROVED. I am not sure why this is a blocker for the rest review...
(In reply to comment #1) > MUST: > twitter-glib.src: W: invalid-license LGPLv2.1+ > Should be License: LGPLv2 I put that because from the README file: Twitter-GLib is released under the terms of the GNU Lesser General Public License version 2.1 or, at your option, any later version. > Cosmetic: > > URL: http://live.gnome.org/TwitterGlib > makes more sense I think. Will do, I never found that one previously :) > BuildRequires: gtk-doc > is not really necessary , the tarball has that already built. > > The package has a testsuite that doesn't seem to do anything network related. > You could add > %check > make check > > With the license change this package is APPROVED. > > I am not sure why this is a blocker for the rest review... It shouldn't have been, but I was looking at hundreds of deps/bz bugs etc yesterday so it was probably a brain fart.
(In reply to comment #2) > (In reply to comment #1) > > MUST: > > twitter-glib.src: W: invalid-license LGPLv2.1+ > > Should be License: LGPLv2 > > I put that because from the README file: > Twitter-GLib is released under the terms of the GNU Lesser General > Public License version 2.1 or, at your option, any later version. Oh, very sorry, I've missed the any later part. :/ According to the guidelines the short form of this to be used in spec files is: LGPLv2+
Thanks for the update. I've fixed it on my local copy ready for commit. Thanks for the review.
New Package CVS Request ======================= Package Name: twitter-glib Short Description: A library wrapping the Twitter RESTful API Owners: pbrobinson Branches: F-11 F-10 InitialCC:
CVS done.
Build in rawhide
Done. Thanks for the review!