Hide Forgot
SPEC: http://pbrobinson.fedorapeople.org/anerley.spec SRPM: http://pbrobinson.fedorapeople.org/anjal-0.1.0-1.20090624git0424e38.fc11.src.rpm An email client for netbooks which uses evolution-data-server as a backend
The Summary and %description seems wrong. (Btw I wouldn't put "which uses evolution-data-server as a backend" in there. Highlight what makes it special instead!)
I'll review it an update it but its a small light email client for netbooks :)
SRPM: http://pbrobinson.fedorapeople.org/anjal-0.1.0-2.20090624git0424e38.fc11.src.rpm Updated the description to: Anjal is a mail client for small screen devices like NetBooks. It features a nice multi-line message list, with text-preview of the latest messages in the thread. It supports a tab interface for folders, new mail and config. Being based on evolution it supports all the same mail backends including POP3, IMAP4, Exchange and GroupWare.
Updated to a new upstream git snapshot and added anerley as a blocker as its now required. SRPM: http://pbrobinson.fedorapeople.org/anjal-0.1.0-2.20090722gitcbb3f4c.fc11.src.rpm
Updated anjal snapshot including a spec cleanup. Also updated the release numbering to the Fedora pre release 0.x scheme. SPEC: as before SRPM: http://pbrobinson.fedorapeople.org/anjal-0.1.0-0.3.20090811git813fc0f.fc11.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1599410
- I believe configure will be run twice, once in the prep stage (through autogen.sh) and once in the build stage. The following autogen.sh command line should avoid this: # run autogen.sh until we have a proper release, but don't run configure twice. NOCONFIGURE=yes ./autogen.sh - I think the spec file should be using desktop-file-install instead of just validating the .desktop file. -desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop +desktop-file-install \ + --dir=%{buildroot}%{_datadir}/applications \ + %{buildroot}%{_datadir}/applications/%{name}.desktop - rpmlint complains: anjal.i686: W: incoherent-version-in-changelog 0.1.0-0.3 ['0.1.0-0.3.20090811git813fc0f.fc12', '0.1.0-0.3.20090811git813fc0f'] It seems to be confused by the "snapshot tag" in the release. Perhaps modify the %changelog entry to match?
(In reply to comment #6) > - I believe configure will be run twice, once in the prep stage (through > autogen.sh) and once in the build stage. You are correct. I'll look into it. > - I think the spec file should be using desktop-file-install instead of just > validating the .desktop file. > > -desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop > +desktop-file-install \ > + --dir=%{buildroot}%{_datadir}/applications \ > + %{buildroot}%{_datadir}/applications/%{name}.desktop desktop-file-validate is fine according to package guidelines. https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage > - rpmlint complains: > > anjal.i686: W: incoherent-version-in-changelog 0.1.0-0.3 > ['0.1.0-0.3.20090811git813fc0f.fc12', '0.1.0-0.3.20090811git813fc0f'] > > It seems to be confused by the "snapshot tag" in the release. Perhaps modify > the %changelog entry to match? Its fine, basically the 0.3 part of the version is enough and most packages leave off the full git tag.
Updated build with single configure. SRPMS: http://pbrobinson.fedorapeople.org/anjal-0.1.0-0.4.20090813git2d4e6a0.fc11.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1613275
Review: • rpmlint: source clean. binary has one warning: changelog incoherent anjal.x86_64: W: incoherent-version-in-changelog 0.1.0-0.3 ['0.1.0-0.4.20090813git2d4e6a0.fc12', '0.1.0-0.4.20090813git2d4e6a0'] 1 packages and 0 specfiles checked; 0 errors, 1 warnings. • package name: OK • spec file name: OK • package guideline-compliant: OK • license complies with guidelines: valid but bizarre (author does not trust FSF enough to use LGPLv2+ ?) • license field accurate: OK • license file not deleted: OK • spec in US English: OK • spec legible: OK • source matches upstream: OK • builds under >= 1 archs, others excluded: OK (Koji) • build dependencies complete: OK (Koji) • locales handled using %find_lang, no %{_datadir}/locale: OK • own all directories: OK • no dupes in %files: OK • permission: OK • %clean RPM_BUILD_ROOT: OK • macros used consistently: OK • Package contains code: OK • desktop file uses desktop-file-install: desktop-file-validate, OK • clean buildroot before install: OK • filenames UTF-8: OK SHOULD • package build in mock on all architectures: OK (Koji) • package functioned as described: OK (tested on x86_64) • scriplets are sane: OK • require package not files: OK
Approved -- make sure to fix the changelog entry when importing into the repository
Thanks! New Package CVS Request ======================= Package Name: anjal Short Description: An email client for small screen devices Owners: pbrobinson Branches: F-11 InitialCC:
CVS done.
imported and built.
and now pushed to rawhide. Thanks for the review!