Bug 508358 - ANTHY_HISTORY_FILE record only a single word
Summary: ANTHY_HISTORY_FILE record only a single word
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ibus-anthy
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Jens Petersen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 514112 518563 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-06-26 17:38 UTC by masanari iida
Modified: 2009-08-28 22:00 UTC (History)
7 users (show)

Fixed In Version: 1.1.0.20090814-1.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-08-28 22:00:57 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Bad sample anthy_history file (31 bytes, text/plain)
2009-06-26 17:46 UTC, masanari iida
no flags Details
Patch for engine/engine.py (878 bytes, patch)
2009-07-15 09:25 UTC, fujiwara
no flags Details | Diff

Description masanari iida 2009-06-26 17:38:37 UTC
Description of problem:
If one set ANTHY_HISTORY_FILE, anthy should record all inputs.
But currently anthy record only if I input a single word.


Version-Release number of selected component (if applicable):
anthy-9100h-4.fc11.i586

How reproducible:
Always


Steps to Reproduce:
1. Set following into .bash_profile.
   export ANTHY_HISTORY_FILE=~/.anthy_history
2. login to the account
3. Input Japanese words and convert.

3a.  Watashi no namae ha nakano desu.
     (My name is nakano)
3b.  nakano 

Actual results:
3a.  Nothing recorded into .anthy_history
3b.  A word nakano is recorded into .anthy_history

Expected results:
Both 3a and 3b cases should be recorded.

Additional info:
In order to record corpus when I input Japanese, this function should 
be work as expected.

Comment 1 masanari iida 2009-06-26 17:46:13 UTC
Created attachment 349589 [details]
Bad sample anthy_history file

Bad anthy_history file which record only single word convert result.
The file is EUC-JP.

Comment 2 Akira TAGOH 2009-06-30 02:19:58 UTC
Are you using ibus right?

Comment 3 masanari iida 2009-06-30 02:28:38 UTC
Yes.
Both ibus and anthy are from fedora 11 repo.

When I was using Fedora Core 5, I remember that ANTHY_HISTORY_FILE worked
with scim-anthy + anthy.
And when I am using RHEL5, ANTHY_HISTORY_FILE works with scim-anthy + anthy.

Comment 4 Akira TAGOH 2009-06-30 02:39:16 UTC
Right. it works with scim-anthy on even F-11. the problem is, ibus-anthy doesn't always calls anthy_commit_segment() when commit the preedit, where invokes anthy_save_history().

Reassigning to ibus-anthy.

Comment 5 masanari iida 2009-07-01 13:32:52 UTC
This symptom reproduce with following ibus 

$ rpm -qa |grep ibus-
ibus-m17n-1.1.0.20090211-5.fc11.i586
ibus-hangul-1.1.0.20090328-2.fc11.i586
ibus-chewing-1.0.10.20090523-2.fc11.i586
ibus-libs-1.1.0.20090612-1.fc11.i586
ibus-anthy-1.1.0.20090603-1.fc11.i586
ibus-1.1.0.20090612-1.fc11.i586
ibus-rawcode-1.0.0.20090303-3.fc11.i586
ibus-gtk-1.1.0.20090612-1.fc11.i586

Comment 6 fujiwara 2009-07-15 09:25:40 UTC
Created attachment 353801 [details]
Patch for engine/engine.py

Hmm.., I cannot enable $ANTHY_HISTORY_FILE with scim-anthy but I could see the problem with ibus-anthy in fedora 11.
I'm not sure if I tried it correctly.

anthy_commit_segment() sets seg->committed = c and commit_all_segment_p() checks all segments has the right seg->committed .

The suggested patch assigns each committed value.

Comment 7 masanari iida 2009-07-15 15:05:54 UTC
$ rpm -qf /usr/share/ibus-anthy/engine/engine.py
ibus-anthy-1.1.0.20090603-1.fc11.i586

I have modified /usr/share/ibus-anthy/engine/engine.py file,
and now ANTHY_HISTORY_FILE works as expected.

Thanks for the fix

Comment 8 masanari iida 2009-07-23 06:26:46 UTC
upstream also fix this bug.
http://github.com/phuang/ibus-anthy/commit/5f6fabc10d33a9bee0de43d851d20b6664b6ef8c

Comment 9 Peng Huang 2009-08-04 06:00:30 UTC
Fixed in ibus-1.2.0.20090804-1.fc12

Comment 10 Takanori MATSUURA 2009-08-04 12:18:45 UTC
*** Bug 514112 has been marked as a duplicate of this bug. ***

Comment 11 Fedora Update System 2009-08-14 06:01:36 UTC
ibus-anthy-1.1.0.20090814-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/ibus-anthy-1.1.0.20090814-1.fc11

Comment 12 Takanori MATSUURA 2009-08-14 06:29:53 UTC
(In reply to comment #11)
As far as I have tested, ibus-anthy-1.1.0.20090814-1.fc11 fixes this bug.


Thanks.

Comment 13 Fedora Update System 2009-08-15 08:23:25 UTC
ibus-anthy-1.1.0.20090814-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update ibus-anthy'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8610

Comment 14 fujiwara 2009-08-24 00:50:17 UTC
*** Bug 518563 has been marked as a duplicate of this bug. ***

Comment 15 Fedora Update System 2009-08-28 22:00:27 UTC
ibus-anthy-1.1.0.20090814-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.