Red Hat Bugzilla – Bug 508837
[PATCH] Use hashlib instead of deprecated module 'md5'
Last modified: 2009-09-15 15:32:29 EDT
+++ This bug was initially created as a clone of Bug #480945 +++
Description of problem:
The problem looks same as bz#475871.
Cheetah uses deprecated module 'md5' and thus DeprecationWarning warning message will be printed. Here is an example log:
foo@localhost% echo "from Cheetah import CacheRegion" | python - ~
/usr/lib/python2.6/site-packages/Cheetah/CacheRegion.py:30: DeprecationWarning: the md5 module is deprecated; use hashlib instead
Version-Release number of selected component (if applicable):
How reproducible: always if Cheetah.CacheRegion is imported
Steps to Reproduce:
try 'echo "from Cheetah import CacheRegion" | python -'
Actual results: See the log above.
Expected results: no warning message
--- Additional comment from email@example.com on 2009-01-21 09:25:12 EDT ---
Created an attachment (id=329608)
Patch to make use of hashlib instead of md5 module
It might depend on python >= 2.6.
--- Additional comment from firstname.lastname@example.org on 2009-01-21 09:51:16 EDT ---
This is really a change that would need to be made upstream. Also, in order to support older versions of python I think you'd have to fall back to md5 if hashlib isn't available. You probably want to post a patch to
--- Additional comment from email@example.com on 2009-01-26 13:46:53 EDT ---
(In reply to comment #2)
> This is really a change that would need to be made upstream. Also, in order to
> support older versions of python I think you'd have to fall back to md5 if
> hashlib isn't available. You probably want to post a patch to
Absolutely right. I just took second best :P
I posted an updated patch to that list. thanks for letting me know that list!
Also, I will attach that patch here for the record.
--- Additional comment from firstname.lastname@example.org on 2009-01-26 13:47:48 EDT ---
Created an attachment (id=330020)
Updated patch posted to the upstream mailing list
--- Additional comment from email@example.com on 2009-02-13 11:28:46 EDT ---
*** Bug 485445 has been marked as a duplicate of this bug. ***
--- Additional comment from firstname.lastname@example.org on 2009-03-19 01:18:10 EDT ---
"Cheetah Community Edition v2.1.0" looks including my fix.
--- Additional comment from email@example.com on 2009-06-09 06:49:01 EDT ---
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.
More information and reason for this action is here:
--- Additional comment from firstname.lastname@example.org on 2009-06-30 04:09:24 EDT ---
There are already builds for 2.2.1
This update (f11) has been submitted for stable
I guess this one could be closed. How about f10, it still appears to have 2.0.1.
I'm a little bit uncomfortable pushing this to F-10 at this point in the product lifecycle because it is a major version (in fact, 2 major versions) upgrade, with some significant changes under the covers. How comfortable are people that this won't break existing installations or dependent packages?
(In reply to comment #1)
> I'm a little bit uncomfortable pushing this to F-10
I suggest that discussion should take place in cloned bug 508837.
errr.... *this* is the bug :) damn those copy_all_comments scripts....
Fedora 11 still seems to have this problem. Can we get an update please?
An update is being pushed through F-11 to address this issue. I don't think pushing this update to F-10 at this point in the product lifecycle is appropriate, so I'm closing this bug WONTFIX.