Spec URL: http://fedorapeople.org/~cweyl/review/perl-String-RewritePrefix.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-String-RewritePrefix-0.004-1.fc11.src.rpm Description: Rewrite strings based on a set of known prefixes. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1447402 Additional Comment: This is a new requirement of the latest GA Catalyst::Runtime. *rt-0.10
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1447402 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 52d9801484932a77ff06a8f3b2f10e7292ca12ca String-RewritePrefix-0.004.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=2, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.02 cusr 0.00 csys = 0.05 CPU) + Package perl-String-RewritePrefix-0.004-1.fc12.noarch => Provides: perl(String::RewritePrefix) = 0.004 Requires: perl(Carp) perl(strict) perl(warnings) + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-String-RewritePrefix Short Description: Rewrite strings based on a set of known prefixes Owners: cweyl Branches: F-10 F-11 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)
Package Change Request ====================== Package Name: perl-String-RewritePrefix New Branches: el6 Owners: iarnell tremble InitialCC: perl-sig
Git done (by process-git-requests).