Red Hat Bugzilla – Bug 509178
Review Request: perl-namespace-autoclean - Keep imports out of your namespace
Last modified: 2010-08-25 13:29:00 EDT
Spec URL: http://fedorapeople.org/~cweyl/review/perl-namespace-autoclean.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-namespace-autoclean-0.08-1.fc11.src.rpm Description: When you import a function into a Perl package, it will naturally also be available as a method. The 'namespace::autoclean' pragma will remove all imported symbols at the end of the current package's compile cycle. Functions called in the package itself will still be bound by their name, but they won't show up as methods on your class or instances. This module is very similar to namespace::clean, except it will clean all imported functions, no matter if you imported them before or after you 'use'd the pagma. It will also not touch anything that looks like a method, according to 'Class::MOP::Class::get_method_list'. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1447435 Additional Comment: This is a new requirement of the latest GA Catalyst::Runtime. *rt-0.10
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1447435 + rpmlint is silent for SRPM and for RPM. + source files match upstream url e905b81a1a91c1ba98ce9c7a12d32b639536e185 namespace-autoclean-0.08.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=5, Tests=18, 1 wallclock secs ( 0.02 usr 0.03 sys + 0.24 cusr 0.08 csys = 0.37 CPU) + Package perl-namespace-autoclean-0.08-1.fc12.noarch => Provides: perl(namespace::autoclean) = 0.08 Requires: perl(B::Hooks::EndOfScope) perl(Class::MOP) perl(List::Util) perl(namespace::clean) perl(strict) perl(warnings) + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-namespace-autoclean Short Description: Keep imports out of your namespace Owners: cweyl Branches: F-10 F-11 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)
Package Change Request ====================== Package Name: perl-namespace-autoclean New Branches: el6 Owners: iarnell tremble InitialCC: perl-sig
Git done (by process-git-requests).