Spec URL: http://dev.laptop.org/~dsd/20090715/dracut-modules-olpc.spec SRPM URL: http://dev.laptop.org/~dsd/20090715/olpc-bootanim-2.7-1.fc11.src.rpm Description: This new package is a dracut module which implements OLPC-specific technologies, including our "versioned layout" filesystem and initramfs-level antitheft security. A couple more modules will be added in the near future. We'd like to include this in Fedora 11. rpmlint produces 2 bogus non-executable-script warnings -- in this case, the scripts are not meant to be executable until dracut puts them in the initramfs.
sorry, SRPM URL is http://dev.laptop.org/~dsd/20090715/dracut-modules-olpc-0.2.1-1.fc11.src.rpm
I'll take this one. Some initial comments. Source URL isn't correct. It should be: http://dev.laptop.org/~dsd/dracut-modules-olpc/dracut-modules-olpc-0.2.1.tar.bz2 or http://dev.laptop.org/~dsd/%{name}/%{name}-%{version}.tar.bz2 Build root isn't the usual one. Something like the following is suggested. BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) It also doesn't build in koji. I think it needs pyrex. http://koji.fedoraproject.org/koji/taskinfo?taskID=1477535
A full review. The only thing blocking is the build in koji and the few minor bits mentioned above. Another small one is you can use %{_datadir} instead of %{_prefix}/share/ in the files section. + rpmlint output rpmlint dracut-modules-olpc.spec dracut-modules-olpc-0.2.1-1.fc11.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm f57a07be5dfce912a7058be7ba6cec30 dracut-modules-olpc-0.2.1.tar.bz2 ? package successfully builds on at least one architecture tested using koji scratch build ? BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr n/a package owns all directories it creates n/a no duplicate files in %files + %defattr line + %clean contains rm -rf $RPM_BUILD_ROOT + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + %install must start with rm -rf %{buildroot} etc. + filenames must be valid UTF-8 Optional: n/a if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available ? reviewer should build the package in mock/koji ? the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin
Thanks, all fixed http://dev.laptop.org/~dsd/20090716/dracut-modules-olpc.spec http://dev.laptop.org/~dsd/20090716/dracut-modules-olpc-0.2.1-1.fc11.src.rpm
Looks good. APPROVED!
New Package CVS Request ======================= Package Name: dracut-modules-olpc Short Description: OLPC initramfs modules Owners: dsd pbrobinson cjb Branches: F-11 InitialCC:
CVS done.
dracut-modules-olpc-0.2.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/dracut-modules-olpc-0.2.1-1.fc11
thanks!
dracut-modules-olpc-0.2.1-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.