Red Hat Bugzilla – Bug 511922
Review Request: olpc-contents - OLPC contents manifest tools
Last modified: 2009-08-11 18:36:54 EDT
Spec URL: http://dev.laptop.org/~dsd/20090715/olpc-contents.spec SRPM URL: http://dev.laptop.org/~dsd/20090715/olpc-contents-2.6-1.fc11.src.rpm Description: This is a set of tools to create and verify manifests in OLPC's special "contents" format. They are used during OLPC build processes and on the client-side to check OS updates before installing them. Please consider for Fedora 11 inclusion.
I'll take this one.
Looks good to me. APPROVED! + rpmlint output rpmlint olpc-contents-2.6-1.fc11.src.rpm olpc-contents-2.6-1.fc12.x86_64.rpm olpc-contents.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm 91fae621f89a839e8bbb074a7f53316c olpc-contents-2.6.tar.bz2 + package successfully builds on at least one architecture tested using koji scratch build + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr n/a package owns all directories it creates n/a no duplicate files in %files + %defattr line + %clean contains rm -rf $RPM_BUILD_ROOT + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + %install must start with rm -rf %{buildroot} etc. + filenames must be valid UTF-8 Optional: + if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji n/a the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin
New Package CVS Request ======================= Package Name: olpc-contents Short Description: OLPC contents manifest tools Owners: dsd cjb pbrobinson Branches: F-11 InitialCC:
CVS done.
olpc-contents-2.6-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/olpc-contents-2.6-1.fc11
thanks
olpc-contents-2.6-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.