Spec URL: http://hicham.fedorapeople.org/MiniCopier.spec SRPM URL: http://hicham.fedorapeople.org/MiniCopier-0.4-1.fc11.src.rpm Description: MiniCopier is a graphical copy manager. It provides more comfort and control over files copy operations, than basic OS functions. Features * processing of the transfers one after the other * add new tranfers to the queue while a copy is already being processed * dynamic management of the queue of remaining transfers * pause a copy * skip current transfer to proceed to the next one * resume a copy at the exact point where it failed (no need to start over) * choose another name for the target if a file already exists * can follow or ignore symbolic links (Unix systems only) * set a default behaviour if target file already exists * storage of the failed transfers into a list rpmlint output : none koji build page: http://koji.fedoraproject.org/koji/taskinfo?taskID=1485750
BLOCKER: You need to package PgsLookAndFeel separately and make MiniCopier use the separate package. [No bundling of external libraries.] https://pgslookandfeel.dev.java.net/ - You have to comment your patches. - The patches are incorrectly named; their names have to begin with %{name}. - The package is noarch, so there's no need for %global debug_package %{nil} - The license is GPLv2+ not GPLv2. - Drop the line chmod 0644 %{SOURCE0} which serves no purpose. - If you make backups of the original files in patching with -b, use different suffixes for different patches. - I suggest using install -D -p -m 644 %{name}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar instead of mkdir -p $RPM_BUILD_ROOT%{_javadir} cp %{name}.jar lib/*.jar $RPM_BUILD_ROOT%{_javadir} and the same for the png file.
Updated the spec file. Spec URL: http://hicham.fedorapeople.org/MiniCopier.spec SRPM URL: http://hicham.fedorapeople.org/MiniCopier-0.4-2.fc11.src.rpm Description: MiniCopier is a graphical copy manager. It provides more comfort and control over files copy operations, than basic OS functions. Features * processing of the transfers one after the other * add new tranfers to the queue while a copy is already being processed * dynamic management of the queue of remaining transfers * pause a copy * skip current transfer to proceed to the next one * resume a copy at the exact point where it failed (no need to start over) * choose another name for the target if a file already exists * can follow or ignore symbolic links (Unix systems only) * set a default behaviour if target file already exists * storage of the failed transfers into a list rpmlint output : none This review request depends now on review request : https://bugzilla.redhat.com/show_bug.cgi?id=513119
- I suggest versioning the java BR and R as for the other packages. - Fix the .jar and .class clean operation, either find \( -name '*.jar' -o -name '*.class' \) -exec rm -f '{}' \; or find -name '*.jar' -exec rm -f '{}' \; find -name '*.class' -exec rm -f '{}' \; - This is silly (doesn't end up in the package anyway): chmod +x %{name}.sh drop it. Also use install -D -p -m 755 %{name}.sh %{buildroot}%{_bindir}/%{name} so you can drop the chmod line altogether. - Again, you are versioning the jars when upstream doesn't use versioned jars. You should drop the versioning altogether as it serves no purpose. - Don't use wildcards in %files when they're not needed, use %{_javadir}/%{name}.jar %{_javadir}/%{name}-%{version}.jar - Categories=Application is obsolete, drop it from the .desktop file. Drop GTK too. And remove the empty line at the top of the .desktop file. ** rpmlint output is clean. MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. OK - You could add -p to the javadoc cp section, but javadoc is anyway created from the sources. MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. N/A MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. N/A MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Desktop files are installed properly. OK MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK ** Fix the issues at the top of the comment and I'll approve.
updated spec : Spec URL: http://hicham.fedorapeople.org/MiniCopier.spec SRPM URL: http://hicham.fedorapeople.org/MiniCopier-0.4-3.fc11.src.rpm rpmlint output : none
OK, looks clean. APPROVED
New Package CVS Request ======================= Package Name: MiniCopier Short Description: Graphical copy manager Owners: hicham Branches: F-10 F-11 InitialCC: hicham
cvs done.
MiniCopier-0.4-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/MiniCopier-0.4-3.fc11
MiniCopier-0.4-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/MiniCopier-0.4-3.fc10
MiniCopier-0.4-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
MiniCopier-0.4-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.