Bug 513119 - Review Request: PgsLookAndFeel - Nice looking LookAndFeel for Swing
Summary: Review Request: PgsLookAndFeel - Nice looking LookAndFeel for Swing
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Susi Lehtola
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 516074
Blocks: 512627
TreeView+ depends on / blocked
 
Reported: 2009-07-22 03:03 UTC by Hicham HAOUARI
Modified: 2009-08-11 22:39 UTC (History)
3 users (show)

Fixed In Version: 1.1-4.20090805cvs.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-08-11 22:32:49 UTC
Type: ---
Embargoed:
susi.lehtola: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Hicham HAOUARI 2009-07-22 03:03:49 UTC
Spec URL: http://hicham.fedorapeople.org/PgsLookAndFeel.spec
SRPM URL: http://hicham.fedorapeople.org/PgsLookAndFeel-1.1-1.20090721cvs.fc11.src.rpm

Description: The PgsLookAndFeel is a nice looking LookAndFeel for Swing.
It aims be a very modern cross-platform LookAndFeel with
nice features and much interaction for users.

rpmlint output : none

Comment 1 Susi Lehtola 2009-07-22 07:31:08 UTC
- The BuildRoot is , use a newer one
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

- You have BR: laf-plugin twice. Should the other be Requires:?

- Preserve the time stamps of the sources with "install -p" and "cp -p".

Comment 2 Hicham HAOUARI 2009-07-22 10:08:23 UTC
Updated the spec file.

Spec URL: http://hicham.fedorapeople.org/PgsLookAndFeel.spec
SRPM URL:
http://hicham.fedorapeople.org/PgsLookAndFeel-1.1-2.20090721cvs.fc11.src.rpm

Description: The PgsLookAndFeel is a nice looking LookAndFeel for Swing.
It aims be a very modern cross-platform LookAndFeel with
nice features and much interaction for users.

rpmlint output : none

Comment 3 Hicham HAOUARI 2009-07-22 10:09:24 UTC
Updated the spec file.

Spec URL: http://hicham.fedorapeople.org/PgsLookAndFeel.spec
SRPM URL:
http://hicham.fedorapeople.org/PgsLookAndFeel-1.1-2.20090721cvs.fc11.src.rpm

Description: The PgsLookAndFeel is a nice looking LookAndFeel for Swing.
It aims be a very modern cross-platform LookAndFeel with
nice features and much interaction for users.

rpmlint output : none

Comment 4 Susi Lehtola 2009-07-22 11:40:37 UTC
- I suggest versioning the BR: and R: on java to >= 1:1.6.0 to make sure the project is built with openjdk, not gcj.

rpmlint output is clean.

MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK
MUST: The spec file for the package is legible and macros are used consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
- Upstream clearly has a preference and PgsLookAndFeel is clearer than pgslookandfeel.

MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the  Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license. OK
- Some files are BSD which should be compatible with ASL 2.0.

MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: A package must own all directories that it creates or require the package that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. N/A
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK

MUST: Java documentation must go in a -javadoc subpackage. NEEDSWORK
- Javadoc files must go into  %{_javadocdir}/%{name}.

MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK

SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. NEEDSWORK
- Ask upstream to put license and README in cvs.

SHOULD: The package builds in mock. OK

Comment 5 Susi Lehtola 2009-08-05 07:43:35 UTC
ping?

Comment 6 Hicham HAOUARI 2009-08-05 15:26:56 UTC
I have sent an email to upstream asking him to put license files in CVS, but I didn't get an answer till now.

I am gonna resend an email to him, and wait.

Comment 7 Susi Lehtola 2009-08-05 15:38:17 UTC
(In reply to comment #6)
> I have sent an email to upstream asking him to put license files in CVS, but I
> didn't get an answer till now.
> 
> I am gonna resend an email to him, and wait.  

That's a SHOULD, so the package can be approved once you have fixed the javadoc issue.

Comment 8 Hicham HAOUARI 2009-08-05 16:22:26 UTC
Updated the spec file.

Spec URL: http://hicham.fedorapeople.org/PgsLookAndFeel.spec
SRPM URL:
http://hicham.fedorapeople.org/PgsLookAndFeel-1.1-3.20090805cvs.fc11.src.rpm

Description: The PgsLookAndFeel is a nice looking LookAndFeel for Swing.
It aims be a very modern cross-platform LookAndFeel with
nice features and much interaction for users.

rpmlint output : none  

Koji build page :

http://koji.fedoraproject.org/koji/taskinfo?taskID=1584273

Comment 9 Susi Lehtola 2009-08-05 16:39:21 UTC
You might want to use a fully versioned dependency,
 Requires: %{name} = %{version}-%{release}

**

I'd change
 %{_javadir}/*
to
 %{_javadir}/%{name}*.jar

Actually,
 http://fedoraproject.org/wiki/Packaging/Java#Jar_file_naming
states that
 "If the package provides several JAR files, the filenames assigned by the build 
 must be used"
so I think you shouldn't add the version suffix to the jar files.

**

You need to run
 find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
in %prep to remove any pre-existing jar and class files.

Comment 10 Susi Lehtola 2009-08-05 16:48:52 UTC
(In reply to comment #9)
> You need to run
>  find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
> in %prep to remove any pre-existing jar and class files.  

Actually, there's something wrong with this command. Better to run
find -name '*.jar' -exec rm -f '{}' \;
find -name '*.class' -exec rm -f '{}' \;

This actually reveals there was one jar file that you didn't remove, belonging to the JIDE SWING suite.

It's probably the one at
https://jide-oss.dev.java.net/

Needless to mention, this must be packaged separately as well.

Comment 11 Hicham HAOUARI 2009-08-05 18:54:47 UTC
I think that jide-oss have a very restrictive license to be included in Fedora :

http://www.jidesoft.com/purchase/EULA.htm

Correct me if i am wrong.

Comment 12 Susi Lehtola 2009-08-05 20:03:51 UTC
It's dual licensed as per the link in comment #10. However, I am unable to get the project to build, 

   [javac]                   ^
    [javac] jide-oss/src/com/jidesoft/plaf/aqua/AquaJidePopupMenuUI.java:9: package apple.laf does not exist
    [javac] import apple.laf.AquaPopupMenuUI;
    [javac]                 ^
    [javac] jide-oss/src/com/jidesoft/plaf/aqua/AquaJidePopupMenuUI.java:15: cannot find symbol
    [javac] symbol: class AquaPopupMenuUI
    [javac] public class AquaJidePopupMenuUI extends AquaPopupMenuUI {
    [javac]                                          ^

Seems like it's trying to compile some MacOS/X extensions.

Comment 13 Hicham HAOUARI 2009-08-06 12:30:54 UTC
true, u either compile with the provided MacOS jar, or patch it so that we don't have to use the MacOS extensions during compilation.

but i am wondering if PgsLookAndFeel should depends on jide-oss as it provides a customized version of jide oss.

if we want to compile PgsLookAndFeel with the original jide-oss, we have to patch it so that it doesn't check for a valid license.

i am confused about what to do.

Comment 14 Susi Lehtola 2009-08-06 12:47:59 UTC
(In reply to comment #13)
> true, u either compile with the provided MacOS jar, or patch it so that we
> don't have to use the MacOS extensions during compilation.

All pre-existing jar files MUST be removed, so it just has to build without it.
 
> but i am wondering if PgsLookAndFeel should depends on jide-oss as it provides
> a customized version of jide oss.

You mean JIDE OSS is not the same thing PgsLookAndFeel depends on?

> if we want to compile PgsLookAndFeel with the original jide-oss, we have to
> patch it so that it doesn't check for a valid license.
> 
> i am confused about what to do. 

What do you mean by checking for a valid license..?

Comment 15 Hicham HAOUARI 2009-08-06 13:06:10 UTC
if we try to build PgsLookAndFeel against jide-oss jar, we get an error message :

[javac] Compiling 49 source files to /home/hicham/rpmbuild/BUILD/pgslookandfeel/classes
    [javac] /home/hicham/rpmbuild/BUILD/pgslookandfeel/src/com/pagosoft/plaf/PlafOptions.java:258: cannot find symbol
    [javac] symbol  : class Lm
    [javac] location: package com.jidesoft.utils
    [javac] 		com.jidesoft.utils.Lm.verifyLicense("Patrick Gotthardt", "PgsLookAndFeel", "aW6dEcgCQMkW4e:OGYJCDdPATGYEiLo2");

That is what I meant by checking for a valid license. So the provided jar is not the same as the jide-oss jar, maybe it uses a different license.

By removing that line, the code compile fine against jide-oss.

What do u think I should do, patch PgsLookAndFeel to use the jide-oss jar?

Comment 16 Susi Lehtola 2009-08-06 13:31:44 UTC
(In reply to comment #15)
> if we try to build PgsLookAndFeel against jide-oss jar, we get an error message
> :
> 
> [javac] Compiling 49 source files to
> /home/hicham/rpmbuild/BUILD/pgslookandfeel/classes
>     [javac]
> /home/hicham/rpmbuild/BUILD/pgslookandfeel/src/com/pagosoft/plaf/PlafOptions.java:258:
> cannot find symbol
>     [javac] symbol  : class Lm
>     [javac] location: package com.jidesoft.utils
>     [javac]   com.jidesoft.utils.Lm.verifyLicense("Patrick Gotthardt",
> "PgsLookAndFeel", "aW6dEcgCQMkW4e:OGYJCDdPATGYEiLo2");
> 
> That is what I meant by checking for a valid license. So the provided jar is
> not the same as the jide-oss jar, maybe it uses a different license.
> 
> By removing that line, the code compile fine against jide-oss.
> 
> What do u think I should do, patch PgsLookAndFeel to use the jide-oss jar?  

Yes, if it works.

However, jide-oss must be built from source as well, and currently I don't know how to do it since it includes a binary jar file from MacOS X that must be somehow replaced.

Comment 17 Hicham HAOUARI 2009-08-06 13:49:41 UTC
no problem in building jide-oss from source, I replaced the MacOS extensions with standard ones, and the code compiled fine. So is it OK to start a package review for jide-oss ?

Comment 18 Susi Lehtola 2009-08-06 13:57:51 UTC
(In reply to comment #17)
> no problem in building jide-oss from source, I replaced the MacOS extensions
> with standard ones, and the code compiled fine. So is it OK to start a package
> review for jide-oss ?  

Oh OK. Yes, please submit it for review.

Comment 19 Hicham HAOUARI 2009-08-06 15:53:39 UTC
jide-oss have been submitted for review :

https://bugzilla.redhat.com/show_bug.cgi?id=516074

Comment 20 Susi Lehtola 2009-08-06 18:49:34 UTC
ok, so now you can update this package to use jide-oss, and after that update MiniCopier to use this package (if you didn't do so already).

Comment 21 Hicham HAOUARI 2009-08-07 15:37:07 UTC
updated spec file

Spec URL: http://hicham.fedorapeople.org/PgsLookAndFeel.spec
SRPM URL:
http://hicham.fedorapeople.org/PgsLookAndFeel-1.1-4.20090805cvs.fc11.src.rpm

Description: The PgsLookAndFeel is a nice looking LookAndFeel for Swing.
It aims be a very modern cross-platform LookAndFeel with
nice features and much interaction for users.

rpmlint output : none

Comment 22 Susi Lehtola 2009-08-07 16:06:45 UTC
- You are missing Requires: jide-oss.

- Javadoc stuff has been fixed.

- I'd drop the versioning since at least in this case it isn't done by upstream, as you
 install -D -p -m 644 jar/%{name}.jar \
	%{buildroot}%{_javadir}/%{name}-%{version}.jar
 install -D -p -m 644 jar/%{name}-jide.jar \
	%{buildroot}%{_javadir}/%{name}-jide-%{version}.jar

- Change
 %{_javadir}/*
to
 %{_javadir}/PgsLookAndFeel-jide.jar
 %{_javadir}/PgsLookAndFeel.jar
as it avoids the unnecessary wildcard which is troublesome e.g. when files are missing.


With these notes the package is

APPROVED

please fix the issues before CVS import.

Comment 23 Hicham HAOUARI 2009-08-07 16:38:27 UTC
updated the spec file
Spec URL: http://hicham.fedorapeople.org/PgsLookAndFeel.spec

Comment 24 Susi Lehtola 2009-08-07 18:03:57 UTC
yes yes, you can request the cvs branch, I've approved the package already.

Comment 25 Hicham HAOUARI 2009-08-07 18:12:51 UTC
New Package CVS Request
=======================
Package Name: PgsLookAndFeel
Short Description: Nice looking LookAndFeel for Swing
Owners: hicham
Branches: F-10 F-11
InitialCC: hicham

Comment 26 Kevin Fenzi 2009-08-10 05:34:55 UTC
cvs done.

Comment 27 Fedora Update System 2009-08-11 03:32:09 UTC
PgsLookAndFeel-1.1-4.20090805cvs.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/PgsLookAndFeel-1.1-4.20090805cvs.fc11

Comment 28 Fedora Update System 2009-08-11 03:33:21 UTC
PgsLookAndFeel-1.1-4.20090805cvs.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/PgsLookAndFeel-1.1-4.20090805cvs.fc10

Comment 29 Fedora Update System 2009-08-11 22:32:44 UTC
PgsLookAndFeel-1.1-4.20090805cvs.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 30 Fedora Update System 2009-08-11 22:39:15 UTC
PgsLookAndFeel-1.1-4.20090805cvs.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.