Spec URL: http://kwizart.fedorapeople.org/review/perl-Async-MergePoint.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-Async-MergePoint-0.03-1.fc11.src.rpm Description: Resynchronise diverged control flow
OK rpmlint on every package. OK name of package accords to the Naming Guidelines. OK spec file name match the base package %{name}. OK package meet the Packaging Guidelines. OK package has a good license. OK spec file is written in American English. OK spec file for the package must be legible. OK The sources used to build the package must match the upstream source. f4a6f9a9dc0a1748f503c01893d544cc OK successful koji compilation. http://koji.fedoraproject.org/koji/taskinfo?taskID=1497144 OK correct BuildRequires, Requires. OK proper use of %find_lang macro. OK shared library must call ldconfig in %post and %postun. OK relocatable package must state this fact. OK package must own their directories. OK permissions on files must be set properly. OK %clean section with rm -rf %{buildroot}. OK consistent use of macros. OK package contains code, or permissable content. OK large documentation go in a -doc subpackage. OK %doc must not affect the runtime of the application. OK header files must be in a -devel package. OK static libraries must be in a -static package. OK pkgconfig(.pc) files must 'Requires: pkgconfig'. OK library files with a suffix (.so) must go in -devel. OK usually devel packages must require the base package. OK Remove .la libtool archives. OK GUI applications must include a %{name}.desktop file. OK %install section starts with rm -rf %{buildroot}.
Probably you can also change (same comment as in bz512725) files section. From %{perl_vendorlib}/* %exclude %dir %{perl_vendorarch}/auto/ To %{perl_vendorarch}/Async %{perl_vendorarch}/auto/Async If you want you can generate spec by cpanspec and we can go through review again, but I don't think that will be necessary.
Thx for the review, I will adopt the suggested %files section
New Package CVS Request ======================= Package Name: perl-Async-MergePoint Short Description: Resynchronise diverged control flow Owners: kwizart Branches: F-11 F-10 EL-5 InitialCC: perl-sig
I suppose you forgot set cvs flag to ? http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure I hope you don't mind if I set it.
Thx. I've missed it, indeed.
cvs done.