Spec Url: http://silassewell.googlecode.com/svn/trunk/projects/packages/rpms/python-lockfile/python-lockfile.spec SRPM Url: http://silassewell.googlecode.com/files/python-lockfile-0.8-1.fc12.src.rpm Description: The lockfile module exports a FileLock class which provides a simple API for locking files. Unlike the Windows msvcrt.locking function, the Unix fcntl.flock, fcntl.lockf and the deprecated posixfile module, the API is identical across both Unix (including Linux and Mac) and Windows platforms. The lock mechanism relies on the atomic nature of the link (on Unix) and mkdir (on Windows) system calls. rpmlint [silas@fox rpmbuild]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Package Review ============== Package: Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines [x] Spec file name must match the base package %{name}, in the format %{name}.spec [x] Package meets the Packaging Guidelines [x] Package successfully compiles and builds into binary RPMs on at least one supported architecture Tested on: F11/i386 [x] Rpmlint output: Source RPM: [fab@laptop09 SRPMS]$ rpmlint python-lockfile-0.8-1.fc12.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Binary RPM(s): [fab@laptop09 noarch]$ rpmlint python-lockfile-0.8-1.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [x] Package is not relocatable [x] Buildroot is correct master : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) spec file: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?] License field in the package spec file matches the actual license License type: MIT [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc [x] Spec file is legible and written in American English [x] Sources used to build the package matches the upstream source, as provided in the spec URL Upstream source: 2d515e19eb6f69d6ed711cbbafdec7ef lockfile-0.8.tar.gz Build source: 2d515e19eb6f69d6ed711cbbafdec7ef lockfile-0.8.tar.gz [x] Package is not known to require ExcludeArch [x] Architecture independent packages have: BuildArch: noarch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. %find_lang used for locales [-] %{optflags} or RPM_OPT_FLAGS are honoured [-] ldconfig called in %post and %postun if required [x] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT [x] Package must own all directories that it creates [x] Package requires other packages for directories it uses [x] Package does not own files or directories owned by other packages [x] Package does not contain duplicates in %files [x] Permissions on files are set properly. %defattr(-,root,root,-) is in every %files section [x] Package uses nothing in %doc for runtime [x] Package has a %clean section, which contains rm -rf %{buildroot} or $RPM_BUILD_ROOT [-] Included tests passed successfully [x] Package consistently uses macros [x] Package contains code, or permissable content [x] Included filenames are in UTF-8 [-] Large documentation files are in a -doc subpackage, if required [-] Header files (.h) in -devel subpackage, if present [-] Fully versioned dependency in subpackage, if present [-] Static libraries (.a) in -static subpackage, if present [-] Package requires pkgconfig, if .pc files are present [-] Development .so files in -devel subpackage, if present [x] Package does not contain any libtool archives (.la) [-] -debuginfo subpackage is present and looks complete [x] No pre-built binaries (.a, .so*, executable) [-] Package contains a properly installed .desktop file if it is a GUI application [-] Follows desktop entry spec [-] Valid .desktop Name [-] Valid .desktop GenericName [-] Valid .desktop Categories [-] Valid .desktop StartupNotify [-] .desktop file installed with desktop-file-install in %install === SUGGESTED ITEMS === [-] Timestamps preserved with cp and install [-] Uses parallel make (%{?_smp_mflags}) [x] Latest version is packaged [x] Package does not include license text files separate from upstream [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available [x] Reviewer should test that the package builds in mock Tested on: F11/i386 [x] Package should compile and build into binary RPMs on all supported architectures. Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=1500482 [x] Package functions as described [-] Scriptlets must be sane, if used [-] The placement of pkgconfig(.pc) files is correct [-] File based requires are sane [x] Changelog in allowed format I see no further blocker, package APPROVED.
New Package CVS Request ======================= Package Name: python-lockfile Short Description: A platform-independent file locking module Owners: silas Branches: F-11 InitialCC:
CVS done.
Built for devel and F-11. Thanks Fabian and Jason.
Package Change Request ====================== Package Name: python-lockfile New Branches: F-11 EL-5 Owners: silas Per request: https://bugzilla.redhat.com/show_bug.cgi?id=513546#c2
Sorry, branch should only be EL-5, disregard #5. Package Change Request ====================== Package Name: python-lockfile New Branches: EL-5 Owners: silas Per request: https://bugzilla.redhat.com/show_bug.cgi?id=513546#c2
cvs done.