Spec URL: http://akurtakov.fedorapeople.org/directory-naming.spec SRPM URL: http://akurtakov.fedorapeople.org/directory-naming-0.8-4.fc12.src.rpm Description: Old directory/naming module.
This is a full review request. The pre-review request was bug #500253.
Fix summary.
New sources: Spec URL: http://akurtakov.fedorapeople.org/directory-naming.spec SRPM URL: http://akurtakov.fedorapeople.org/directory-naming-0.8-4.fc12.src.rpm Changes: - Remove gcj support. - Build with build.sysclasspath=only.
New sources: Spec URL: http://akurtakov.fedorapeople.org/directory-naming.spec SRPM URL: http://akurtakov.fedorapeople.org/directory-naming-0.8-5.fc12.src.rpm
A few issues: - rpmlint output: directory-naming.noarch: W: non-standard-group Development/Libraries/Java directory-naming.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/directory-naming-0.8/LICENSE.txt directory-naming.noarch: W: non-conffile-in-etc /etc/maven/fragments/directory-naming - javadoc issues for naming-factory: [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/BeanFactory.java:64: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/MailSessionFactory.java:59: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/SendMailFactory.java:81: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator - there's a minor (a date in a comment) difference between the source that I generate and the one in the SRPM - I'd like to see a comment for the patch to the project files - I removed the remaining sed lines for "setproxy" and the build was fine. I think they can be removed. Otherwise, things look good. It's nice that all of the test suites run and have no failures/errors.
I don't understand - what's happening here? I saw that this package was already reviewed and even imported into CVS tree (as well as these two - #518219 and #518233 ). Why you created another Review Request?
See comment #1: "This is a full review request. The pre-review request was bug #500253." In an attempt to get maven updated, it was deemed necessary to "pre-review" some packages for bootstrapping purposes. We've decided to speed up the actual process by doing full reviews on packages that don't need this initial step.
Unsetting flag.
A few issues: - rpmlint output: directory-naming.noarch: W: non-standard-group Development/Libraries/Java directory-naming.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/directory-naming-0.8/LICENSE.txt directory-naming.noarch: W: non-conffile-in-etc /etc/maven/fragments/directory-naming FIXED except non-conffile-in-etc - javadoc issues for naming-factory: [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/BeanFactory.java:64: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/MailSessionFactory.java:59: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/SendMailFactory.java:81: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator FIXED. I don't see this warnings. - there's a minor (a date in a comment) difference between the source that I generate and the one in the SRPM I think this is acceptable. - I'd like to see a comment for the patch to the project files FIXED. Removed. It was for maven1 build which we do not support. - I removed the remaining sed lines for "setproxy" and the build was fine. I think they can be removed. FIXED. Removed. New sources: Spec: http://akurtakov.fedorapeople.org/directory-naming.spec Srpm: http://akurtakov.fedorapeople.org/directory-naming-0.8-6.fc12.src.rpm
In the near future, I'd like to see us move away from this package as it appears to be dead upstream. The summary and description could also use some work. Let's do something more like: Summary: Apache Directory Naming Component Description: Naming is a lightweight, in-memory JNDI service provider. To enable flexible deployment with limited dependencies, Naming is divided in 6 packages, each producing a separate jar artifact.
(In reply to comment #10) > In the near future, I'd like to see us move away from this package as it > appears to be dead upstream. The summary and description could also use some > work. Let's do something more like: Apache Directory project is pretty live project but this is just too old version. Latest release is from yesterday :). > > Summary: Apache Directory Naming Component > Description: Naming is a lightweight, in-memory JNDI service provider. To > enable flexible deployment with limited dependencies, Naming is divided in 6 > packages, each producing a separate jar artifact. Fixed. New sources: Spec: http://akurtakov.fedorapeople.org/directory-naming.spec Srpm: http://akurtakov.fedorapeople.org/directory-naming-0.8-7.fc12.src.rpm
(In reply to comment #11) > (In reply to comment #10) > > In the near future, I'd like to see us move away from this package as it > > appears to be dead upstream. The summary and description could also use some > > work. Let's do something more like: > Apache Directory project is pretty live project but this is just too old > version. > Latest release is from yesterday :). You're correct. I did mean the old component. > New sources: > Spec: http://akurtakov.fedorapeople.org/directory-naming.spec > Srpm: http://akurtakov.fedorapeople.org/directory-naming-0.8-7.fc12.src.rpm Thanks. Approved.
Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=128106