Spec URL: http://hubbitus.net.ru/rpm/Fedora11/vanessa_logger/vanessa_logger.spec SRPM URL: http://hubbitus.net.ru/rpm/Fedora11/vanessa_logger/vanessa_logger-0.0.7-2.fc11.src.rpm Description: Generic logging layer that may be used to log to one or more of syslog, an open file handle or a file name. Though due to limitations in the implementation of syslog opening multiple syslog loggers doesn't makes sense. Includes the ability to limit which messages will be logged based on priorities. http://koji.fedoraproject.org/koji/taskinfo?taskID=1615499 build done. P.S. In spec used 5 space tab width.
* Dependency issue - vanessa_logger-sample should depend on vanessa_logger not on vanessa_logger-devel, as libvanessa_logger.so.0 is in vanessa_logger not in the devel package.
* Is this a typo ? "confgure|configure" # I am providing my own configure macro replacement. Hopefully this # will result in fewer portability problems than using the one supplied # by various vendours. I fear that I hope in vein. CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS if [ -f confgure.in ]; then aclocal libtoolize --force --copy autoheader automake autoconf fi
Colin Kissa, thank you. I fix them. http://hubbitus.net.ru/rpm/Fedora11/vanessa_logger/vanessa_logger-0.0.7-3.fc11.src.rpm
OK: rpmlint must be run on every package rpmlint ~/rpmbuild/SPECS/vanessa_logger.spec ~/rpmbuild/RPMS/i586/vanessa_logger-* 4 packages and 1 specfiles checked; 0 errors, 0 warnings. OK: The package must be named according to the Package Naming Guidelines OK: The spec file name must match the base package FIX: The package must meet the Packaging Guidelines - Remove the requires /sbin/ldconfig, which is available on any fedora - Remove COPYING and README from the -devel and sample package the ones in the main package are sufficient. Having them in both just creates and ownership issue as they are placed in the same place. - Change the ./configure to %configure --disable-static (the macro defines all that you have defined there - use rpm --showrc to see) OK: The package must be licensed with a Fedora approved license OK: The License field in the package spec file must match the actual license OK: License text included OK: The spec file must be written in American English OK: The spec file for the package MUST be legible OK: The sources used to build the package must match the upstream source sha256sum vanessa_logger-0.0.7.tar.gz rpmbuild/SOURCES/vanessa_logger-0.0.7.tar.gz 65323bf673cbe94c7077f7bc475f95ef25a18d51f96a59cfa463a18b0e6881d0 vanessa_logger-0.0.7.tar.gz 65323bf673cbe94c7077f7bc475f95ef25a18d51f96a59cfa463a18b0e6881d0 rpmbuild/SOURCES/vanessa_logger-0.0.7.tar.gz OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture http://koji.fedoraproject.org/koji/taskinfo?taskID=1627488 N\A: ExcludeArch OK: All build dependencies must be listed in BuildRequires N\A: The spec file MUST handle locales properly OK: Must call ldconfig in %post and %postun N\A: If the package is designed to be relocatable OK: A package must own all directories that it creates OK: A Fedora package must not list a file more than once OK: Permissions on files must be set properly OK: Each package must have a %clean section OK: Each package must consistently use macros OK: The package must contain code, or permissable content N\A: Large documentation files must go in a -doc subpackage N\A: If a package includes something as %doc, it must not affect the runtime of the application OK: Header files must be in a -devel package OK: Static libraries must be in a -static package N\A: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' OK: Library files that end in .so (without suffix) must go in a -devel package OK: In the vast majority of cases, devel packages must require the base package OK: Packages must NOT contain any .la libtool archives N\A: Packages containing GUI applications must include a %{name}.desktop file OK: Packages must not own files or directories already owned by other packages OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) OK: All filenames in rpm packages must be valid UTF-8 The issues to fix are not blockers so i will approve, please make the fixes before requesting CVS. ------------------------------------------------------------------- This package (vanessa_logger) is APPROVED by topdog -------------------------------------------------------------------
(In reply to comment #4) > - Remove the requires /sbin/ldconfig, which is available on any fedora Ok. > - Remove COPYING and README from the -devel and sample package the ones in the > main package are sufficient. Having them in both just creates and ownership > issue as they are placed in the same place. Done. But now rpmlint complain 'no documentation'. Is it normal? > - Change the ./configure to %configure --disable-static (the macro defines all > that you have defined there - use rpm --showrc to see) Ok. http://hubbitus.net.ru/rpm/Fedora11/vanessa_logger/vanessa_logger-0.0.7-4.fc11.src.rpm Andrew Colin Kissa, thank you very much for review!
New Package CVS Request ======================= Package Name: vanessa_logger Short Description: Generic logging layer Owners: hubbitus Branches: F-10 F-11 EL-5 InitialCC:
cvs done.
vanessa_logger-0.0.8-5.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/vanessa_logger-0.0.8-5.fc12
vanessa_logger-0.0.8-5.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update vanessa_logger'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-13497
vanessa_logger-0.0.8-5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
vanessa_logger-0.0.8-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
vanessa_logger-0.0.8-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.