Spec URL: http://hubbitus.net.ru/rpm/Fedora11/vanessa_adt/vanessa_adt.spec SRPM URL: http://hubbitus.net.ru/rpm/Fedora11/vanessa_adt/vanessa_adt-0.0.7-3.fc11.src.rpm Description: Library of Abstract Data Types (ADTs) that may be useful. Includes queue, dynamic array and key value ADT. P.S. In spec used 5 space tab width.
Small fix: http://hubbitus.net.ru/rpm/Fedora11/vanessa_adt/vanessa_adt-0.0.7-4.fc11.src.rpm
A few issues to begin with. * Use configure macro %configure instead of ./configure - %configure --disable-static * Remove unnecessary requires /sbin/ldconfig * Remove the files README,COPYING from the devel package
(In reply to comment #2) > A few issues to begin with. > > * Use configure macro %configure instead of ./configure > - %configure --disable-static Ok. > * Remove unnecessary requires /sbin/ldconfig Done. > * Remove the files README,COPYING from the devel package I have done that. Bot now rpmlint complain about no documentation: $ rpmlint vanessa_adt-devel-0.0.7-5.fc11.athlon.rpm vanessa_adt-devel.athlon: W: no-documentation Is it normal (It was why I add it)? http://hubbitus.net.ru/rpm/Fedora11/vanessa_adt/vanessa_adt-0.0.7-5.fc11.src.rpm
You can safely ignore that rpmlint error, will do the full review later.
OK: rpmlint must be run on every package rpmlint rpmbuild/RPMS/i586/vanessa_adt-* vanessa_adt-devel.i586: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 1 warnings. OK: The package must be named according to the Package Naming Guidelines OK: The spec file name must match the base package FIX: The package must meet the Packaging Guidelines - Please add the %{?_smp_mflags} macro to the make command OK: The package must be licensed with a Fedora approved license OK: The License field in the package spec file must match the actual license OK: License text included OK: The spec file must be written in American English OK: The spec file for the package MUST be legible OK: The sources used to build the package must match the upstream source sha256sum vanessa_adt-0.0.7.tar.gz rpmbuild/SOURCES/vanessa_adt-0.0.7.tar.gz 61ae87d1e0f6edaee423fc68d6b6dd5355b1a9bf8d17ed9e9047fc9e3459c0fd vanessa_adt-0.0.7.tar.gz 61ae87d1e0f6edaee423fc68d6b6dd5355b1a9bf8d17ed9e9047fc9e3459c0fd rpmbuild/SOURCES/vanessa_adt-0.0.7.tar.gz OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture N\A: ExcludeArch OK: All build dependencies must be listed in BuildRequires N\A: The spec file MUST handle locales properly OK: Must call ldconfig in %post and %postun N\A: If the package is designed to be relocatable OK: A package must own all directories that it creates OK: A Fedora package must not list a file more than once OK: Permissions on files must be set properly OK: Each package must have a %clean section OK: Each package must consistently use macros OK: The package must contain code, or permissable content N\A: Large documentation files must go in a -doc subpackage N\A: If a package includes something as %doc, it must not affect the runtime of the application OK: Header files must be in a -devel package N\A: Static libraries must be in a -static package N\A: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' OK: Library files that end in .so (without suffix) must go in a -devel package OK: In the vast majority of cases, devel packages must require the base package OK: Packages must NOT contain any .la libtool archives N\A: Packages containing GUI applications must include a %{name}.desktop file OK: Packages must not own files or directories already owned by other packages OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) OK: All filenames in rpm packages must be valid UTF-8 Fix the smp flags before import i have tested and it does build with the flags set. Otherwise all looks good. ------------------------------------------------------------------- This package (vanessa_adt) is APPROVED by topdog -------------------------------------------------------------------
Andrew Colin Kissa, I'll add %{?_smp_mflags}. Thank you very much for the review. New Package CVS Request ======================= Package Name: vanessa_adt Short Description: Library of Abstract Data Types Owners: hubbitus Branches: F-10 F-11 EL-5 InitialCC:
cvs done.
vanessa_adt-0.0.7-6.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/vanessa_adt-0.0.7-6.fc14
vanessa_adt-0.0.7-6.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/vanessa_adt-0.0.7-6.fc13
vanessa_adt-0.0.7-6.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/vanessa_adt-0.0.7-6.fc12
vanessa_adt-0.0.7-6.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/vanessa_adt-0.0.7-6.el5
Sorry, I forgot about this package. Now built.
vanessa_adt-0.0.7-6.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update vanessa_adt'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/vanessa_adt-0.0.7-6.el5
vanessa_adt-0.0.7-6.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
vanessa_adt-0.0.7-6.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
vanessa_adt-0.0.7-6.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
vanessa_adt-0.0.7-6.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.