SPEC: http://pbrobinson.fedorapeople.org/moblin-panel-media.spec SRPM: http://pbrobinson.fedorapeople.org/moblin-panel-media-0.0.1-1.fc11.src.rpm koji: none at the moment due to dep on bickley. Built locally though. Description: The Moblin mutter panel for managing and playing media.
Assigning this to myself; will do review once bickley lands.
Added upstream patch for bognor-regis 0.4.10. Builds on my local build box. SPEC: as above SRPM: http://pbrobinson.fedorapeople.org/moblin-panel-media-0.0.1-2.fc11.src.rpm
Ping?
Hello, yes! Not forgotten, rest assured. Been a bit busy with other things. Full review in a couple of hours.
APPROVED Everything looks fine. Note the licensing question mark below, though. Koji F-12 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1651516 MUST OK rpmlint OK package name OK spec file name OK package guideline-compliant OK license complies with guidelines OK license field accurate: assuming the + in GPLv2+ from other similar packages perhaps nag upstream to put license header in the source file, per GPL requirement (phew! I'm definitely starting to prefer the GPL-compatible CeCILL for my own work) OK license file not deleted OK spec in US English OK spec legible OK source matches upstream OK builds under >= 1 archs, others excluded (Koji) OK build dependencies complete OK locales handled using %find_lang, no %{_datadir}/locale OK own all directories OK no dupes in %files OK permission OK %clean RPM_BUILD_ROOT OK macros used consistently OK Package contains code OK clean buildroot before install OK filenames UTF-8 SHOULD FIXME if license text missing, ask upstream to include it license text not missing, but license header is OK package build in mock on all architectures ? package functioned as described will take your word on it; setting it loose on a multi-gigabyte movie/music library is not recommended! OK require package not files
New Package CVS Request ======================= Package Name: moblin-panel-media Short Description: Moblin Panel for Media Owners: pbrobinson Branches: F-11 InitialCC:
CVS done.
Built and on its way to rawhide