Bug 518650 - Review Request: plexus-mail-sender - Plexus Mail Sender
Summary: Review Request: plexus-mail-sender - Plexus Mail Sender
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alexander Kurtakov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 429551
TreeView+ depends on / blocked
 
Reported: 2009-08-21 13:38 UTC by Andrew Overholt
Modified: 2009-08-21 19:55 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-08-21 19:55:43 UTC
akurtako: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Andrew Overholt 2009-08-21 13:38:53 UTC
Spec URL: http://overholt.fedorapeople.org/plexus-mail-sender.spec
SRPM URL: http://overholt.fedorapeople.org/plexus-mail-sender-1.0-0.a2.9.fc11.src.rpm

Description:
The Plexus project seeks to create end-to-end developer tools for
writing applications. At the core is the container, which can be
embedded or for a full scale application server. There are many
reusable components for hibernate, form processing, jndi, i18n,
velocity, etc. Plexus also includes an application server which
is like a J2EE application server, without all the baggage.  This
Plexus component provides SMTP transport.

Comment 1 Andrew Overholt 2009-08-21 13:39:48 UTC
This is a full review request.  Old pre-review request:  bug #500252.

Comment 2 Alexander Kurtakov 2009-08-21 15:00:41 UTC
Review:

OK: rpmlint must be run on every package. 
plexus-mail-sender.noarch: W: no-documentation 
But there is nothing suitable in the sources.

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . See http://jira.codehaus.org/browse/PLX-417
OK: The License field in the package spec file must match the actual license.
OK: The spec file must be written in American English. [5]
OK: The spec file for the package MUST be legible. [6]
OK: The sources used to build the package must match the upstream source, as provided in the spec URL.
OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires
OK: A package must own all directories that it creates.
OK: A Fedora package must not list a file more than once in the spec file's %files listings. 
OK: Permissions on files must be set properly. 
OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK: Each package must consistently use macros. [16]
OK: The package must contain code, or permissable content. [17]
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of the application. 
OK: Packages must not own files or directories already owned by other packages. 
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [25]
OK: All filenames in rpm packages must be valid UTF-8. [26]

This package is APPROVED

Comment 3 Andrew Overholt 2009-08-21 15:26:08 UTC
New Package CVS Request
=======================
Package Name: plexus-mail-sender
Short Description: Plexus Mail Sender
Owners: overholt
Branches: 
InitialCC: akurtakov

Comment 4 Dennis Gilmore 2009-08-21 18:19:34 UTC
CVS Done

Comment 5 Andrew Overholt 2009-08-21 19:55:43 UTC
Built:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1623947


Note You need to log in before you can comment on or make changes to this bug.