Spec URL: http://akurtakov.fedorapeople.org/maven-enforcer-rule-api.spec SRPM URL: http://akurtakov.fedorapeople.org/maven-enforcer-rule-api-1.0-0.1.a2.1.4.fc11.src.rpm Description: This component provides the generic interfaces needed to implement custom rules for the maven-enforcer-plugin.
This is a full review request. Pre review was #500270 .
- no differences in source I get vs. what's in the SRPM X please make lines 19, 20, 90, and 95 < 80 characters ? should we make the versioned BRs and Rs on maven2 be >= 2.0.8? X let's drop the with_maven/without_maven junk at the top - macros sane - clean used appropriately - licensing fine - description and summary fine X please add a changelog entry - builds fine - rpmlint output is fine (doesn't like maven fragment in /etc and no files to mark as documentation)
I forgot one thing: X please only own the fragment %{name} and specific pom (JPP-maven-enforcer-rule-api.pom)
(In reply to comment #2) > - no differences in source I get vs. what's in the SRPM > X please make lines 19, 20, 90, and 95 < 80 characters Fixed. %add_to_maven_depmap line can't be fixed because this breaks the macro. > ? should we make the versioned BRs and Rs on maven2 be >= 2.0.8? Done. > X let's drop the with_maven/without_maven junk at the top Fixed. > - macros sane > - clean used appropriately > - licensing fine > - description and summary fine > X please add a changelog entry Done. > - builds fine > - rpmlint output is fine (doesn't like maven fragment in /etc and no files to > mark as documentation) > X please only own the fragment %{name} and specific pom > (JPP-maven-enforcer-rule-api.pom) Fixed. New sources: Spec URL: http://akurtakov.fedorapeople.org/maven-enforcer-rule-api.spec SRPM URL: http://akurtakov.fedorapeople.org/maven-enforcer-rule-api-1.0-0.1.a2.1.5.fc11.src.rpm
Approved.
New Package CVS Request ======================= Package Name: maven-enforcer-rule-api Short Description: This component provides the generic interfaces needed to implement custom rules for the maven-enforcer-plugin. Owners: overholt, akurtakov Branches: InitialCC:
I shortened the Short Description to actually be short. CVS done.
Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=130084
Package Change Request ====================== Package Name: maven-enforcer-rule-api New Branches: EL-6 Owners: bar lkundrak Unfortunately, overholt, who owns this in Fedora stated (by mail) that he can't maintain this in EPEL.
CVS done (by process-cvs-requests.py). User 'bar' doesn't seem to exist. Otherwise done.