Bug 521064 - Review Request:kxml - Small XML pull parser specially designed for constrained environments
Summary: Review Request:kxml - Small XML pull parser specially designed for constraine...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Andrew Overholt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 486360
TreeView+ depends on / blocked
 
Reported: 2009-09-03 12:27 UTC by Alexander Kurtakov
Modified: 2009-09-04 13:46 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-04 13:46:08 UTC
overholt: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Alexander Kurtakov 2009-09-03 12:27:50 UTC
Spec URL: http://akurtakov.fedorapeople.org/kxml.spec
SRPM URL: http://akurtakov.fedorapeople.org/kxml-2.2.2-4.fc11.src.rpm
Description: kXML is a small XML pull parser, specially designed for constrained
environments such as Applets, Personal Java or MIDP devices.

Comment 1 Andrew Overholt 2009-09-03 12:59:13 UTC
X let's remove "specially designed for constrained environments" from Summary
X lines 78, 82, and 83 are too long
X let's make the description for javadoc say "API documentation for %{name}"
X the pom is slightly different (nothing of consequence) than the one I download; can you re-download that source?

- md5sum of source0 okay
- macros good
- clean used appropriately
- buildroot fine
- naming and licensing fine
- rpmlint output fine:

$ rpmlint /home/overholt/rpmbuild/SRPMS/kxml-2.2.2-4.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint /home/overholt/rpmbuild/RPMS/noarch/kxml-2.2.2-4.fc11.noarch.rpm
kxml.noarch: W: non-conffile-in-etc /etc/maven/fragments/kxml
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint /home/overholt/rpmbuild/RPMS/noarch/kxml-javadoc-2.2.2-4.fc11.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 2 Alexander Kurtakov 2009-09-03 13:10:50 UTC
(In reply to comment #1)
> X let's remove "specially designed for constrained environments" from Summary
Done.
> X lines 78, 82, and 83 are too long
Done.
> X let's make the description for javadoc say "API documentation for %{name}"
Done.
> X the pom is slightly different (nothing of consequence) than the one I
> download; can you re-download that source?
Done
> 
> - md5sum of source0 okay
> - macros good
> - clean used appropriately
> - buildroot fine
> - naming and licensing fine
> - rpmlint output fine:
> 
> $ rpmlint /home/overholt/rpmbuild/SRPMS/kxml-2.2.2-4.fc11.src.rpm
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> $ rpmlint /home/overholt/rpmbuild/RPMS/noarch/kxml-2.2.2-4.fc11.noarch.rpm
> kxml.noarch: W: non-conffile-in-etc /etc/maven/fragments/kxml
> 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
> 
> $ rpmlint
> /home/overholt/rpmbuild/RPMS/noarch/kxml-javadoc-2.2.2-4.fc11.noarch.rpm
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.  

New sources:
Spec URL: http://akurtakov.fedorapeople.org/kxml.spec
SRPM URL: http://akurtakov.fedorapeople.org/kxml-2.2.2-5.fc11.src.rpm

Comment 3 Andrew Overholt 2009-09-03 13:49:52 UTC
Thanks, approved.

Comment 4 Alexander Kurtakov 2009-09-03 14:20:58 UTC
New Package CVS Request
=======================
Package Name: kxml
Short Description: kXML is a small XML pull parser
Owners: akurtakov
Branches: 
InitialCC:

Comment 5 Dennis Gilmore 2009-09-03 15:11:40 UTC
CVS Done

Comment 6 Alexander Kurtakov 2009-09-04 13:46:08 UTC
Build in rawhide.


Note You need to log in before you can comment on or make changes to this bug.