Bug 523610 - error occured during shrink install
Summary: error occured during shrink install
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 19
Hardware: i386
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Cantrell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: anaconda_trace_hash:775a7e9cfe7de9935...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-09-16 07:22 UTC by He Rui
Modified: 2023-09-14 01:18 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-13 20:05:01 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Attached traceback automatically from anaconda. (177.29 KB, text/plain)
2009-09-16 07:22 UTC, He Rui
no flags Details
Attached traceback automatically from anaconda. (105.83 KB, text/plain)
2009-09-24 03:40 UTC, Arenas Belon, Carlo Marcelo
no flags Details
Attached traceback automatically from anaconda. (67.03 KB, text/plain)
2009-10-30 06:54 UTC, Arenas Belon, Carlo Marcelo
no flags Details
proposed fix for anaconda 12.41 (or later) (1012 bytes, patch)
2009-11-01 02:34 UTC, Arenas Belon, Carlo Marcelo
no flags Details | Diff
Attached traceback automatically from anaconda. (75.33 KB, text/plain)
2009-11-05 05:46 UTC, Arenas Belon, Carlo Marcelo
no flags Details
Attached traceback automatically from anaconda. (157.82 KB, text/plain)
2009-11-05 06:59 UTC, He Rui
no flags Details
ks.cfg for installing a f12 system to be shrunk. (1.61 KB, application/octet-stream)
2009-11-06 02:51 UTC, He Rui
no flags Details
Attached traceback automatically from anaconda. (76.94 KB, text/plain)
2009-12-18 14:25 UTC, Steve Dickson
no flags Details
Attached traceback automatically from anaconda. (83.94 KB, text/plain)
2010-02-09 23:00 UTC, Gregory Gleason
no flags Details
Attached traceback automatically from anaconda. (55.09 KB, text/plain)
2010-04-09 08:56 UTC, Mohammed Arafa
no flags Details

Description He Rui 2009-09-16 07:22:43 UTC
The following was filed automatically by anaconda:
anaconda 12.24 exception report
Traceback (most recent call first):
  File "/usr/lib/anaconda/storage/devices.py", line 1974, in _setSize
    raise ValueError("not enough free space in volume group")
  File "/usr/lib/anaconda/storage/partitioning.py", line 1189, in growLVM
    lv.size += grow_amounts[lv.name]
  File "/usr/lib/anaconda/storage/partitioning.py", line 209, in doAutoPartition
    growLVM(anaconda.id.storage)
  File "/usr/lib/anaconda/dispatch.py", line 204, in moveStep
    rc = stepFunc(self.anaconda)
  File "/usr/lib/anaconda/dispatch.py", line 127, in gotoNext
    self.moveStep()
  File "/usr/lib/anaconda/gui.py", line 1201, in nextClicked
    self.anaconda.dispatch.gotoNext()
ValueError: not enough free space in volume group

Comment 1 He Rui 2009-09-16 07:22:50 UTC
Created attachment 361198 [details]
Attached traceback automatically from anaconda.

Comment 2 Chris Lumens 2009-09-23 14:43:03 UTC

*** This bug has been marked as a duplicate of bug 517491 ***

Comment 3 Arenas Belon, Carlo Marcelo 2009-09-24 03:40:19 UTC
Created attachment 362406 [details]
Attached traceback automatically from anaconda.

Comment 4 Arenas Belon, Carlo Marcelo 2009-10-30 06:54:25 UTC
Created attachment 366765 [details]
Attached traceback automatically from anaconda.

Comment 5 Arenas Belon, Carlo Marcelo 2009-10-30 07:06:23 UTC
Still reproducible with anaconda 12.42-1, and which should had fixed BUG517491 and that has a different root cause than this report but that was linked as a duplicate.

to reproduce :

1) create a qemu-img of 2GB for harddisk
2) start kvm with 2GB memory and install fedora on that disk
3) accept default options for partitioning which would then try to allocate a swap partition of 2GB inside a smaller lvm and result in negative values for partition sizes and a crash.

what is expected :

anaconda reports that there is not enough disk space for the recommended layout and allows installation to proceed by allowing user to use a different setup.

what happens :

anaconda dies with a traceback

Comment 6 Arenas Belon, Carlo Marcelo 2009-11-01 02:34:09 UTC
Created attachment 366991 [details]
proposed fix for anaconda 12.41 (or later)

to easy testing an anaconda-12.41-1 update.img available from :

  http://sajino.sajinet.com.pe/update.img

12.42 hasn't been tested as there is not yet an snapshot that includes it so disregard previous comment about testing the bugfix for BUG517491.

Comment 7 David Cantrell 2009-11-03 02:37:08 UTC
(In reply to comment #6)
> Created an attachment (id=366991) [details]
> proposed fix for anaconda 12.41 (or later)
> 
> to easy testing an anaconda-12.41-1 update.img available from :
> 
>   http://sajino.sajinet.com.pe/update.img
> 
> 12.42 hasn't been tested as there is not yet an snapshot that includes it so
> disregard previous comment about testing the bugfix for BUG517491.  

This fix is not actually fixing the root cause of the problem, just working around the issue seen.  I'd like to see why some people are seeing that ValueError exception and fix that.

Comment 8 Arenas Belon, Carlo Marcelo 2009-11-03 10:49:51 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > Created an attachment (id=366991) [details] [details]
> > proposed fix for anaconda 12.41 (or later)
> > 
> > to easy testing an anaconda-12.41-1 update.img available from :
> > 
> >   http://sajino.sajinet.com.pe/update.img
> > 
> > 12.42 hasn't been tested as there is not yet an snapshot that includes it so
> > disregard previous comment about testing the bugfix for BUG517491.  
> 
> This fix is not actually fixing the root cause of the problem, just working
> around the issue seen.

Sorry I wasn't clear about that, but yes, that is why the patch description says it is a workaround.

My objective with this patch was to make the minimum amount of changes possible so that it could be considered safe enough for F12 (if possible), specially considering that this report got probably lost on the confusion with the ext[2-4] failures that it was merged into.

I don't think though, the problem to be serious enough for going against the F12 freeze, if nothing because it will only happen when the disk available is
small (2GB) and there is a lot of memory (1GB to 2GB) and that is not even realistic even for netbooks or OLPC but would argue about being a closed issue.

> I'd like to see why some people are seeing that ValueError exception and
> fix that.

Agree, but considering that 12.41 is already obsoleted as per the 20091103 snapshot didn't make much sense to do all the debugging for the root cause there IMHO.

It is important to mention that some of the code to calculate the partition sizes has changed on master already and the fact that in the current code for growLVM in f12-branch, the vg.vgFree is allowed to be negative as described in the replication steps is IMHO suspicious.

also noticed while debugging this problem that there might be overlapping partitions which could also explain the problems reported elsewhere but which would be better tracked through a different bug report if confirmed to be still present in 12.42.

Comment 9 Arenas Belon, Carlo Marcelo 2009-11-05 05:46:18 UTC
Created attachment 367575 [details]
Attached traceback automatically from anaconda.

Comment 10 He Rui 2009-11-05 06:59:49 UTC
Created attachment 367578 [details]
Attached traceback automatically from anaconda.

Comment 11 He Rui 2009-11-06 02:49:03 UTC
It happened in anaconda 12.43 and the steps below is 100% reproducable in my machine:

1. Install f12 with minimal package install, clear all existing partitions and
create new partitions like this: 

sda1   /boot ext4 200M
sda2   /     ext4  20G
sda3   swap       512M 

the other settings is by default.
(A ks.cfg was attached for this installation.)

2. Install another f12 on the same machine, in the partition step, choose
'shrink sda2' and click 'OK'.

3. Exception occurred saying 'ValueError: not enough free space in volume
group'

Comment 12 He Rui 2009-11-06 02:51:33 UTC
Created attachment 367777 [details]
ks.cfg for installing a f12 system to be shrunk.

I also advice this bug to be blocker bug.

Comment 13 Adam Williamson 2009-11-06 18:09:53 UTC
this was discussed at the blocker meeting today. we generally agreed that we don't have a sufficiently solid base of shrink code to expect all shrink operations to work, so we won't generally take shrink failures as blockers.

however, if this causes any pre-existing data to be lost, corrupted or otherwise damaged, that could be a blocker. can you please test whether the failure causes any adverse effects for the existing data? or does the shrink just fail without actually touching the existing data in any way? thanks.

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 14 He Rui 2009-11-09 06:15:27 UTC
I retested with f12-RC4, the shrink failure happened before formatting any partition, so the existing data was intact.

Comment 15 Arenas Belon, Carlo Marcelo 2009-11-09 10:14:52 UTC
BUG533797 open for the simpler case, when the failure of autopartition was triggered by the use of a disk smaller than recommended as detailed in comment #5 and to avoid confusing that issue (which has the same anaconda traceback) with the one triggered by resizing and that is described in comment #11.

since the behaviour is similar the workaround proposed on that bug might also work for this case but hadn't been tested with the same partition sizes as suggested by Rui.

Comment 16 Bug Zapper 2009-11-16 12:27:44 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle.
Changing version to '12'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 17 Steve Dickson 2009-12-18 14:25:11 UTC
Created attachment 379216 [details]
Attached traceback automatically from anaconda.

Comment 18 Gregory Gleason 2010-02-09 23:00:34 UTC
Created attachment 389866 [details]
Attached traceback automatically from anaconda.

Comment 19 Gregory Gleason 2010-02-09 23:04:45 UTC
Comment on attachment 389866 [details]
Attached traceback automatically from anaconda.

I was trying to install f12 as a virtual guest using virt-install onto a 1.2GB LV

Comment 20 Mohammed Arafa 2010-04-09 08:56:03 UTC
Created attachment 405488 [details]
Attached traceback automatically from anaconda.

Comment 21 Bug Zapper 2010-11-04 10:00:33 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 22 Fedora End Of Life 2013-04-03 19:51:39 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 23 Red Hat Bugzilla 2023-09-14 01:18:09 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days


Note You need to log in before you can comment on or make changes to this bug.