Bug 524558 (rhnsd) - Review Request: rhnsd - Red Hat Network query daemon
Summary: Review Request: rhnsd - Red Hat Network query daemon
Alias: rhnsd
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Sandro Mathys
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: F-Spacewalk
TreeView+ depends on / blocked
Reported: 2009-09-21 08:04 UTC by Miroslav Suchý
Modified: 2013-03-10 04:11 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2009-09-23 13:12:00 UTC
sandro: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Miroslav Suchý 2009-09-21 08:04:28 UTC

The Red Hat Update Agent that automatically queries the Red Hat
Network servers and determines which packages need to be updated on
your machine, and runs any actions.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1365447  

rpmlint gives:
 rhnsd.i386: W: service-default-enabled /etc/rc.d/init.d/rhnsd
But this should be ok, since it purpose of this daemon to be enabled by default.

Comment 1 Miroslav Suchý 2009-09-21 08:14:44 UTC
Correct link to scratch build:

Comment 2 Sandro Mathys 2009-09-21 12:35:27 UTC
Okay, this looks fine on the first glance. Let's work through the MUST and the SHOULD lists.


NOK MUST:   rpmlint must be run on every package. The output should be posted in the review.

I get a different output:
$ rpmlint {SPECS,RPMS/i586,SRPMS}/rhnsd*
rhnsd.i586: W: service-default-enabled /etc/rc.d/init.d/rhnsd
rhnsd.i586: W: service-default-enabled /etc/rc.d/init.d/rhnsd
rhnsd-debuginfo.i586: E: debuginfo-without-sources
3 packages and 1 specfiles checked; 1 errors, 2 warnings.

I agree that rhnsd should be enabled by default and that therefore the warning can be ignored. The error must be fixed, tho.

OK  MUST:   The package must be named according to the Package Naming Guidelines.

OK  MUST:   The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.

NOK MUST:   The package must meet the Packaging Guidelines.

`make` is missing: %{?_smp_mflags} CXXFLAGS="%{optflags}"

OK  MUST:   The package must be licensed with a Fedora approved license and meet the Licensing Guidelines.

NOK MUST:   The License field in the package spec file must match the actual license.

AFAICS you state 'GPLv2' in the spec file while the rhnsd.c reads 'GPL'.

N/A MUST:   If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.

OK  MUST:   The spec file must be written in American English.

OK  MUST:   The spec file for the package MUST be legible.

Personally, I'd see that everything abov of %description is aligned (e.g. the pkg names in the requires section).

OK  MUST:   The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.

8ead968af7384d2a5e822baa8ec4e2b6  rhnsd-4.5.12.tar.gz

OK  MUST:   The package MUST successfully compile and build into binary rpms on at least one primary architecture.

F11 i586

N/A MUST:   If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.

OK  MUST:   All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.

OK  MUST:   The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

N/A MUST:   Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.

OK  MUST:   Packages must NOT bundle copies of system libraries.

N/A MUST:   If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.

OK  MUST:   A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.

OK  MUST:   A Fedora package must not list a file more than once in the spec file's %files listings.

OK  MUST:   Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line.

OK  MUST:   Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).

OK  MUST:   Each package must consistently use macros.

OK  MUST:   The package must contain code, or permissable content.

OK  MUST:   Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).

N/A MUST:   If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.

N/A MUST:   Header files must be in a -devel package.

N/A MUST:   Static libraries must be in a -static package.

N/A MUST:   Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability).

N/A MUST:   If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.

N/A MUST:   In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release}

N/A MUST:   Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.

N/A MUST:   Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.

OK  MUST:   Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.

OK  MUST:   At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).

OK  MUST:   All filenames in rpm packages must be valid UTF-8.


SHOULD:     If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.

Please do so and add the LICENSE file to %doc. Not necessary for approval, tho.

SHOULD:     The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.

OK SHOULD:  The reviewer should test that the package builds in mock.


SHOULD:     The package should compile and build into binary rpms on all supported architectures.

SHOULD:     The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.

OK SHOULD:  If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity.

N/A SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.

N/A SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb.

OK SHOULD:  If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.


Please fix the above mentioned issues and upload the new pkg/spec files.

Comment 3 Sandro Mathys 2009-09-21 12:50:14 UTC
Sorry, forgot to include this above.

$ rpmlint -I debuginfo-without-sources
This debuginfo package appears to contain debug symbols but no source files.
This is often a sign of binaries being unexpectedly stripped too early during
the build, or being compiled without compiler debug flags (which again often
is a sign of distro's default compiler flags ignored which might have security
consequences), or other compiler flags which result in rpmbuild's debuginfo
extraction not working as expected.  Verify that the binaries are not
unexpectedly stripped and that the intended compiler flags are used.

Comment 4 Miroslav Suchý 2009-09-22 13:40:54 UTC
Got it, the debuginfo happened to be bug of rpmbuild (bug 524844). 
Updated files:

Comment 5 Sandro Mathys 2009-09-22 14:01:10 UTC
Well, if it's really a bug in rpmbuild, I guess I can't blame you for it. I still get the error msg but I guess you only fixed that on your system :)

Everything else seems fixed, including the LICENSE file (and license change) from upstream :) Going to approve this, next step is to do the CVS admin request: http://fedoraproject.org/wiki/CVS_admin_requests

   This package (rhnsd) is APPROVED by red (Sandro Mathys)

Comment 6 Miroslav Suchý 2009-09-22 14:23:59 UTC
New Package CVS Request
Package Name: rhnsd
Short Description: Red Hat Network query daemon
Owners: msuchy
Branches: F-11, F-12

Comment 7 Kevin Fenzi 2009-09-22 16:32:01 UTC
cvs done.

Note You need to log in before you can comment on or make changes to this bug.