Spec URL: http://thomasj.fedorapeople.org/reviews/blokkal.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/blokkal-0.1.1-2.fc10.src.rpm Description: Blokkal is a KDE blogging client that supports multiple protocols and blogging sites. The goal is to provide a uniform way to access the most-commonly-used blogging systems. It has been designed for a maximum of modularity allowing for easy extension. Currently the following protocols are supported: LiveJournal Blogger 1.0 Blogger/GData MetaWeblog API MovableType Blokkal is capable of creating new entries as well as loading and editing entries that have already been posted into a blog. Additionally, new entries can be posted into multiple blogs at the same time and entries can be previewed before being posted. A couple of formatting options help to apply some common text formattings while editing the HTML-code of an entry, while syntax-highlighting aids in ensuring correct code. There exist dialogs that help inserting links and images, which can be dragged and dropped into the editor from other applications such as webbrowsers. [thomas@tusdell SPECS]$ rpmlint blokkal.spec ../SRPMS/blokkal-0.1.1-2.fc10.src.rpm ../RPMS/x86_64/blokkal-0.1.1-2.fc10.x86_64.rpm ../RPMS/x86_64/blokkal-debuginfo-0.1.1-2.fc10.x86_64.rpm ../RPMS/x86_64/blokkal-libs-0.1.1-2.fc10.x86_64.rpm 4 packages and 1 specfiles checked; 0 errors, 0 warnings. http://koji.fedoraproject.org/koji/taskinfo?taskID=1724321
Better use of macro %{name} in spec. Spec URL: http://thomasj.fedorapeople.org/reviews/blokkal.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/blokkal-0.1.1-3.fc10.src.rpm [thomas@tusdell ~]$ rpmlint rpmbuild/SPECS/blokkal.spec rpmbuild/SRPMS/blokkal-0.1.1-3.fc10.src.rpm rpmbuild/RPMS/x86_64/blokkal-*-3* 4 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
- Removed unneeded BR - Changed appsdir to blokkal/ to own the dir Spec URL: http://thomasj.fedorapeople.org/reviews/blokkal.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/blokkal-0.1.1-4.fc10.src.rpm [thomas@tusdell ~]$ rpmlint rpmbuild/SPECS/blokkal.spec rpmbuild/SRPMS/blokkal-0.1.1-4.fc10.src.rpm rpmbuild/RPMS/x86_64/blokkal-*-4* 4 packages and 1 specfiles checked; 0 errors, 0 warnings. http://koji.fedoraproject.org/koji/taskinfo?taskID=1744873 -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
Since I'm an a "review Thomas' pkg" roll today, I'll take a look at this one too. :)
Source checksum: 6a93b0207269cfa645d4d186797f984d Blokkal-0.1.1.tar.bz2 macro usage: OK scriptlets: OK Comments. 1. %check: Though, I'm fairly sure your adjustments there are largely legit, would be preferable if those sed/patches were in %prep section. (upstream has been contacted?) Guidelines-wise, .desktop validation is only required for stuff under %_datadir/applications/ So, you really only want this in %check: desktop-file-validate %{buildroot}%{_kde4_datadir}/applications/kde4/%{name}.desktop 2. Source0 URL should be: http://downloads.sourceforge.net/sourceforge/blokkal/files/Blokkal-%{version}.tar.bz2 3. No need for these in both main and -libs (preferably keep only in main pkg): %doc AUTHORS COPYING INSTALL
(In reply to comment #4) > Source checksum: > 6a93b0207269cfa645d4d186797f984d Blokkal-0.1.1.tar.bz2 6a93b0207269cfa645d4d186797f984d Blokkal-0.1.1.tar.bz2 same here > macro usage: OK > scriptlets: OK > > > Comments. > > 1. %check: > Though, I'm fairly sure your adjustments there are largely legit, would be > preferable if those sed/patches were in %prep section. (upstream has been > contacted?) Upstream has been contacted. Martin Müller committed the changes to svn and they will be included in the next release. I removed the sed trickery for now, since it's not making any difference for blokkal. > Guidelines-wise, .desktop validation is only required for stuff under > %_datadir/applications/ > > So, you really only want this in %check: > desktop-file-validate > %{buildroot}%{_kde4_datadir}/applications/kde4/%{name}.desktop Fixed > 2. Source0 URL should be: > http://downloads.sourceforge.net/sourceforge/blokkal/files/Blokkal-%{version}.tar.bz2 Whoops, fixed. > 3. No need for these in both main and -libs (preferably keep only in main > pkg): > %doc AUTHORS COPYING INSTALL Fixed as well. Forgot to remove the dupes. Spec URL: http://thomasj.fedorapeople.org/reviews/blokkal.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/blokkal-0.1.1-5.fc10.src.rpm [thomas@tusdell ~]$ rpmlint rpmbuild/SPECS/blokkal.spec rpmbuild/SRPMS/blokkal-0.1.1-5.fc10.src.rpm rpmbuild/RPMS/x86_64/blokkal-*-5* blokkal-libs.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 1 warnings. http://koji.fedoraproject.org/koji/taskinfo?taskID=1745214 -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
Updated to new upstream version. Spec URL: http://thomasj.fedorapeople.org/reviews/blokkal.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/blokkal-0.1.2-1.fc10.src.rpm [thomas@tusdell SPECS]$ rpmlint blokkal.spec ../SRPMS/blokkal-0.1.2-1.fc10.src.rpm ../RPMS/x86_64/blokkal-*.2-1* blokkal-libs.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 1 warnings. http://koji.fedoraproject.org/koji/taskinfo?taskID=1772724 I contacted upstream that it would be nice to have a changelog *somewhere* and that blokkal is missing an icon for "Crosspost". Else it just works. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
Stupid me. The Changelog is here: http://www.kde-apps.org/content/show.php/Blokkal?content=53644 This release adds support for configuring accounts with RSD and fixes some bugs. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
Looks good, I see no blockers. APPROVED.
Thanks for the review Rex. New Package CVS Request ======================= Package Name: blokkal Short Description: A KDE blogging client that supports multiple protocols and sites Owners: thomasj Branches: F-11 F-12 InitialCC: -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
CVS done (by process-cvs-requests.py).
blokkal-0.1.2-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/blokkal-0.1.2-1.fc12
blokkal-0.1.2-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/blokkal-0.1.2-1.fc11
blokkal-0.1.2-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update blokkal'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0940
blokkal-0.1.2-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update blokkal'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0957
blokkal-0.1.2-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
blokkal-0.1.2-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.