Bug 530308 - [PATCH] wrong interaction with netinstall iso
Summary: [PATCH] wrong interaction with netinstall iso
Keywords:
Status: CLOSED DUPLICATE of bug 604942
Alias: None
Product: Fedora
Classification: Fedora
Component: livecd-tools
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: David Huff
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-10-22 09:49 UTC by Michal Hlavinka
Modified: 2010-08-07 19:06 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-08-07 19:06:31 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
a) refuse netinstall cd (676 bytes, patch)
2009-10-27 11:42 UTC, Michal Hlavinka
no flags Details | Diff
b) handle netinstall cd correctly (1.20 KB, patch)
2009-10-27 11:42 UTC, Michal Hlavinka
no flags Details | Diff
Allows use of iso-to-disk script to be used with netinstall ISO (820 bytes, patch)
2010-08-05 13:43 UTC, Jasper O'neal Hartline
no flags Details | Diff

Description Michal Hlavinka 2009-10-22 09:49:36 UTC
Description of problem:
when doing network installation there should be some url pre-filled, most probably with mirror list. It's quite difficult and not necessary to made user write there such long url.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1.netinstall
2.
3.
  
Actual results:
no url prefilled

Expected results:
url prefilled

Additional info:

Comment 1 Chris Lumens 2009-10-22 12:22:23 UTC
There shouldn't be any need to prefill anything.  If you are doing an install using boot.iso, anaconda will use the Fedora mirror system by default.  If you are doing an install with vmlinuz+initrd.img (like a pxeboot, for instance) it's assumed you know what you are doing and want to specify those args yourself.  You can always automate that yourself by modifying pxeboot configs, of course.

What kind of install are you doing that ends up in this situation?

Comment 2 Michal Hlavinka 2009-10-22 12:49:25 UTC
well, I've checked it again and found this:

when I boot Fedora-12-Beta-x86_64-netinst.iso in qemu it acts differently than netinst iso installed on usb stick with livecd-iso-to-disk

anaconda works as expected, changing component to livecd-tools

Bug description:
livecd-iso-to-disk accepts Fedora's netinst.iso without producing any error, only warning about missing checksums. The usb stick prepared this way is missing some files required for proper installation.

steps to reproduce:
# livecd-iso-to-disk /mnt/root/Fedora-12-Beta-x86_64-netinst.iso /dev/sdb1
Verifying image...
/mnt/root/Fedora-12-Beta-x86_64-netinst.iso: Could not get pvd data
Unable to read the disc checksum from the primary volume descriptor.
This probably means the disc was created without adding the checksum.Are you SURE you want to continue?
Press Enter to continue or ctrl-c to abort

Already set up as live image.
Deleting old OS in fifteen seconds...
Copying live image to USB stick
Updating boot config file
Installing boot loader
USB stick set up as live image!

actual result:
usb missing some files required for netinstall

expected result:
no files missing for netinstall OR produce error message if this tool can't handle (and is not expected to) work with netinstall isos

Comment 3 Jeremy Katz 2009-10-22 15:42:47 UTC
livecd-iso-to-disk is, as the name implies, for livecds.  The netinst.iso is not a livecd so you shouldn't use it with it.

Comment 4 Michal Hlavinka 2009-10-23 08:16:06 UTC
this is the reason why I've put here the "OR" section of "expexted result": "produce error message if this tool can't handle (and is not expected to) work with netinstall isos"

Why it accepts non-livecd iso instead of error message or (at least) warning message that it won't work correctly?

I was not sure if this tool can handle netinstall iso, but I've just tried it expecting it'll refuse working non-livecd iso if it can't handle it. There was only checksum warning message. After that it prepared (incorrectly) working usb stick.

I still see my bug report as valid

Comment 5 Michal Hlavinka 2009-10-27 11:41:33 UTC
I've prepared two simple patches:
a) refuse netinstall cd
b) handle netinstall cd correctly

both of them are tested

Comment 6 Michal Hlavinka 2009-10-27 11:42:14 UTC
Created attachment 366244 [details]
a) refuse netinstall cd

Comment 7 Michal Hlavinka 2009-10-27 11:42:46 UTC
Created attachment 366245 [details]
b) handle netinstall cd correctly

Comment 8 Fedora Admin XMLRPC Client 2010-05-07 15:40:59 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 9 Jasper O'neal Hartline 2010-08-05 07:12:57 UTC
Please upgrade to the latest release.
I just tested with livecd-tools-031 and it works fine for a F14 boot.iso.
Closing.

Comment 10 Michal Hlavinka 2010-08-05 08:28:34 UTC
(In reply to comment #9)
> Please upgrade to the latest release.
> I just tested with livecd-tools-031 and it works fine for a F14 boot.iso.
> Closing.    

livecd-tools-031 is old not working version
I've tested it now with latest livecd-tools-033 and it still does not work, you'll get error messages from anaconda saying something is missing, but not so easy to understand (for unexperienced used) what exactly is missing.

you could not test netinstall iso for F14 because there is no netinstall iso yet, you've tried something else

for netinstall iso you can use F13 right now:
<some mirror>/fedora/linux/releases/13/Fedora/x86_64/iso/Fedora-13-x86_64-netinst.iso

Comment 11 Jasper O'neal Hartline 2010-08-05 11:37:15 UTC
I see you're correct, I was using a boot.iso.
I'll test your patches after getting them to apply clean against 033 and CC Bruno to this bug.

Comment 12 Michal Hlavinka 2010-08-05 12:10:41 UTC
result of only quick check:
you need to have stage2=hd:$USBLABEL:/images/install.img in kernel parameters to get netinstall working

Comment 13 Jasper O'neal Hartline 2010-08-05 12:37:44 UTC
I tested this and it doesn't work.
I tried with just stage2, I tried with stage2 and repo, I also tried with repo pointing straight to the ISO, and /mnt/isodir in which cases raise OSErrors that the directory doesn't exist and that the FILE (ISO) was not a directory.

However I believe if you pass a URL to repo, it will work and that is what I'm about to test. This is common usage for Netinstall ISO because the ISO it's self cannot be used as a repository source since it contains no RPM packages.

I will give you a patch shortly to try.

Comment 14 Michal Hlavinka 2010-08-05 13:08:01 UTC
what does not work?
livecd-tools creates usb with repo=hd:UUID=<uuid>:/ on kernel line, replace this with stage2=hd:UUID=<uuid>:/images/install.img and it must work

Comment 15 Jasper O'neal Hartline 2010-08-05 13:22:40 UTC
You are correct. I guess I *thought* I tried it without repo, but yes you are right. The only thing left now to do is determine that the ISO we're writing is not the DVD ISO, since it needs to use repo line. 

I will throw something dirty together and send it to this report.

Comment 16 Jasper O'neal Hartline 2010-08-05 13:41:57 UTC
Go ahead an try this attached patch against git.
It tests to make sure "netinst" is in the ISO name.

The normal DVD doesn't need this.

Comment 17 Jasper O'neal Hartline 2010-08-05 13:43:44 UTC
Created attachment 436851 [details]
Allows use of iso-to-disk script to be used with netinstall ISO

Allows iso-to-disk script to be used with netinstall ISO without breaking current DVD ISO functionality. Very useful.

Patches against git (08-05-2010)

Comment 18 Michal Hlavinka 2010-08-05 15:15:45 UTC
I've tested attached patch and it works fine. I'm just not sure about file name based detection.

Comment 19 Jasper O'neal Hartline 2010-08-05 15:33:03 UTC
In reply to Comment 18
Right I agree. In fact anyone could rename their Fedora-13-x86_64-netinst.iso to downloaded.iso and it would fail.

So we need to fix that somehow.

Comment 20 Jasper O'neal Hartline 2010-08-07 19:06:31 UTC
Closing as a duplicate of Bug 604942
There is also a committable patch there.

Bruno, care to queue the patch attached to 604942 to go into livecd-creator
when you get back?

*** This bug has been marked as a duplicate of bug 604942 ***


Note You need to log in before you can comment on or make changes to this bug.