Bug 535806 (RHQ-2464) - Alert definition creation doesn't reject invalid number format
Summary: Alert definition creation doesn't reject invalid number format
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: RHQ-2464
Product: RHQ Project
Classification: Other
Component: Alerts
Version: 1.3
Hardware: All
OS: All
low
low vote
Target Milestone: ---
: ---
Assignee: John Mazzitelli
QA Contact: Mike Foley
URL: http://jira.rhq-project.org/browse/RH...
Whiteboard:
Depends On:
Blocks: RHQ_Alerts rhq_auto_blocker rhq_chainsaw rhq4 jon-sprint10-bugs
TreeView+ depends on / blocked
 
Reported: 2009-10-14 18:54 UTC by Jeff Weiss
Modified: 2014-11-09 22:49 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-02 07:23:08 UTC


Attachments (Terms of Use)

Description Jeff Weiss 2009-10-14 18:54:00 UTC
To Repeat:

Create an alert def, on the "Absolute Value" or "% of" number fields, enter a number formatted like this:  "1.2.3" or "99.9.9".  Fill out the rest of the alert fields and click ok.  Instead of rejecting the bad input, it accepts it, but truncates from the 2nd dot.

Comment 1 Red Hat Bugzilla 2009-11-10 21:04:56 UTC
This bug was previously known as http://jira.rhq-project.org/browse/RHQ-2464


Comment 2 wes hayutin 2010-02-07 15:04:27 UTC
Sachin,
There may be several field checking issues regarding Alerts, I have found a few as well.  Can you drive this bug, and look for other similar issues.
Thanks

Comment 3 Bryan Kearney 2010-02-08 14:48:23 UTC
I will assign out when it is updated.

Comment 4 wes hayutin 2010-02-08 15:21:54 UTC
Sorry, I may have been unclear.
The bug is what is described in the description.
It is ready to be assigned to a developer.  Sachin will be the QA contact.

Thanks

Comment 5 spandey 2010-02-10 14:05:23 UTC
I am able to create Alert Name with spl char 

ie : ******************
 which should not be allowed .
Alert if Condition absolute Value option accepts -ve value 
ie : -0.1B
which should not be allowed

Comment 6 wes hayutin 2010-02-17 13:27:16 UTC
mass move to rhq_chainsaw tracker bug

Comment 7 wes hayutin 2010-02-18 14:49:49 UTC
This bug has now been triaged by Chainsaw on 2/18. The expectation is the bug to be addressed by the end of sprint06 roughly 3/10/10.

Comment 8 Justin Harris 2010-02-24 17:25:58 UTC
In commit:  dbbfa75ddfa4ce4443f2f72df49b483970ea4e8c

Comment 9 wes hayutin 2010-02-25 22:29:33 UTC
using names for alerts like 1.2.3 and 99.9% seem to be valid now and the links work

verified

Comment 10 wes hayutin 2010-02-26 14:02:05 UTC
botched this verify.. 
retesting..

adding 99.9.9 to abs value to a measurement threshold.
pass
try strings.. "asdf"
pass

Comment 11 wes hayutin 2010-02-26 14:16:46 UTC
now trying w/ 
Measurement Baseline
any metric
is > x
enter in 10.8888888888

The value is truncated to 10.9 after submit.
So as the bug is written this fails.

passing back to jharris to either fix or close as working as designed.

Comment 12 wes hayutin 2010-02-26 14:26:29 UTC
sorry.. and to add..

Measurement Baseline
any metric
is > x
enter in 1.2.3.4
The value is truncated to 1.2 after submit.

1.2.3.4 should be rejected as invalid..

Comment 13 Jeff Weiss 2010-04-09 14:21:14 UTC
Reassigning because I'm pretty sure Justin is no longer the dev for this component.

Comment 14 John Mazzitelli 2011-02-17 17:05:36 UTC
will look to see about putting in validators on the fields

Comment 15 John Mazzitelli 2011-02-18 21:44:34 UTC
commit f211290

The following fields now have validators on them:

Measurement Absolute Value Threshold : Metric Value
Measurement Baseline Threshold : Baseline Percentage
Call Time Value Threshold : Call Time Value
Call Time Value Change : Percentage Change

You now must enter a valid decimal. NOTE: you do not enter the percentage values as decimals (i.e. you do not enter .4 to mean 40%, you explicitly enter "40" to represent 40%) but you can enter fractional percentages (i.e. you enter "40.5" to represent 40.5%).

Comment 16 Mike Foley 2011-06-13 19:39:37 UTC
verified as follows: tested numeric fields with invalid numeric values...

9.9 valid
9.9.9 invalid
0.1 valid
0.1B invalid
abc invalid
#111 invalid

Comment 17 Heiko W. Rupp 2013-09-02 07:23:08 UTC
Bulk closing of issues that were VERIFIED, had no target release and where the status changed more than a year ago.


Note You need to log in before you can comment on or make changes to this bug.